]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
platform/x86: intel_sar: Check ACPI_HANDLE() against NULL
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 12 May 2026 15:15:32 +0000 (17:15 +0200)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tue, 19 May 2026 13:47:48 +0000 (16:47 +0300)
Every platform driver can be forced to match a device that doesn't match
its list of device IDs because of device_match_driver_override(), so
platform drivers that rely on the existence of a device's ACPI companion
object need to verify its presence.

Accordingly, add a requisite ACPI_HANDLE() check against NULL to the
platform/x86 intel_sar driver.

Fixes: dcfbd31ef4bc ("platform/x86: BIOS SAR driver for Intel M.2 Modem")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/14023870.uLZWGnKmhe@rafael.j.wysocki
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/intel/int1092/intel_sar.c

index 88822023a14902595817bee89a819f413c90d04f..849f7b415c1e59fb1717c2377c62034d8fe906a2 100644 (file)
@@ -245,15 +245,20 @@ static void sar_get_data(int reg, struct wwan_sar_context *context)
 static int sar_probe(struct platform_device *device)
 {
        struct wwan_sar_context *context;
+       acpi_handle handle;
        int reg;
        int result;
 
+       handle = ACPI_HANDLE(&device->dev);
+       if (!handle)
+               return -ENODEV;
+
        context = kzalloc_obj(*context);
        if (!context)
                return -ENOMEM;
 
        context->sar_device = device;
-       context->handle = ACPI_HANDLE(&device->dev);
+       context->handle = handle;
        dev_set_drvdata(&device->dev, context);
 
        result = guid_parse(SAR_DSM_UUID, &context->guid);