2568. [bug] Report when write to indicate a otherwise successful

                        start fail. [RT #19360]

diff --git a/CHANGES b/CHANGES
index 95e40f643c9a393c6917858e7bd60f3be7b6c868..9b7d9b9517f6f72c39946b10015cacb7aeaf9dbd 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,6 @@
+2568.  [bug]           Report when write to indicate a otherwise successful
+                       start fail. [RT #19360]
+
 2567.  [bug]           dst__privstruct_writefile() could miss write errors.
                        write_public_key() could miss write errors.
                        dnssec-dsfromkey could miss write errors.

diff --git a/bin/named/unix/os.c b/bin/named/unix/os.c
index b7ef09100907ac138b048f175171b947dc88ebdc..5e6b98f644e71d3c3272c42f2bf0f61c12f24507 100644 (file)
--- a/bin/named/unix/os.c
+++ b/bin/named/unix/os.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: os.c,v 1.89.12.4 2009/02/16 23:47:15 tbox Exp $ */
+/* $Id: os.c,v 1.89.12.5 2009/03/02 03:03:54 marka Exp $ */
 
 /*! \file */
 
@@ -462,10 +462,12 @@ ns_os_started(void) {
        char buf = 0;
 
        /*
-        * Signal to the parent that we stated successfully.
+        * Signal to the parent that we started successfully.
         */
        if (dfd[0] != -1 && dfd[1] != -1) {
-               write(dfd[1], &buf, 1);
+               if (write(dfd[1], &buf, 1) != 1)
+                       ns_main_earlyfatal("unable to signal parent that we "
+                                          "otherwise started successfully.");
                close(dfd[1]);
                dfd[0] = dfd[1] = -1;
        }