]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Remove unnecessary dns_rbt_fullnamefromnode call
authorMark Andrews <marka@isc.org>
Mon, 18 Oct 2021 03:05:37 +0000 (14:05 +1100)
committerPetr Špaček <pspacek@isc.org>
Thu, 2 Dec 2021 13:18:40 +0000 (14:18 +0100)
the results from dns_rbt_fullnamefromnode are not used.

lib/dns/rbtdb.c

index 5814f3e6a5b9193801d0ea49e0487aa724a50dd2..70893ee0293b27deeb1405d599de91bf300fa007 100644 (file)
@@ -1745,18 +1745,15 @@ delete_node(dns_rbtdb_t *rbtdb, dns_rbtnode_t *node) {
 
        switch (node->nsec) {
        case DNS_RBT_NSEC_NORMAL:
+               result = dns_rbt_deletenode(rbtdb->tree, node, false);
+               break;
+       case DNS_RBT_NSEC_HAS_NSEC:
                /*
                 * Though this may be wasteful, it has to be done before
                 * node is deleted.
                 */
                name = dns_fixedname_initname(&fname);
                dns_rbt_fullnamefromnode(node, name);
-
-               result = dns_rbt_deletenode(rbtdb->tree, node, false);
-               break;
-       case DNS_RBT_NSEC_HAS_NSEC:
-               name = dns_fixedname_initname(&fname);
-               dns_rbt_fullnamefromnode(node, name);
                /*
                 * Delete the corresponding node from the auxiliary NSEC
                 * tree before deleting from the main tree.