smbd: notify file truncation after dropping the sharemode lock

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 16276caf4480a46388b3917039bd1e535893d54c..523820fbae3e7a9ae9f995354a112ae014fc23d2 100644 (file)
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -3883,6 +3883,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
        bool def_acl = False;
        bool posix_open = False;
        bool new_file_created = False;
+       bool truncated = false;
        bool first_open_attempt = true;
        bool is_twrp = (smb_fname_atname->twrp != 0);
        NTSTATUS fsp_open = NT_STATUS_ACCESS_DENIED;
@@ -4468,10 +4469,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                                open_ntcreate_lock_cleanup_entry;
                        goto unlock;
                }
-               notify_fname(fsp->conn, NOTIFY_ACTION_MODIFIED,
-                            FILE_NOTIFY_CHANGE_SIZE
-                            | FILE_NOTIFY_CHANGE_ATTRIBUTES,
-                            fsp->fsp_name->base_name);
+               truncated = true;
        }
 
        /*
@@ -4654,7 +4652,13 @@ unlock:
                             FILE_NOTIFY_CHANGE_FILE_NAME,
                             smb_fname->base_name);
        }
-
+       if (truncated) {
+               notify_fname(fsp->conn,
+                            NOTIFY_ACTION_MODIFIED,
+                            FILE_NOTIFY_CHANGE_SIZE |
+                            FILE_NOTIFY_CHANGE_ATTRIBUTES,
+                            fsp->fsp_name->base_name);
+       }
        if (!NT_STATUS_IS_OK(status)) {
                fd_close(fsp);
                return status;