]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Stop passing mctx to dns_rdata_tostruct as it is unnecessary for SIG
authorMark Andrews <marka@isc.org>
Wed, 21 Sep 2022 01:54:48 +0000 (11:54 +1000)
committerPetr Špaček <pspacek@isc.org>
Mon, 26 Sep 2022 10:45:21 +0000 (12:45 +0200)
dns_rdata_tostruct doesn't need a mctx passed to it for SIG (the signer
is already expanded at this point). About the only time when mctx is
needed is when the structure is to be used after the rdata has been
destroyed.

(cherry picked from commit d6ad56bd9e98382f8bd41a25756efdbbc3e39bd9)

lib/dns/message.c

index 7b3d72abd9718b009e324827e46f83e930c45257..05aaf03090fa3973aac95477dd4ad0d9660b9117 100644 (file)
@@ -3220,7 +3220,7 @@ dns_message_checksig(dns_message_t *msg, dns_view_t *view) {
                        return (ISC_R_UNEXPECTEDEND);
                }
 
-               result = dns_rdata_tostruct(&rdata, &sig, msg->mctx);
+               result = dns_rdata_tostruct(&rdata, &sig, NULL);
                if (result != ISC_R_SUCCESS) {
                        return (result);
                }