]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ASoC: soc-utils: Add missing va_end in snd_soc_ret()
authorRobertus Diawan Chris <robertusdchris@gmail.com>
Tue, 19 May 2026 05:40:24 +0000 (12:40 +0700)
committerMark Brown <broonie@kernel.org>
Tue, 19 May 2026 14:57:03 +0000 (15:57 +0100)
The default case in snd_soc_ret() use va_start without va_end to
cleanup "args" object which can cause undefined behavior. So, add
missing va_end to cleanup "args" object.

This is reported by Coverity Scan as "Missing varargs init or cleanup".

Fixes: 943116ba2a6a ("ASoC: add common snd_soc_ret() and use it")
Signed-off-by: Robertus Diawan Chris <robertusdchris@gmail.com>
Link: https://patch.msgid.link/20260519054024.274741-1-robertusdchris@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-utils.c

index c8adfff826bd4744813e8b9ccfe0b46ae3fae37d..9cb7567e263eb20cca79cc07bfd862398f7c2027 100644 (file)
@@ -36,6 +36,7 @@ int snd_soc_ret(const struct device *dev, int ret, const char *fmt, ...)
                vaf.va = &args;
 
                dev_err(dev, "ASoC error (%d): %pV", ret, &vaf);
+               va_end(args);
        }
 
        return ret;