Add a release note about dropping support for non-dotted-quad IPv4 addresses in maste...

Support for non-dotted-quad IPv4 addresses in master files was dropped
when the inet_aton() call inside getquad() got replaced with a call to
inet_pton(), so a release note should have been added back then to
inform users that such syntax will no longer work.

diff --git a/doc/arm/notes.xml b/doc/arm/notes.xml
index dae01a0442f839acbb3f4e861bc81be35b53a278..599a29148b860539a736ce79a7a44bfa274da00f 100644 (file)
--- a/doc/arm/notes.xml
+++ b/doc/arm/notes.xml
@@ -88,6 +88,12 @@
          been removed. [GL #93]
        </para>
       </listitem>
+      <listitem>
+       <para>
+         IPv4 addresses in forms other than dotted-quad are no longer
+         accepted in master files. [GL #13] [GL #56]
+       </para>
+      </listitem>
     </itemizedlist>
   </section>
 

diff --git a/lib/dns/tests/rdata_test.c b/lib/dns/tests/rdata_test.c
index 02200a47f51e3bc07b800182900829422672bed6..0a9b94b2d6f2093a7217ac5fda1c95466a7ff6fa 100644 (file)
--- a/lib/dns/tests/rdata_test.c
+++ b/lib/dns/tests/rdata_test.c
@@ -1137,6 +1137,20 @@ ATF_TC_HEAD(wks, tc) {
        atf_tc_set_md_var(tc, "descr", "WKS RDATA manipulations");
 }
 ATF_TC_BODY(wks, tc) {
+       text_ok_t text_ok[] = {
+               /*
+                * Valid, IPv4 address in dotted-quad form.
+                */
+               TEXT_VALID("127.0.0.1 6"),
+               /*
+                * Invalid, IPv4 address not in dotted-quad form.
+                */
+               TEXT_INVALID("127.1 6"),
+               /*
+                * Sentinel.
+                */
+               TEXT_SENTINEL()
+       };
        wire_ok_t wire_ok[] = {
                /*
                 * Too short.
@@ -1162,7 +1176,7 @@ ATF_TC_BODY(wks, tc) {
 
        UNUSED(tc);
 
-       check_rdata(NULL, wire_ok, ISC_FALSE, dns_rdataclass_in,
+       check_rdata(text_ok, wire_ok, ISC_FALSE, dns_rdataclass_in,
                    dns_rdatatype_wks, sizeof(dns_rdata_in_wks_t));
 }