]> git.ipfire.org Git - thirdparty/openvpn.git/commitdiff
win: Fix nrpt_dnssec flag handling
authorFrank Lichtenheld <frank@lichtenheld.com>
Sun, 5 Apr 2026 10:22:04 +0000 (12:22 +0200)
committerGert Doering <gert@greenie.muc.de>
Sun, 5 Apr 2026 14:31:49 +0000 (16:31 +0200)
By default the first enum value is 0.
But we check whether we set the flag by doing
BOOL dnssec = (msg->flags & nrpt_dnssec) != 0;
This can't ever be true.

Found by cppcheck.

Change-Id: Iff5be978817bfc0cd4d78818e7be7b90bad71f3c
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1606
Message-Id: <20260405102209.31528-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36487.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit 08a19843a184c6cb8850ac9e6bf7ce0cd4d15d37)

include/openvpn-msg.h

index a0cec53a8894bacd72dbc80bbe399802dfb56d06..ca9c9038e8465999238c4d1d8b995896f646811e 100644 (file)
@@ -109,7 +109,7 @@ typedef struct
 
 typedef enum
 {
-    nrpt_dnssec
+    nrpt_dnssec = 1 << 0,
 } nrpt_flags_t;
 
 #define NRPT_ADDR_NUM  8  /* Max. number of addresses */