3070. [bug] dnssec-signzone potential NULL pointer dereference.

                        [RT #20256]

diff --git a/CHANGES b/CHANGES
index 8655857522022e980f4195d228a2ca1ad0e71ac0..ff63bf31d4bfdda793e153efa7b917e65d557c3a 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,6 @@
+3070.  [bug]           dnssec-signzone potential NULL pointer dereference.
+                       [RT #20256]
+
 3069.  [cleanup]       Silence warnings messages from clang static analysis.
                        [RT #20256]
 

diff --git a/bin/dnssec/dnssec-signzone.c b/bin/dnssec/dnssec-signzone.c
index 7e4a40304ccd8689eff950db01f6b1cd5bd7b091..223193ac70922b6bc4bc0bd00318ec15ec4611d5 100644 (file)
--- a/bin/dnssec/dnssec-signzone.c
+++ b/bin/dnssec/dnssec-signzone.c
@@ -29,7 +29,7 @@
  * IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: dnssec-signzone.c,v 1.262.110.3 2011/03/11 06:46:59 marka Exp $ */
+/* $Id: dnssec-signzone.c,v 1.262.110.4 2011/03/11 12:40:37 marka Exp $ */
 
 /*! \file */
 
@@ -522,7 +522,8 @@ signset(dns_diff_t *del, dns_diff_t *add, dns_dbnode_t *node, dns_name_t *name,
                }
 
                if (keep) {
-                       nowsignedby[key->index] = ISC_TRUE;
+                       if (key != NULL)
+                               nowsignedby[key->index] = ISC_TRUE;
                        INCSTAT(nretained);
                        if (sigset.ttl != ttl) {
                                vbprintf(2, "\tfixing ttl %s\n", sigstr);