]> git.ipfire.org Git - thirdparty/openvpn.git/commitdiff
openvpnserv: always use W variant of RpcStringFree() master
authorFrank Lichtenheld <frank@lichtenheld.com>
Thu, 14 May 2026 09:19:12 +0000 (11:19 +0200)
committerGert Doering <gert@greenie.muc.de>
Thu, 14 May 2026 14:47:54 +0000 (16:47 +0200)
Probably not a real issue since it should always use the
W version in our case, but still unclean.

Fixes a cppcheck complaint.

Change-Id: I3d391016dcd3c66e58f3f05b356bcd419224acb1
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Heiko Hund <heiko@openvpn.net>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1671
Message-Id: <20260514091918.18197-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36915.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpnserv/interactive.c

index 7726bc92395e0a300d5e93fead290d2839a08d4e..788a5783940f84c1ef25eeaeab5f7d00754a3950 100644 (file)
@@ -3487,7 +3487,7 @@ RunOpenvpn(LPVOID p)
     swprintf(ovpn_pipe_name, _countof(ovpn_pipe_name),
              L"\\\\.\\pipe\\" _L(PACKAGE) L"%ls\\service_%lu_%ls", service_instance,
              GetCurrentThreadId(), pipe_uuid_str);
-    RpcStringFree(&pipe_uuid_str);
+    RpcStringFreeW(&pipe_uuid_str);
 
     /* make a security descriptor for the named pipe with access
      * restricted to the user and SYSTEM