]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
of: fix of_device_get_modalias returned length when truncating buffers
authorRob Herring <robh@kernel.org>
Mon, 16 Jan 2017 20:28:39 +0000 (14:28 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 22 Mar 2018 08:37:13 +0000 (09:37 +0100)
[ Upstream commit bcf54d5385abaea9c8026aae6f4eeb348671a52d ]

If the length of the modalias is greater than the buffer size, then the
modalias is truncated. However the untruncated length is returned which
will cause an error. Fix this to return the truncated length. If an error
in the case was desired, then then we should just return -ENOMEM.

The reality is no device will ever have 4KB of compatible strings to hit
this case.

Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/of/device.c

index de20165bad484092b02b58fcb288e184da3ee707..2ef5ca45a136a2d6daf1bd34f63ae0a9a0fce516 100644 (file)
@@ -126,7 +126,7 @@ ssize_t of_device_get_modalias(struct device *dev, char *str, ssize_t len)
                        str[i] = '_';
        }
 
-       return tsize;
+       return repend;
 }
 EXPORT_SYMBOL_GPL(of_device_get_modalias);