]> git.ipfire.org Git - thirdparty/snort3.git/commitdiff
Pull request #5162: appid: remove assertion while processing dns pkt
authorSatyajit Padalkar (spadalka) <spadalka@cisco.com>
Tue, 24 Feb 2026 13:50:11 +0000 (13:50 +0000)
committerChris Sherwin (chsherwi) <chsherwi@cisco.com>
Tue, 24 Feb 2026 13:50:11 +0000 (13:50 +0000)
Merge in SNORT/snort3 from ~SPADALKA/snort3:dns_assertion_error to master

Squashed commit of the following:

commit 0207efa74005a88bbbb5817e696bc369582cef57
Author: Satyajit Padalkar <spadalka@cisco.com>
Date:   Fri Feb 13 11:23:50 2026 -0500

    appid: remove assertion while processing dns pkt

src/network_inspectors/appid/appid_dns_payload_event_handler.cc

index ac5fa55a534ee09f1f7c7ea74f923c2cc7a8c047..7e6884176152e7dee12ac790d3ca6dfeb7924aed 100644 (file)
@@ -94,8 +94,9 @@ void AppIdDnsPayloadEventHandler::handle(DataEvent& event, Flow* flow)
                 }
                 else
                 {
-                    assert(false);
-                    return; // we should not reach here
+                    // Stream ID not yet assigned, defer DNS payload processing
+                    APPID_LOG(p, TRACE_DEBUG_LEVEL, "Stream ID not assigned yet for HTTP/2 or HTTP/3 flow\n");
+                    return;
                 }
             }
         }
@@ -109,7 +110,6 @@ void AppIdDnsPayloadEventHandler::handle(DataEvent& event, Flow* flow)
             asd->set_ss_application_ids_payload(APP_ID_DNS, change_bits);
         }
         AppIdDnsSession* dsession = asd->get_dns_session();
-        assert(dsession);
         if (!dsession)
             return;
         dsession->set_doh(true);