]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
vsh-table: Refactor cleanup in 'vshTableRowNew'
authorPeter Krempa <pkrempa@redhat.com>
Fri, 17 Apr 2026 09:49:43 +0000 (11:49 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 24 Apr 2026 09:29:01 +0000 (11:29 +0200)
The 'error' label is not needed, we can directly return failure from the
only error.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
tools/vsh-table.c

index da7dc84ee80d0793ca8653582775107906d61402..20d25eb227ae47e4983125f7c2a642c06719132f 100644 (file)
@@ -92,7 +92,7 @@ vshTableRowNew(const char *arg, va_list ap)
     if (!arg) {
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                        _("Table row cannot be empty"));
-        goto error;
+        return NULL;
     }
 
     row = g_new0(vshTableRow, 1);
@@ -108,10 +108,6 @@ vshTableRowNew(const char *arg, va_list ap)
     }
 
     return row;
-
- error:
-    vshTableRowFree(row);
-    return NULL;
 }