]> git.ipfire.org Git - thirdparty/google/fonts.git/commitdiff
Big Shoulders Inline Text: correct override config source path for fontc_crater build
authorFelipe Correa da Silva Sanches <juca@members.fsf.org>
Fri, 29 May 2026 08:06:21 +0000 (09:06 +0100)
committerFelipe Corrêa da Silva Sanches <juca@members.fsf.org>
Fri, 29 May 2026 09:48:35 +0000 (10:48 +0100)
The override config.yaml used `../`-prefixed paths that escape the repo
root when resolved by the build harness. Removed the `../` prefix and corrected the .glyphs source name to the underscored form present at the pinned commit.
Recipe output paths made repo-root-relative likewise.

Repo:   xotypeco/big_shoulders
Commit: 41153e6fe01d218e933919a1d08c8e45065bc8fe (unchanged; verified correct)
Config: ../Big-Shoulders... -> Big-Shoulders-Inline/sources/Big_Shoulders_Inline.glyphs (and recipe outputs)
Status: source path corrected (verified present at build commit; gftools-builder smoke-test passed)
Confidence: High

Assisted by an AI agent (Claude Opus 4.8)

ofl/bigshouldersinlinetext/config.yaml
ofl/bigshouldersinlinetext/upstream_info.md

index 276bb25099cf20c6c9cfd95d416f6967cea5cbb0..80e3dfe76aac1f15316793abb2e2e3dafcb2e1de 100644 (file)
@@ -1,8 +1,8 @@
 sources:
-    - ../Big-Shoulders-Inline/sources/BigShouldersInline.glyphs
+    - Big-Shoulders-Inline/sources/Big_Shoulders_Inline.glyphs
 recipe:
-  ../Big-Shoulders-Inline/fonts/variable/text/BigShouldersInlineText[wght].ttf:
-    - source: ../Big-Shoulders-Inline/sources/BigShouldersInline.glyphs
+  Big-Shoulders-Inline/fonts/variable/text/BigShouldersInlineText[wght].ttf:
+    - source: Big-Shoulders-Inline/sources/Big_Shoulders_Inline.glyphs
     - args: --filter ...  --filter FlattenComponentsFilter --filter DecomposeTransformedComponentsFilter
       operation: buildVariable
     - operation: subspace
@@ -13,8 +13,8 @@ recipe:
     - operation: fix
     - postprocess: buildStat
   # And now the small caps family
-  ../Big-Shoulders-Inline/fonts/variable/text/BigShouldersInlineTextSC[wght].ttf:
-    - source: ../Big-Shoulders-Inline/sources/BigShouldersInline.glyphs
+  Big-Shoulders-Inline/fonts/variable/text/BigShouldersInlineTextSC[wght].ttf:
+    - source: Big-Shoulders-Inline/sources/Big_Shoulders_Inline.glyphs
     - args: --filter ...  --filter FlattenComponentsFilter --filter DecomposeTransformedComponentsFilter
       operation: buildVariable
     - operation: subspace
index 871dd560825dc02e6d7b8b375e6b92cc53958b9b..d83fb382faef7f389c1c8d06e28244a3546a3b6c 100644 (file)
@@ -60,3 +60,12 @@ The override config defines a recipe that:
 ## Open Questions
 
 1. **METADATA.pb needs correction**: The commit hash should be updated from `41153e6fe01d218e933919a1d08c8e45065bc8fe` to `2f924dd1205484c5e0054b1f3955f434224ba72e`. This should be included in a PR to google/fonts (same correction as Big Shoulders Inline Display). The tracking data in `gfonts_library_sources.json` also needs updating.
+
+
+## Correction (2026-05-28) — override config source path
+
+**Model**: Claude Opus 4.8
+
+fontc_crater reported `missing source '../Big-Shoulders/sources/BigShoulders.glyphs'` for the xotypeco/big_shoulders monorepo. The override `config.yaml` used paths prefixed with `../`, which the build harness resolves relative to the repository root and therefore escape the checkout. For this family the repo-escaping `../` prefix was removed and the `.glyphs` source name was corrected to the underscored form present at the pinned commit: `Big-Shoulders-Inline/sources/Big_Shoulders_Inline.glyphs` (verified present at the pinned commit `41153e6`). The recipe output paths were made repo-root-relative likewise. The pinned commit is unchanged.
+
+A local gftools-builder smoke-test of the corrected config built the variable TTFs successfully (RC=0), confirming the path fix is sufficient.