]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
accel/amdxdna: Fix mm_struct reference leak in aie2_populate_range()
authorLizhi Hou <lizhi.hou@amd.com>
Wed, 10 Jun 2026 15:11:27 +0000 (08:11 -0700)
committerLizhi Hou <lizhi.hou@amd.com>
Thu, 11 Jun 2026 16:50:07 +0000 (09:50 -0700)
aie2_populate_range() jumps back to the again label without calling
mmput(mm), leaking a reference to the mm_struct.

Add the missing mmput() before jumping to again.

Fixes: e486147c912f ("accel/amdxdna: Add BO import and export")
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Link: https://patch.msgid.link/20260610151127.2994185-1-lizhi.hou@amd.com
drivers/accel/amdxdna/aie2_ctx.c

index 286379d9511d4cc4a59c79af386f0dc5b684e9a2..eed3d0ec541336f8182d4dbd178b246e9cd1f2d1 100644 (file)
@@ -999,6 +999,7 @@ again:
 
                if (ret == -EBUSY) {
                        amdxdna_umap_put(mapp);
+                       mmput(mm);
                        goto again;
                }
 
@@ -1009,11 +1010,13 @@ again:
        if (mmu_interval_read_retry(&mapp->notifier, mapp->range.notifier_seq)) {
                up_write(&xdna->notifier_lock);
                amdxdna_umap_put(mapp);
+               mmput(mm);
                goto again;
        }
        mapp->invalid = false;
        up_write(&xdna->notifier_lock);
        amdxdna_umap_put(mapp);
+       mmput(mm);
        goto again;
 
 put_mm: