]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
rtc: ntxec: fix OF node reference imbalance
authorJohan Hovold <johan@kernel.org>
Tue, 7 Apr 2026 12:27:17 +0000 (14:27 +0200)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 12 Apr 2026 20:54:35 +0000 (22:54 +0200)
The driver reuses the OF node of the parent multi-function device but
fails to take another reference to balance the one dropped by the
platform bus code when unbinding the MFD and deregistering the child
devices.

Fix this by using the intended helper for reusing OF nodes.

Fixes: 435af89786c6 ("rtc: New driver for RTC in Netronix embedded controller")
Cc: stable@vger.kernel.org # 5.13
Cc: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260407122717.2676774-1-johan@kernel.org
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-ntxec.c

index 850ca49186fdcf74d89dd20cf54434d88cec42a3..d28ddb34e19e77b69ea82cbae4d0155cc285302e 100644 (file)
@@ -110,7 +110,7 @@ static int ntxec_rtc_probe(struct platform_device *pdev)
        struct rtc_device *dev;
        struct ntxec_rtc *rtc;
 
-       pdev->dev.of_node = pdev->dev.parent->of_node;
+       device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent);
 
        rtc = devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL);
        if (!rtc)