]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ACPI: button: Add missing device class clearing on probe failures
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 22 May 2026 14:53:48 +0000 (16:53 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 25 May 2026 07:52:34 +0000 (09:52 +0200)
Commit e18947038bf4 ("ACPI: driver: Do not set acpi_device_class()
unnecessarily") modified acpi_button_remove() to clear the device class
field in struct acpi_device on driver removal, but it should also have
updated the rollback path in acpi_button_probe(), which it didn't do,
so do it now.

Fixes: e18947038bf4 ("ACPI: driver: Do not set acpi_device_class() unnecessarily")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
Link: https://patch.msgid.link/6167713.MhkbZ0Pkbq@rafael.j.wysocki
drivers/acpi/button.c

index e8dd306e17edbba696f6d28a1812d914021da2d0..d80276368b810fd229925596b21d9e1118a5e036 100644 (file)
@@ -687,6 +687,7 @@ err_remove_fs:
        acpi_button_remove_fs(button);
 err_free_button:
        kfree(button);
+       memset(acpi_device_class(device), 0, sizeof(acpi_device_class));
        return error;
 }