1668. [bug] DIG_SIGCHASE was making bin/dig/host dump core.

diff --git a/CHANGES b/CHANGES
index 72201960ea096957ee42aac0a5bece6e02386f59..7ff12fa3e6ef441f1b23b738fa618a2ddb96c3a5 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,5 @@
+1668.  [bug]           DIG_SIGCHASE was making bin/dig/host dump core.
+
 1667.  [port]          linux: not all versions have IF_NAMESIZE.
 
 1666.  [bug]           The optional port on hostnames in dual-stack-servers

diff --git a/bin/dig/dig.c b/bin/dig/dig.c
index cb7b9b670bacfb9caf9999a8dfa976c0d02e9fcb..224d8dfc7de5d22812474f47cb11d65159d958e8 100644 (file)
--- a/bin/dig/dig.c
+++ b/bin/dig/dig.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: dig.c,v 1.192 2004/06/07 03:56:02 marka Exp $ */
+/* $Id: dig.c,v 1.193 2004/06/19 02:23:32 sra Exp $ */
 
 #include <config.h>
 #include <stdlib.h>
@@ -41,15 +41,6 @@
 #include <dns/rdataclass.h>
 #include <dns/result.h>
 
-#ifdef DIG_SIGCHASE
-#ifndef DIG_SIGCHASE_BU
-#define DIG_SIGCHASE_BU 1
-#endif
-#ifndef DIG_SIGCHASE_TD
-#define DIG_SIGCHASE_TD 1
-#endif
-#endif
-
 #include <dig/dig.h>
 
 extern ISC_LIST(dig_lookup_t) lookup_list;

diff --git a/bin/dig/dighost.c b/bin/dig/dighost.c
index 8a6a136bc863a42502222af280f112a2b584f8cb..3ba6ba7ef2a8d4f1aeeea55cb32e522f1c152c64 100644 (file)
--- a/bin/dig/dighost.c
+++ b/bin/dig/dighost.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: dighost.c,v 1.262 2004/06/11 00:27:02 marka Exp $ */
+/* $Id: dighost.c,v 1.263 2004/06/19 02:23:33 sra Exp $ */
 
 /*
  * Notice to programmers:  Do not use this code as an example of how to
@@ -32,15 +32,6 @@
 #include <string.h>
 #include <limits.h>
 
-#ifdef DIG_SIGCHASE
-#ifndef DIG_SIGCHASE_BU
-#define DIG_SIGCHASE_BU 1
-#endif
-#ifndef DIG_SIGCHASE_TD
-#define DIG_SIGCHASE_TD 1
-#endif
-#endif 
-
 #include <dns/byaddr.h>
 #ifdef DIG_SIGCHASE
 #include <dns/dnssec.h>
@@ -2864,7 +2855,8 @@ recv_done(isc_task_t *task, isc_event_t *event) {
                                fatal("Memory allocation failure in %s:%d",
                                      __FILE__, __LINE__);
                        }
-                       ISC_LIST_APPEND(chase_message_list, chase_msg, link);
+                       ISC_LIST_INITANDAPPEND(chase_message_list, chase_msg,
+                                              link);
                        if (dns_message_create(mctx, DNS_MESSAGE_INTENTPARSE,
                                               &msg_temp) != ISC_R_SUCCESS) {
                                fatal("dns_message_create in %s:%d",
@@ -2889,7 +2881,8 @@ recv_done(isc_task_t *task, isc_event_t *event) {
                                fatal("Memory allocation failure in %s:%d",
                                      __FILE__, __LINE__);
                        }
-                       ISC_LIST_APPEND(chase_message_list2, chase_msg2, link);
+                       ISC_LIST_INITANDAPPEND(chase_message_list2, chase_msg2,
+                                              link);
                        chase_msg2->msg = msg;
                }
 #endif

diff --git a/bin/dig/include/dig/dig.h b/bin/dig/include/dig/dig.h
index ce252d4761802298839c6d8c695b5b62fbb055db..067c08649b1e0f98080cd4f408d1c69e0f56af02 100644 (file)
--- a/bin/dig/include/dig/dig.h
+++ b/bin/dig/include/dig/dig.h
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: dig.h,v 1.84 2004/04/13 02:54:15 marka Exp $ */
+/* $Id: dig.h,v 1.85 2004/06/19 02:23:36 sra Exp $ */
 
 #ifndef DIG_H
 #define DIG_H
@@ -74,6 +74,19 @@
  * be 1.
  */
 
+/*
+ * Defaults for the sigchase suboptions.  Consolidated here because
+ * these control the layout of dig_lookup_t (among other things).
+ */
+#ifdef DIG_SIGCHASE
+#ifndef DIG_SIGCHASE_BU
+#define DIG_SIGCHASE_BU 1
+#endif
+#ifndef DIG_SIGCHASE_TD
+#define DIG_SIGCHASE_TD 1
+#endif
+#endif
+
 ISC_LANG_BEGINDECLS
 
 typedef struct dig_lookup dig_lookup_t;

diff --git a/bin/dig/nslookup.c b/bin/dig/nslookup.c
index f12c5a02b99ec3819e5827ea6d1ad9c9d5877d9e..6664fd0e40e1f37095c31ae55cdfb7e9f8e96dbc 100644 (file)
--- a/bin/dig/nslookup.c
+++ b/bin/dig/nslookup.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: nslookup.c,v 1.104 2004/06/07 03:56:02 marka Exp $ */
+/* $Id: nslookup.c,v 1.105 2004/06/19 02:23:34 sra Exp $ */
 
 #include <config.h>
 
@@ -42,15 +42,6 @@
 #include <dns/rdatatype.h>
 #include <dns/byaddr.h>
 
-#ifdef DIG_SIGCHASE
-#ifndef DIG_SIGCHASE_BU
-#define DIG_SIGCHASE_BU 1
-#endif
-#ifndef DIG_SIGCHASE_TD
-#define DIG_SIGCHASE_TD 1
-#endif
-#endif
-
 #include <dig/dig.h>
 
 extern ISC_LIST(dig_lookup_t) lookup_list;