realtek: mdio: harden RTMDIO_C45_DATA macro

Maximum devnum in c45 access is only 31. The bits 21-31 of the MMD
register are reserved and cannot be written. Nevertheless add a
proper mask to help AI review bots.

Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de>
Link: https://github.com/openwrt/openwrt/pull/23204
Signed-off-by: Robert Marko <robimarko@gmail.com>

diff --git a/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c b/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c
index 57ff941b7705c6571e5977e0559048e9020382ca..329bafcc961bfc16bca0672862fe9a4abae8439d 100644 (file)
--- a/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c
+++ b/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c
@@ -44,7 +44,8 @@
                                                 ((reg) & GENMASK(15, 0)))
 
 /* MDIO bus registers/fields */
-#define RTMDIO_C45_DATA(devnum, regnum)                (((devnum) << 16) | ((regnum) & GENMASK(15, 0)))
+#define RTMDIO_C45_DATA(devnum, regnum)                ((((devnum) & GENMASK(4, 0)) << 16) | \
+                                                 ((regnum) & GENMASK(15, 0)))
 #define RTMDIO_DATA_MASK                       GENMASK(15, 0)
 #define RTMDIO_RUN                             BIT(0)