misc: fastrpc: Clean buffers on remote invocation failures

commit 1c8093591d1e372d700fe65423e7315a8ecf721b upstream.

With current design, buffers and dma handles are not freed in case
of remote invocation failures returned from DSP. This could result
in buffer leakings and dma handle pointing to wrong memory in the
fastrpc kernel. Adding changes to clean buffers and dma handles
even when remote invocation to DSP returns failures.

Fixes: c68cfb718c8f ("misc: fastrpc: Add support for context Invoke method")
Cc: stable <stable@kernel.org>
Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20231013122007.174464-4-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
index ef318a255fccd2ce67095a4e6c2db208d0604ba8..62e92b755983fc91515d40dca28ddf9e9ca6f566 100644 (file)
--- a/drivers/misc/fastrpc.c
+++ b/drivers/misc/fastrpc.c
@@ -1119,11 +1119,6 @@ static int fastrpc_internal_invoke(struct fastrpc_user *fl,  u32 kernel,
                err = wait_for_completion_interruptible(&ctx->work);
        }
 
-       if (err)
-               goto bail;
-
-       /* Check the response from remote dsp */
-       err = ctx->retval;
        if (err)
                goto bail;
 
@@ -1134,6 +1129,11 @@ static int fastrpc_internal_invoke(struct fastrpc_user *fl,  u32 kernel,
        if (err)
                goto bail;
 
+       /* Check the response from remote dsp */
+       err = ctx->retval;
+       if (err)
+               goto bail;
+
 bail:
        if (err != -ERESTARTSYS && err != -ETIMEDOUT) {
                /* We are done with this compute context */