]> git.ipfire.org Git - thirdparty/dracut-ng.git/commitdiff
fix(zipl): quote zipl_env variable
authorBenjamin Drung <benjamin.drung@canonical.com>
Sat, 15 Jun 2024 13:29:05 +0000 (15:29 +0200)
committerLaszlo Gombos <laszlo.gombos@gmail.com>
Sat, 15 Jun 2024 13:53:09 +0000 (09:53 -0400)
shellcheck complains about SC2086 (info): Double quote to prevent
globbing and word splitting.

Only strings without spaces are assigned to the `zipl_env` variable.
Therefore it is safe to be quoted.

Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
modules.d/91zipl/parse-zipl.sh

index d95a1ddc49c8d10547c0b0a3c15c1bb7d49e41e9..dc0a2917d09766b8dac7d14c3703777a40d40c3b 100755 (executable)
@@ -42,7 +42,7 @@ if [ -n "$zipl_arg" ]; then
     if [ "$zipl_env" ]; then
         {
             printf 'ACTION=="add|change", SUBSYSTEM=="block", %s=="%s", ENV{SYSTEMD_READY}!="0", RUN+="/sbin/initqueue --settled --onetime --unique --name install_zipl_cmdline /sbin/install_zipl_cmdline.sh %s"\n' \
-                ${zipl_env} "${zipl_val}" "${zipl_arg}"
+                "${zipl_env}" "${zipl_val}" "${zipl_arg}"
             echo "[ -f /tmp/install.zipl.cmdline-done ]" > "$hookdir"/initqueue/finished/wait-zipl-conf.sh
         } >> /etc/udev/rules.d/99zipl-conf.rules
         cat /etc/udev/rules.d/99zipl-conf.rules