listcontrol: replace __attribute__((fallthrough)) with comment

The __attribute__((fallthrough)) statement was added in GCC 7. Older
versions treat it as an empty declaration and emit a warning. Use a
/* fallthrough */ comment instead, which GCC (-Wimplicit-fallthrough)
and Clang both recognise as an intentional fallthrough annotation.

Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Assisted-by: claude-opus-4-6

diff --git a/src/listcontrol.c b/src/listcontrol.c
index 2d4927d0bf84d68e5324a2f51f9d702f994df997..c114727b0d10ba27cbd21f5743e9b2f8fefdd448 100644 (file)
--- a/src/listcontrol.c
+++ b/src/listcontrol.c
@@ -256,7 +256,7 @@ int listcontrol(strlist *fromemails, struct ml *ml, const char *controlstr,
                sub.type = "digest";
                sub.typesub = SUB_DIGEST;
                sub.typedeny = "sub-deny-digest";
-               __attribute__ ((fallthrough));
+               /* fallthrough */
        /* listname+subscribe-nomail@domain.tld */
        case CTRL_SUBSCRIBE_NOMAIL:
                if (sub.typereq == NULL) {
@@ -266,7 +266,7 @@ int listcontrol(strlist *fromemails, struct ml *ml, const char *controlstr,
                        sub.type = "nomail";
                        sub.typedeny = "sub-deny-nomail";
                }
-               __attribute__ ((fallthrough));
+               /* fallthrough */
        /* listname+subscribe-both@domain.tld */
        case CTRL_SUBSCRIBE_BOTH:
                if (sub.typereq == NULL) {
@@ -276,7 +276,7 @@ int listcontrol(strlist *fromemails, struct ml *ml, const char *controlstr,
                        sub.type = "both";
                        sub.typedeny = "sub-deny-digest";
                }
-               __attribute__ ((fallthrough));
+               /* fallthrough */
        /* listname+subscribe@domain.tld */
        case CTRL_SUBSCRIBE:
                if (sub.typereq == NULL) {
@@ -292,21 +292,21 @@ int listcontrol(strlist *fromemails, struct ml *ml, const char *controlstr,
        case CTRL_CONFSUB_DIGEST:
                subc.typesub = SUB_DIGEST;
                subtypename = "digest";
-               __attribute__ ((fallthrough));
+               /* fallthrough */
        /* listname+subconf-nomail-COOKIE@domain.tld */
        case CTRL_CONFSUB_NOMAIL:
                if (subtypename == NULL) {
                        subc.typesub = SUB_NOMAIL;
                        subtypename = "nomail";
                }
-               __attribute__ ((fallthrough));
+               /* fallthrough */
        /* listname+subconf-both-COOKIE@domain.tld */
        case CTRL_CONFSUB_BOTH:
                if (subtypename == NULL) {
                        subc.typesub = SUB_BOTH;
                        subtypename = "both";
                }
-               __attribute__ ((fallthrough));
+               /* fallthrough */
        /* listname+subconf-COOKIE@domain.tld */
        case CTRL_CONFSUB:
                if (subtypename == NULL) {
@@ -349,14 +349,14 @@ int listcontrol(strlist *fromemails, struct ml *ml, const char *controlstr,
        case CTRL_CONFUNSUB_DIGEST:
                ts = SUB_DIGEST;
                subtypename = "-digest";
-               __attribute__ ((fallthrough));
+               /* fallthrough */
        /* listname+unsubconf-nomail-COOKIE@domain.tld */
        case CTRL_CONFUNSUB_NOMAIL:
                if (ts == SUB_NONE) {
                        ts = SUB_NOMAIL;
                        subtypename = "-nomail";
                }
-               __attribute__ ((fallthrough));
+               /* fallthrough */
        /* listname+unsubconf-COOKIE@domain.tld */
        case CTRL_CONFUNSUB:
                if (ts == SUB_NONE) {