]> git.ipfire.org Git - thirdparty/gnutls.git/commitdiff
pre_shared_key: limit 0-RTT to resumption connections
authorDaiki Ueno <ueno@gnu.org>
Mon, 17 May 2021 05:58:43 +0000 (07:58 +0200)
committerDaiki Ueno <ueno@gnu.org>
Mon, 17 May 2021 13:36:05 +0000 (15:36 +0200)
While RFC 8446 allows 0-RTT data in a non-resumption connection
established with external PSK, it requires a mechanism to associate
encryption parameters with PSK.  Until we provide a new API for that,
let's limit the 0-RTT use to resumption connections only.

Signed-off-by: Daiki Ueno <ueno@gnu.org>
.gitignore
lib/ext/early_data.c
lib/ext/pre_shared_key.c
tests/Makefile.am
tests/tls13-early-data-neg2.c [new file with mode: 0644]

index b524bdad41f820e164c48a0c8b7ba59fe9f1f6c6..4ac9ed7d2f93bc05aa2907d6cee461fe0d656926 100644 (file)
@@ -854,6 +854,7 @@ tests/tls13-cipher-neg
 tests/tls13-compat-mode
 tests/tls13-early-data
 tests/tls13-early-data-neg
+tests/tls13-early-data-neg2
 tests/tls13-early-start
 tests/tls13-rehandshake-cert
 tests/tls13-resume-psk
index 86cccd8976f81ea88127b720ad4beee41e9a9361..28c3182a80611edd822f9067b5c7d28ef48e1b7f 100644 (file)
@@ -60,13 +60,9 @@ early_data_recv_params(gnutls_session_t session,
                return gnutls_assert_val(0);
 
        if (session->security_parameters.entity == GNUTLS_SERVER) {
-               /* The flag may be cleared by pre_shared_key
-                * extension, when replay is detected. */
-               if ((session->internals.flags & GNUTLS_ENABLE_EARLY_DATA) &&
-                   /* Refuse early data when this is a second CH after HRR */
-                   !(session->internals.hsk_flags & HSK_HRR_SENT))
-                       session->internals.hsk_flags |= HSK_EARLY_DATA_ACCEPTED;
-
+               /* Whether to accept early data is decided during processing the
+                * pre_shared_key extension in the later phase.
+                */
                session->internals.hsk_flags |= HSK_EARLY_DATA_IN_FLIGHT;
        } else {
                if (_gnutls_ext_get_msg(session) == GNUTLS_EXT_FLAG_EE)
index 380bf39ed552fc0f825dc6b373d4b002393e78b3..1b49a0305416b53384e31ae718059d88045bb64d 100644 (file)
@@ -562,6 +562,7 @@ static int server_recv_params(gnutls_session_t session,
        uint32_t ticket_age = UINT32_MAX;
        struct timespec ticket_creation_time = { 0, 0 };
        bool resuming;
+       bool refuse_early_data = false;
 
        ret = _gnutls13_psk_ext_parser_init(&psk_parser, data, len);
        if (ret < 0) {
@@ -686,22 +687,28 @@ static int server_recv_params(gnutls_session_t session,
 
                _gnutls_copy_psk_username(info, &psk.identity);
                _gnutls_handshake_log("EXT[%p]: selected PSK identity: %s (%d)\n", session, info->username, psk_index);
+
+               /* We currently only support early data in resuming connection,
+                * due to lack of API function to associate encryption
+                * parameters with external PSK.
+                */
+               refuse_early_data = true;
        } else {
-               if (session->internals.hsk_flags & HSK_EARLY_DATA_ACCEPTED) {
+               if (session->internals.hsk_flags & HSK_EARLY_DATA_IN_FLIGHT) {
                        if (session->internals.anti_replay) {
                                ret = _gnutls_anti_replay_check(session->internals.anti_replay,
                                                                ticket_age,
                                                                &ticket_creation_time,
                                                                &binder_recvd);
                                if (ret < 0) {
-                                       session->internals.hsk_flags &= ~HSK_EARLY_DATA_ACCEPTED;
+                                       refuse_early_data = true;
                                        _gnutls_handshake_log("EXT[%p]: replay detected; rejecting early data\n",
                                                      session);
                                }
                        } else {
+                               refuse_early_data = true;
                                _gnutls_handshake_log("EXT[%p]: anti-replay is not enabled; rejecting early data\n",
                                                      session);
-                               session->internals.hsk_flags &= ~HSK_EARLY_DATA_ACCEPTED;
                        }
                }
 
@@ -711,6 +718,15 @@ static int server_recv_params(gnutls_session_t session,
 
        session->internals.hsk_flags |= HSK_PSK_SELECTED;
 
+       if ((session->internals.flags & GNUTLS_ENABLE_EARLY_DATA) &&
+           (session->internals.hsk_flags & HSK_EARLY_DATA_IN_FLIGHT) &&
+           !refuse_early_data &&
+           !(session->internals.hsk_flags & HSK_HRR_SENT)) {
+               session->internals.hsk_flags |= HSK_EARLY_DATA_ACCEPTED;
+               _gnutls_handshake_log("EXT[%p]: early data accepted\n",
+                                     session);
+       }
+
        /* Reference the selected pre-shared key */
        session->key.binders[0].psk.data = key.data;
        session->key.binders[0].psk.size = key.size;
index c49fb0b4bda9d0768677c047ccfaeacc6b4b2caf..451834a41744c070246640eea5cda9c242116bef 100644 (file)
@@ -428,7 +428,8 @@ endif
 if HAVE_FORK
 ctests += x509self x509dn anonself pskself pskself2 dhepskself \
        setcredcrash tls12-resume-x509 tls12-resume-psk tls12-resume-anon \
-       tls13-resume-x509 tls13-resume-psk tls13-early-data tls13-early-data-neg \
+       tls13-resume-x509 tls13-resume-psk tls13-early-data \
+       tls13-early-data-neg tls13-early-data-neg2 \
        resume-with-record-size-limit
 endif
 
diff --git a/tests/tls13-early-data-neg2.c b/tests/tls13-early-data-neg2.c
new file mode 100644 (file)
index 0000000..37b6c3e
--- /dev/null
@@ -0,0 +1,378 @@
+/*
+ * Copyright (C) 2012-2018 Free Software Foundation, Inc.
+ *
+ * Author: Nikos Mavrogiannopoulos, Daiki Ueno
+ *
+ * This file is part of GnuTLS.
+ *
+ * GnuTLS is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * GnuTLS is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>
+ */
+
+#ifdef HAVE_CONFIG_H
+#include <config.h>
+#endif
+
+#include <stdio.h>
+#include <stdlib.h>
+
+#if defined(_WIN32)
+
+int main(void)
+{
+       exit(77);
+}
+
+#else
+
+#include <string.h>
+#include <sys/types.h>
+#include <netinet/in.h>
+#include <sys/socket.h>
+#include <sys/wait.h>
+#include <arpa/inet.h>
+#include <unistd.h>
+#include <gnutls/gnutls.h>
+#include <gnutls/crypto.h>
+#include <gnutls/dtls.h>
+#include <signal.h>
+#include <sys/wait.h>
+#include <assert.h>
+
+#include "cert-common.h"
+#include "utils.h"
+#include "virt-time.h"
+
+/* This program checks that early data is refused upon resumption failure.
+ */
+
+static void server_log_func(int level, const char *str)
+{
+       fprintf(stderr, "server|<%d>| %s", level, str);
+}
+
+static void client_log_func(int level, const char *str)
+{
+       fprintf(stderr, "client|<%d>| %s", level, str);
+}
+
+
+#define SESSIONS 2
+#define MAX_BUF 1024
+#define MSG "Hello TLS"
+#define EARLY_MSG "Hello TLS, it's early"
+#define PRIORITY "NORMAL:-VERS-ALL:+VERS-TLS1.3"
+
+static void client(int sds[])
+{
+       int ret;
+       char buffer[MAX_BUF + 1];
+       gnutls_certificate_credentials_t x509_cred;
+       gnutls_session_t session;
+       int t;
+       gnutls_datum_t session_data = {NULL, 0};
+
+       if (debug) {
+               gnutls_global_set_log_function(client_log_func);
+               gnutls_global_set_log_level(7);
+       }
+
+       /* Generate the same ob_ticket_age value, which affects the
+        * binder calculation.
+        */
+       virt_time_init();
+
+       gnutls_certificate_allocate_credentials(&x509_cred);
+
+       for (t = 0; t < SESSIONS; t++) {
+               int sd = sds[t];
+
+               assert(gnutls_init(&session, GNUTLS_CLIENT)>=0);
+               assert(gnutls_priority_set_direct(session, PRIORITY, NULL)>=0);
+
+               gnutls_credentials_set(session, GNUTLS_CRD_CERTIFICATE, x509_cred);
+
+               gnutls_transport_set_int(session, sd);
+
+               if (t > 0) {
+                       assert(gnutls_session_set_data(session, session_data.data, session_data.size) >= 0);
+                       assert(gnutls_record_send_early_data(session, EARLY_MSG, sizeof(EARLY_MSG)) >= 0);
+               }
+
+               /* Perform the TLS handshake
+                */
+               gnutls_handshake_set_timeout(session, get_timeout());
+               do {
+                       ret = gnutls_handshake(session);
+               }
+               while (ret < 0 && gnutls_error_is_fatal(ret) == 0);
+
+               if (ret < 0) {
+                       fail("client: Handshake failed: %s\n",
+                            gnutls_strerror(ret));
+               } else {
+                       if (debug)
+                               success("client: Handshake was completed\n");
+               }
+
+               if (t == 0) {
+                       /* get the session data size */
+                       ret =
+                           gnutls_session_get_data2(session,
+                                                    &session_data);
+                       if (ret < 0)
+                               fail("client: Getting resume data failed\n");
+               }
+
+               if (gnutls_session_is_resumed(session)) {
+                       fail("client: Session unexpectedly resumed (%d)\n", t);
+               }
+
+               gnutls_record_send(session, MSG, strlen(MSG));
+
+               do {
+                       ret = gnutls_record_recv(session, buffer, sizeof(buffer));
+               } while (ret == GNUTLS_E_AGAIN);
+               if (ret == 0) {
+                       if (debug)
+                               success
+                                       ("client: Peer has closed the TLS connection\n");
+                       goto end;
+               } else if (ret < 0) {
+                       fail("client: Error: %s\n", gnutls_strerror(ret));
+               }
+
+               gnutls_bye(session, GNUTLS_SHUT_WR);
+
+               close(sd);
+
+               gnutls_deinit(session);
+       }
+
+ end:
+       gnutls_free(session_data.data);
+       gnutls_certificate_free_credentials(x509_cred);
+}
+
+
+static pid_t child;
+
+#define MAX_CLIENT_HELLO_RECORDED 10
+
+struct storage_st {
+       gnutls_datum_t entries[MAX_CLIENT_HELLO_RECORDED];
+       size_t num_entries;
+};
+
+static int
+storage_add(void *ptr, time_t expires, const gnutls_datum_t *key, const gnutls_datum_t *value)
+{
+       struct storage_st *storage = ptr;
+       gnutls_datum_t *datum;
+       size_t i;
+
+       for (i = 0; i < storage->num_entries; i++) {
+               if (key->size == storage->entries[i].size &&
+                   memcmp(storage->entries[i].data, key->data, key->size) == 0) {
+                       return GNUTLS_E_DB_ENTRY_EXISTS;
+               }
+       }
+
+       /* If the maximum number of ClientHello exceeded, reject early
+        * data until next time.
+        */
+       if (storage->num_entries == MAX_CLIENT_HELLO_RECORDED)
+               return GNUTLS_E_DB_ERROR;
+
+       datum = &storage->entries[storage->num_entries];
+       datum->data = gnutls_malloc(key->size);
+       if (!datum->data)
+               return GNUTLS_E_MEMORY_ERROR;
+       memcpy(datum->data, key->data, key->size);
+       datum->size = key->size;
+
+       storage->num_entries++;
+
+       return 0;
+}
+
+static void
+storage_clear(struct storage_st *storage)
+{
+       size_t i;
+
+       for (i = 0; i < storage->num_entries; i++)
+               gnutls_free(storage->entries[i].data);
+       storage->num_entries = 0;
+}
+
+static void server(int sds[])
+{
+       int ret;
+       char buffer[MAX_BUF + 1];
+       gnutls_session_t session;
+       gnutls_certificate_credentials_t x509_cred;
+       gnutls_datum_t session_ticket_key = { NULL, 0 };
+       struct storage_st storage;
+       gnutls_anti_replay_t anti_replay;
+       int t;
+
+       /* this must be called once in the program
+        */
+       global_init();
+       memset(buffer, 0, sizeof(buffer));
+       memset(&storage, 0, sizeof(storage));
+
+       if (debug) {
+               gnutls_global_set_log_function(server_log_func);
+               gnutls_global_set_log_level(4711);
+       }
+
+       gnutls_certificate_allocate_credentials(&x509_cred);
+       gnutls_certificate_set_x509_key_mem(x509_cred, &server_cert,
+                                           &server_key,
+                                           GNUTLS_X509_FMT_PEM);
+
+       ret = gnutls_anti_replay_init(&anti_replay);
+       if (ret < 0)
+               fail("server: failed to initialize anti-replay\n");
+       gnutls_anti_replay_set_add_function(anti_replay, storage_add);
+       gnutls_anti_replay_set_ptr(anti_replay, &storage);
+
+       for (t = 0; t < SESSIONS; t++) {
+               int sd = sds[t];
+
+               success("=== session %d ===\n", t);
+
+               assert(gnutls_init(&session, GNUTLS_SERVER|GNUTLS_ENABLE_EARLY_DATA)>=0);
+
+               assert(gnutls_priority_set_direct(session, PRIORITY, NULL)>=0);
+
+               gnutls_credentials_set(session, GNUTLS_CRD_CERTIFICATE, x509_cred);
+
+               /* Intentionally overwrite the previous key to cause resumption
+                * failure. */
+               gnutls_session_ticket_key_generate(&session_ticket_key);
+
+               gnutls_session_ticket_enable_server(session,
+                                                   &session_ticket_key);
+
+               gnutls_anti_replay_enable(session, anti_replay);
+
+               gnutls_transport_set_int(session, sd);
+
+               do {
+                       ret = gnutls_handshake(session);
+               } while (ret < 0 && gnutls_error_is_fatal(ret) == 0);
+
+               if (ret < 0) {
+                       gnutls_deinit(session);
+                       fail("server[%d]: Handshake has failed (%s)\n\n",
+                            t, gnutls_strerror(ret));
+               }
+               if (debug)
+                       success("server: Handshake was completed\n");
+
+               if (gnutls_session_is_resumed(session)) {
+                       fail("server: Session unexpectedly resumed (%d)\n", t);
+               }
+
+               if (gnutls_session_get_flags(session) & GNUTLS_SFLAGS_EARLY_DATA) {
+                       fail("server: Unexpected early data received (%d)\n", t);
+               }
+
+               for (;;) {
+                       memset(buffer, 0, MAX_BUF + 1);
+                       ret = gnutls_record_recv(session, buffer, MAX_BUF);
+
+                       if (ret == 0) {
+                               if (debug)
+                                       success
+                                           ("server: Peer has closed the GnuTLS connection\n");
+                               break;
+                       } else if (ret < 0) {
+                               kill(child, SIGTERM);
+                               fail("server: Received corrupted data(%d). Closing...\n", ret);
+                       } else if (ret > 0) {
+                               /* echo data back to the client
+                                */
+                               gnutls_record_send(session, buffer,
+                                                  strlen(buffer));
+                       }
+               }
+               /* do not wait for the peer to close the connection.
+                */
+               gnutls_bye(session, GNUTLS_SHUT_WR);
+
+               close(sd);
+
+               gnutls_deinit(session);
+
+               gnutls_free(session_ticket_key.data);
+       }
+
+       gnutls_anti_replay_deinit(anti_replay);
+
+       storage_clear(&storage);
+
+       gnutls_certificate_free_credentials(x509_cred);
+
+       if (debug)
+               success("server: finished\n");
+}
+
+void doit(void)
+{
+       int client_sds[SESSIONS], server_sds[SESSIONS];
+       int i, status = 0;
+       int ret;
+
+       signal(SIGCHLD, SIG_IGN);
+       signal(SIGPIPE, SIG_IGN);
+
+       for (i = 0; i < SESSIONS; i++) {
+               int sockets[2];
+
+               ret = socketpair(AF_UNIX, SOCK_STREAM, 0, sockets);
+               if (ret < 0) {
+                       perror("socketpair");
+                       exit(1);
+               }
+
+               server_sds[i] = sockets[0];
+               client_sds[i] = sockets[1];
+       }
+
+       child = fork();
+       if (child < 0) {
+               perror("fork");
+               fail("fork");
+               exit(1);
+       }
+
+       if (child) {
+               /* parent */
+               for (i = 0; i < SESSIONS; i++)
+                       close(client_sds[i]);
+               server(server_sds);
+               wait(&status);
+               check_wait_status(status);
+       } else {
+               for (i = 0; i < SESSIONS; i++)
+                       close(server_sds[i]);
+               client(client_sds);
+               exit(0);
+       }
+}
+
+#endif                         /* _WIN32 */