Only call memmove if the rdata length is non zero

This avoids undefined behaviour on zero length rdata where the
data pointer is NULL.

(cherry picked from commit 228cc557fe4ca29e34eccb3a1846d7f754879aed)

diff --git a/lib/dns/rdataslab.c b/lib/dns/rdataslab.c
index 2783c1cbefca11279266e5f6b36dc36f12251424..14c43818b8055acc45ca87e402baef9a3018e7a3 100644 (file)
--- a/lib/dns/rdataslab.c
+++ b/lib/dns/rdataslab.c
@@ -320,7 +320,9 @@ dns_rdataslab_fromrdataset(dns_rdataset_t *rdataset, isc_mem_t *mctx,
                                            ? DNS_RDATASLAB_OFFLINE
                                            : 0;
                }
-               memmove(rawbuf, x[i].rdata.data, x[i].rdata.length);
+               if (x[i].rdata.length != 0) {
+                       memmove(rawbuf, x[i].rdata.data, x[i].rdata.length);
+               }
                rawbuf += x[i].rdata.length;
        }