Avoid unsafe access to negative index in a TupleDesc.

Commit aa606b931 installed a test that would reference a nonexistent
TupleDesc array entry if a system column is used in COPY FROM WHERE.
Typically this would be harmless, but with bad luck it could result
in a phony "generated columns are not supported in COPY FROM WHERE
conditions" error, and at least in principle it could cause SIGSEGV.
(Compare 570e2fcc0 which fixed the identical problem in another
place.)  Also, since c98ad086a it throws an Assert instead.

In the back branches, just guard the test to make it a safe no-op for
system columns.  Commit 21c69dc73 installed a more aggressive answer
in master.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/6f435023-8ab6-47c2-ba07-035d0c4212f9@gmail.com
Backpatch-through: 14-18

diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c
index b957468828e469d7cfe83bbc05558d0905d00d87..a469825bdce57e5f6136274419ce81ef65cef918 100644 (file)
--- a/src/backend/commands/copy.c
+++ b/src/backend/commands/copy.c
@@ -176,7 +176,8 @@ DoCopy(ParseState *pstate, const CopyStmt *stmt,
                                 * generated columns are not yet computed when the filtering
                                 * happens.
                                 */
-                               if (TupleDescAttr(RelationGetDescr(rel), attno - 1)->attgenerated)
+                               if (attno > 0 &&
+                                       TupleDescAttr(RelationGetDescr(rel), attno - 1)->attgenerated)
                                        ereport(ERROR,
                                                        errcode(ERRCODE_INVALID_COLUMN_REFERENCE),
                                                        errmsg("generated columns are not supported in COPY FROM WHERE conditions"),