]> git.ipfire.org Git - pbs.git/commitdiff
Shortcut formatting empty commit messages
authorMichael Tremer <michael.tremer@ipfire.org>
Fri, 27 Oct 2017 10:42:25 +0000 (11:42 +0100)
committerMichael Tremer <michael.tremer@ipfire.org>
Fri, 27 Oct 2017 10:42:25 +0000 (11:42 +0100)
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
src/buildservice/sources.py
src/web/ui_modules.py

index c07d534ffa632a37975ee918ad212a7046c7169f..39ed7202cc18d34ed2c4e58ef394a0a848ca6472 100644 (file)
@@ -213,6 +213,10 @@ class Commit(base.DataObject):
 
                        message.append(line)
 
+               # If all lines are empty lines, we send back an empty message
+               if all((l == "" for l in message)):
+                       return
+
                return "\n".join(message)
 
        @property
index 64cee89fbba81cdfb649891139b367cb662f601e..1b4f0b165462aa7845d08e14164a2cec56a66f8f 100644 (file)
@@ -34,6 +34,10 @@ class TextModule(UIModule):
                        yield paragraph.replace("\n", " ")
 
        def render(self, text, pre=False, remove_linebreaks=True):
+               # Handle empty messages
+               if not text:
+                       return ""
+
                if remove_linebreaks:
                        text = text.replace("\n", " ")