]> git.ipfire.org Git - thirdparty/postgresql.git/commitdiff
Rework signal handler infrastructure to pass sender info as argument.
authorAndrew Dunstan <andrew@dunslane.net>
Tue, 14 Apr 2026 20:13:08 +0000 (16:13 -0400)
committerAndrew Dunstan <andrew@dunslane.net>
Wed, 15 Apr 2026 11:30:34 +0000 (07:30 -0400)
Commit 095c9d4cf06 added errdetail() reporting of the PID and UID of
the process that sent a termination signal.  However, as noted by
Andres Freund, the implementation had architectural problems:

1. wrapper_handler() in pqsignal.c contained SIGTERM-specific logic
   (setting ProcDieSenderPid/Uid), violating its role as a generic
   signal dispatch wrapper.

2. Using globals to pass sender info between wrapper_handler and the
   real handler is unsafe when signals nest on some platforms.

3. The syncrep.c errdetail used psprintf() to conditionally embed
   text via %s, breaking translatability.

Adopt the approach proposed by Andres Freund: introduce a
pg_signal_info struct that is passed as an argument to all signal
handlers via the SIGNAL_ARGS macro.  wrapper_handler populates it
from siginfo_t when SA_SIGINFO is available, or with zeros otherwise.
This keeps wrapper_handler fully generic and avoids any globals for
passing signal metadata.

Since pqsigfunc now has a different signature from the system's
signal handler type, SIG_IGN and SIG_DFL can no longer be passed
directly to pqsignal().  Introduce PG_SIG_IGN and PG_SIG_DFL macros
that cast to the new pqsigfunc type, and update all call sites.
The legacy pqsignal() in libpq retains its original signature via
a local typedef.

Only die() reads pg_siginfo today, copying the sender PID/UID into
ProcDieSenderPid/Uid for later use by ProcessInterrupts().  Only the
first SIGTERM's sender info is recorded.

Also fix the syncrep.c translatability issue by using separate ereport
calls with complete, independently translatable errdetail strings.

Also make the psql TAP test require the DETAIL line on platforms with
SA_SIGINFO, rather than making it unconditionally optional.

On Windows, pg_signal_info uses uint32_t for pid and uid fields
since pid_t/uid_t are not available early enough in the include
chain.  The Windows signal dispatch in pgwin32_dispatch_queued_signals()
passes a zeroed pg_signal_info to handlers.

Author: Andres Freund <andres@anarazel.de>
Author: Jakub Wartak <jakub.wartak@enterprisedb.com>
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/cwyyryh2veejuxbj5ifzyaejw7jhhqc5mrdeq56xckknsdecn2@6hzfcxde2nm5
Discussion: https://postgr.es/m/jygesyr7mwg7ovdbxpmjvvbi3hccptpkcreqb645h7f56puwbz@hmkkwi3melfe

32 files changed:
src/backend/bootstrap/bootstrap.c
src/backend/port/win32/signal.c
src/backend/postmaster/autovacuum.c
src/backend/postmaster/bgworker.c
src/backend/postmaster/bgwriter.c
src/backend/postmaster/checkpointer.c
src/backend/postmaster/datachecksum_state.c
src/backend/postmaster/pgarch.c
src/backend/postmaster/postmaster.c
src/backend/postmaster/startup.c
src/backend/postmaster/syslogger.c
src/backend/postmaster/walsummarizer.c
src/backend/postmaster/walwriter.c
src/backend/replication/logical/slotsync.c
src/backend/replication/syncrep.c
src/backend/replication/walreceiver.c
src/backend/replication/walsender.c
src/backend/storage/aio/method_worker.c
src/backend/storage/file/fd.c
src/backend/storage/ipc/waiteventset.c
src/backend/tcop/postgres.c
src/bin/initdb/initdb.c
src/bin/pg_ctl/pg_ctl.c
src/bin/pg_dump/parallel.c
src/bin/psql/t/001_basic.pl
src/fe_utils/print.c
src/include/c.h
src/include/port.h
src/interfaces/libpq/legacy-pqsignal.c
src/port/pqsignal.c
src/test/regress/pg_regress.c
src/tools/pgindent/typedefs.list

index a4af7bf8fad0b107cd935d787f3f97588fd1bd41..b0dcd9876c56fd89aabda8bfc02f7854e356e925 100644 (file)
@@ -463,10 +463,10 @@ bootstrap_signals(void)
         * mode; "curl up and die" is a sufficient response for all these cases.
         * Let's set that handling explicitly, as documentation if nothing else.
         */
-       pqsignal(SIGHUP, SIG_DFL);
-       pqsignal(SIGINT, SIG_DFL);
-       pqsignal(SIGTERM, SIG_DFL);
-       pqsignal(SIGQUIT, SIG_DFL);
+       pqsignal(SIGHUP, PG_SIG_DFL);
+       pqsignal(SIGINT, PG_SIG_DFL);
+       pqsignal(SIGTERM, PG_SIG_DFL);
+       pqsignal(SIGQUIT, PG_SIG_DFL);
 }
 
 /* ----------------------------------------------------------------
index 465d69a1f289faad43c4ffd74b89ae595ca1b01c..f002542803739a90bf101a5c4ac3b340643a820c 100644 (file)
@@ -88,7 +88,7 @@ pgwin32_signal_initialize(void)
                pg_signal_array[i].sa_handler = SIG_DFL;
                pg_signal_array[i].sa_mask = 0;
                pg_signal_array[i].sa_flags = 0;
-               pg_signal_defaults[i] = SIG_IGN;
+               pg_signal_defaults[i] = PG_SIG_IGN;
        }
        pg_signal_mask = 0;
        pg_signal_queue = 0;
@@ -134,15 +134,19 @@ pgwin32_dispatch_queued_signals(void)
                        {
                                /* Execute this signal */
                                struct sigaction *act = &pg_signal_array[i];
-                               pqsigfunc       sig = act->sa_handler;
+                               pqsigfunc       sig = (pqsigfunc) (pg_funcptr_t) act->sa_handler;
 
-                               if (sig == SIG_DFL)
+                               if (sig == PG_SIG_DFL)
                                        sig = pg_signal_defaults[i];
                                pg_signal_queue &= ~sigmask(i);
-                               if (sig != SIG_ERR && sig != SIG_IGN && sig != SIG_DFL)
+                               if (sig != (pqsigfunc) (pg_funcptr_t) SIG_ERR && sig != PG_SIG_IGN && sig != PG_SIG_DFL)
                                {
                                        sigset_t        block_mask;
                                        sigset_t        save_mask;
+                                       struct pg_signal_info nodata;
+
+                                       nodata.pid = 0;
+                                       nodata.uid = 0;
 
                                        LeaveCriticalSection(&pg_signal_crit_sec);
 
@@ -151,7 +155,7 @@ pgwin32_dispatch_queued_signals(void)
                                                block_mask |= sigmask(i);
 
                                        sigprocmask(SIG_BLOCK, &block_mask, &save_mask);
-                                       sig(i);
+                                       sig(i, &nodata);
                                        sigprocmask(SIG_SETMASK, &save_mask, NULL);
 
                                        EnterCriticalSection(&pg_signal_crit_sec);
index 82061247988110aa8fbf75cdd1aaf9c74e04dd69..680db664be4ca256451d1253b3a5005d97e5708a 100644 (file)
@@ -445,11 +445,11 @@ AutoVacLauncherMain(const void *startup_data, size_t startup_data_len)
 
        InitializeTimeouts();           /* establishes SIGALRM handler */
 
-       pqsignal(SIGPIPE, SIG_IGN);
+       pqsignal(SIGPIPE, PG_SIG_IGN);
        pqsignal(SIGUSR1, procsignal_sigusr1_handler);
        pqsignal(SIGUSR2, avl_sigusr2_handler);
        pqsignal(SIGFPE, FloatExceptionHandler);
-       pqsignal(SIGCHLD, SIG_DFL);
+       pqsignal(SIGCHLD, PG_SIG_DFL);
 
        /*
         * Create a per-backend PGPROC struct in shared memory.  We must do this
@@ -1456,11 +1456,11 @@ AutoVacWorkerMain(const void *startup_data, size_t startup_data_len)
 
        InitializeTimeouts();           /* establishes SIGALRM handler */
 
-       pqsignal(SIGPIPE, SIG_IGN);
+       pqsignal(SIGPIPE, PG_SIG_IGN);
        pqsignal(SIGUSR1, procsignal_sigusr1_handler);
-       pqsignal(SIGUSR2, SIG_IGN);
+       pqsignal(SIGUSR2, PG_SIG_IGN);
        pqsignal(SIGFPE, FloatExceptionHandler);
-       pqsignal(SIGCHLD, SIG_DFL);
+       pqsignal(SIGCHLD, PG_SIG_DFL);
 
        /*
         * Create a per-backend PGPROC struct in shared memory.  We must do this
index 3914d22a51479572d0ee91b563bc8e53302f8b0e..2e4acad4f005c8e790a6363017ea7ccd834d6b4d 100644 (file)
@@ -785,19 +785,19 @@ BackgroundWorkerMain(const void *startup_data, size_t startup_data_len)
        }
        else
        {
-               pqsignal(SIGINT, SIG_IGN);
-               pqsignal(SIGUSR1, SIG_IGN);
-               pqsignal(SIGFPE, SIG_IGN);
+               pqsignal(SIGINT, PG_SIG_IGN);
+               pqsignal(SIGUSR1, PG_SIG_IGN);
+               pqsignal(SIGFPE, PG_SIG_IGN);
        }
        pqsignal(SIGTERM, die);
        /* SIGQUIT handler was already set up by InitPostmasterChild */
-       pqsignal(SIGHUP, SIG_IGN);
+       pqsignal(SIGHUP, PG_SIG_IGN);
 
        InitializeTimeouts();           /* establishes SIGALRM handler */
 
-       pqsignal(SIGPIPE, SIG_IGN);
-       pqsignal(SIGUSR2, SIG_IGN);
-       pqsignal(SIGCHLD, SIG_DFL);
+       pqsignal(SIGPIPE, PG_SIG_IGN);
+       pqsignal(SIGUSR2, PG_SIG_IGN);
+       pqsignal(SIGCHLD, PG_SIG_DFL);
 
        /*
         * If an exception is encountered, processing resumes here.
index a30de4262ebda5364a4cb1db568b17a2b13fc769..cd1bf9d919c1e15ccafb847c418e98513a1664b2 100644 (file)
@@ -101,18 +101,18 @@ BackgroundWriterMain(const void *startup_data, size_t startup_data_len)
         * Properly accept or ignore signals that might be sent to us.
         */
        pqsignal(SIGHUP, SignalHandlerForConfigReload);
-       pqsignal(SIGINT, SIG_IGN);
+       pqsignal(SIGINT, PG_SIG_IGN);
        pqsignal(SIGTERM, SignalHandlerForShutdownRequest);
        /* SIGQUIT handler was already set up by InitPostmasterChild */
-       pqsignal(SIGALRM, SIG_IGN);
-       pqsignal(SIGPIPE, SIG_IGN);
+       pqsignal(SIGALRM, PG_SIG_IGN);
+       pqsignal(SIGPIPE, PG_SIG_IGN);
        pqsignal(SIGUSR1, procsignal_sigusr1_handler);
-       pqsignal(SIGUSR2, SIG_IGN);
+       pqsignal(SIGUSR2, PG_SIG_IGN);
 
        /*
         * Reset some signals that are accepted by postmaster but not here
         */
-       pqsignal(SIGCHLD, SIG_DFL);
+       pqsignal(SIGCHLD, PG_SIG_DFL);
 
        /*
         * We just started, assume there has been either a shutdown or
index 6b424ee610fe456ab2460f11677a9513501b3375..087120db0909d6ccaf7733e9a3ce104c794de7ad 100644 (file)
@@ -223,17 +223,17 @@ CheckpointerMain(const void *startup_data, size_t startup_data_len)
         */
        pqsignal(SIGHUP, SignalHandlerForConfigReload);
        pqsignal(SIGINT, ReqShutdownXLOG);
-       pqsignal(SIGTERM, SIG_IGN); /* ignore SIGTERM */
+       pqsignal(SIGTERM, PG_SIG_IGN);  /* ignore SIGTERM */
        /* SIGQUIT handler was already set up by InitPostmasterChild */
-       pqsignal(SIGALRM, SIG_IGN);
-       pqsignal(SIGPIPE, SIG_IGN);
+       pqsignal(SIGALRM, PG_SIG_IGN);
+       pqsignal(SIGPIPE, PG_SIG_IGN);
        pqsignal(SIGUSR1, procsignal_sigusr1_handler);
        pqsignal(SIGUSR2, SignalHandlerForShutdownRequest);
 
        /*
         * Reset some signals that are accepted by postmaster but not here
         */
-       pqsignal(SIGCHLD, SIG_DFL);
+       pqsignal(SIGCHLD, PG_SIG_DFL);
 
        /*
         * Initialize so that first time-driven event happens at the correct time.
index 1243949eacbfd9b47fe76ebf982a233cf5728f05..18797a8ee3d90a9948dc70a66e186e39d9e6f7ae 100644 (file)
@@ -1020,7 +1020,7 @@ DataChecksumsWorkerLauncherMain(Datum arg)
        pqsignal(SIGTERM, die);
        pqsignal(SIGINT, launcher_cancel_handler);
        pqsignal(SIGUSR1, procsignal_sigusr1_handler);
-       pqsignal(SIGUSR2, SIG_IGN);
+       pqsignal(SIGUSR2, PG_SIG_IGN);
 
        BackgroundWorkerUnblockSignals();
 
index 0a1a1149d78cdf264d50585a68f69682d56bcb39..0f207ac0356749e183ce55041f8f765877bd5eb0 100644 (file)
@@ -229,16 +229,16 @@ PgArchiverMain(const void *startup_data, size_t startup_data_len)
         * except for SIGHUP, SIGTERM, SIGUSR1, SIGUSR2, and SIGQUIT.
         */
        pqsignal(SIGHUP, SignalHandlerForConfigReload);
-       pqsignal(SIGINT, SIG_IGN);
+       pqsignal(SIGINT, PG_SIG_IGN);
        pqsignal(SIGTERM, SignalHandlerForShutdownRequest);
        /* SIGQUIT handler was already set up by InitPostmasterChild */
-       pqsignal(SIGALRM, SIG_IGN);
-       pqsignal(SIGPIPE, SIG_IGN);
+       pqsignal(SIGALRM, PG_SIG_IGN);
+       pqsignal(SIGPIPE, PG_SIG_IGN);
        pqsignal(SIGUSR1, procsignal_sigusr1_handler);
        pqsignal(SIGUSR2, pgarch_waken_stop);
 
        /* Reset some signals that are accepted by postmaster but not here */
-       pqsignal(SIGCHLD, SIG_DFL);
+       pqsignal(SIGCHLD, PG_SIG_DFL);
 
        /* Unblock signals (they were blocked when the postmaster forked us) */
        sigprocmask(SIG_SETMASK, &UnBlockSig, NULL);
index 6e0f41d2661e0da83ace98cfec7a821dbc2e1f39..b6fd332f1964bfa2a1829a4db60963164e5c5e57 100644 (file)
@@ -555,8 +555,8 @@ PostmasterMain(int argc, char *argv[])
        pqsignal(SIGINT, handle_pm_shutdown_request_signal);
        pqsignal(SIGQUIT, handle_pm_shutdown_request_signal);
        pqsignal(SIGTERM, handle_pm_shutdown_request_signal);
-       pqsignal(SIGALRM, SIG_IGN); /* ignored */
-       pqsignal(SIGPIPE, SIG_IGN); /* ignored */
+       pqsignal(SIGALRM, PG_SIG_IGN);  /* ignored */
+       pqsignal(SIGPIPE, PG_SIG_IGN);  /* ignored */
        pqsignal(SIGUSR1, handle_pm_pmsignal_signal);
        pqsignal(SIGUSR2, dummy_handler);       /* unused, reserve for children */
        pqsignal(SIGCHLD, handle_pm_child_exit_signal);
@@ -573,15 +573,15 @@ PostmasterMain(int argc, char *argv[])
         * child processes should just allow the inherited settings to stand.
         */
 #ifdef SIGTTIN
-       pqsignal(SIGTTIN, SIG_IGN); /* ignored */
+       pqsignal(SIGTTIN, PG_SIG_IGN);  /* ignored */
 #endif
 #ifdef SIGTTOU
-       pqsignal(SIGTTOU, SIG_IGN); /* ignored */
+       pqsignal(SIGTTOU, PG_SIG_IGN);  /* ignored */
 #endif
 
        /* ignore SIGXFSZ, so that ulimit violations work like disk full */
 #ifdef SIGXFSZ
-       pqsignal(SIGXFSZ, SIG_IGN); /* ignored */
+       pqsignal(SIGXFSZ, PG_SIG_IGN);  /* ignored */
 #endif
 
        /* Begin accepting signals. */
@@ -3967,7 +3967,7 @@ process_pm_pmsignal(void)
  * Dummy signal handler
  *
  * We use this for signals that we don't actually use in the postmaster,
- * but we do use in backends.  If we were to SIG_IGN such signals in the
+ * but we do use in backends.  If we were to PG_SIG_IGN such signals in the
  * postmaster, then a newly started backend might drop a signal that arrives
  * before it's able to reconfigure its signal processing.  (See notes in
  * tcop/postgres.c.)
index cdbe53dd262e9e5e7e2dfc101c051b1addd8c7f9..b46bac681fef57d2e2c2e11e72711c3832dedf0a 100644 (file)
@@ -226,18 +226,18 @@ StartupProcessMain(const void *startup_data, size_t startup_data_len)
         * Properly accept or ignore signals the postmaster might send us.
         */
        pqsignal(SIGHUP, StartupProcSigHupHandler); /* reload config file */
-       pqsignal(SIGINT, SIG_IGN);      /* ignore query cancel */
+       pqsignal(SIGINT, PG_SIG_IGN);   /* ignore query cancel */
        pqsignal(SIGTERM, StartupProcShutdownHandler);  /* request shutdown */
        /* SIGQUIT handler was already set up by InitPostmasterChild */
        InitializeTimeouts();           /* establishes SIGALRM handler */
-       pqsignal(SIGPIPE, SIG_IGN);
+       pqsignal(SIGPIPE, PG_SIG_IGN);
        pqsignal(SIGUSR1, procsignal_sigusr1_handler);
        pqsignal(SIGUSR2, StartupProcTriggerHandler);
 
        /*
         * Reset some signals that are accepted by postmaster but not here
         */
-       pqsignal(SIGCHLD, SIG_DFL);
+       pqsignal(SIGCHLD, PG_SIG_DFL);
 
        /*
         * Register timeouts needed for standby mode
index 0c2a7bc8578075a18fc91ad29bc8cc14632ea534..acfe0a01715e642d5b3b06aed3d5068840618bc9 100644 (file)
@@ -276,18 +276,18 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len)
 
        pqsignal(SIGHUP, SignalHandlerForConfigReload); /* set flag to read config
                                                                                                         * file */
-       pqsignal(SIGINT, SIG_IGN);
-       pqsignal(SIGTERM, SIG_IGN);
-       pqsignal(SIGQUIT, SIG_IGN);
-       pqsignal(SIGALRM, SIG_IGN);
-       pqsignal(SIGPIPE, SIG_IGN);
+       pqsignal(SIGINT, PG_SIG_IGN);
+       pqsignal(SIGTERM, PG_SIG_IGN);
+       pqsignal(SIGQUIT, PG_SIG_IGN);
+       pqsignal(SIGALRM, PG_SIG_IGN);
+       pqsignal(SIGPIPE, PG_SIG_IGN);
        pqsignal(SIGUSR1, sigUsr1Handler);      /* request log rotation */
-       pqsignal(SIGUSR2, SIG_IGN);
+       pqsignal(SIGUSR2, PG_SIG_IGN);
 
        /*
         * Reset some signals that are accepted by postmaster but not here
         */
-       pqsignal(SIGCHLD, SIG_DFL);
+       pqsignal(SIGCHLD, PG_SIG_DFL);
 
        sigprocmask(SIG_SETMASK, &UnBlockSig, NULL);
 
index 20960f5b633f48836ec44efaba94effacd116ac9..4f12eaf2c8527f400dc6913904686eaf5db2a8af 100644 (file)
@@ -244,13 +244,13 @@ WalSummarizerMain(const void *startup_data, size_t startup_data_len)
         * Properly accept or ignore signals the postmaster might send us
         */
        pqsignal(SIGHUP, SignalHandlerForConfigReload);
-       pqsignal(SIGINT, SIG_IGN);      /* no query to cancel */
+       pqsignal(SIGINT, PG_SIG_IGN);   /* no query to cancel */
        pqsignal(SIGTERM, SignalHandlerForShutdownRequest);
        /* SIGQUIT handler was already set up by InitPostmasterChild */
-       pqsignal(SIGALRM, SIG_IGN);
-       pqsignal(SIGPIPE, SIG_IGN);
+       pqsignal(SIGALRM, PG_SIG_IGN);
+       pqsignal(SIGPIPE, PG_SIG_IGN);
        pqsignal(SIGUSR1, procsignal_sigusr1_handler);
-       pqsignal(SIGUSR2, SIG_IGN); /* not used */
+       pqsignal(SIGUSR2, PG_SIG_IGN);  /* not used */
 
        /* Advertise ourselves. */
        on_shmem_exit(WalSummarizerShutdown, (Datum) 0);
@@ -267,7 +267,7 @@ WalSummarizerMain(const void *startup_data, size_t startup_data_len)
        /*
         * Reset some signals that are accepted by postmaster but not here
         */
-       pqsignal(SIGCHLD, SIG_DFL);
+       pqsignal(SIGCHLD, PG_SIG_DFL);
 
        /*
         * If an exception is encountered, processing resumes here.
index 9cd86ad7022c9d0945ae187193db0459962cf3eb..af24d05c542f8973f77f9fb7aac7e91c04156867 100644 (file)
@@ -101,18 +101,18 @@ WalWriterMain(const void *startup_data, size_t startup_data_len)
         * Properly accept or ignore signals the postmaster might send us
         */
        pqsignal(SIGHUP, SignalHandlerForConfigReload);
-       pqsignal(SIGINT, SIG_IGN);      /* no query to cancel */
+       pqsignal(SIGINT, PG_SIG_IGN);   /* no query to cancel */
        pqsignal(SIGTERM, SignalHandlerForShutdownRequest);
        /* SIGQUIT handler was already set up by InitPostmasterChild */
-       pqsignal(SIGALRM, SIG_IGN);
-       pqsignal(SIGPIPE, SIG_IGN);
+       pqsignal(SIGALRM, PG_SIG_IGN);
+       pqsignal(SIGPIPE, PG_SIG_IGN);
        pqsignal(SIGUSR1, procsignal_sigusr1_handler);
-       pqsignal(SIGUSR2, SIG_IGN); /* not used */
+       pqsignal(SIGUSR2, PG_SIG_IGN);  /* not used */
 
        /*
         * Reset some signals that are accepted by postmaster but not here
         */
-       pqsignal(SIGCHLD, SIG_DFL);
+       pqsignal(SIGCHLD, PG_SIG_DFL);
 
        /*
         * Create a memory context that we will do all our work in.  We do this so
index d01b401cd28b47a58f56550a461a8bc79f2a48d5..ad3747e598c77a4601102da6fcacc8712a3f3767 100644 (file)
@@ -1620,9 +1620,9 @@ ReplSlotSyncWorkerMain(const void *startup_data, size_t startup_data_len)
        pqsignal(SIGTERM, die);
        pqsignal(SIGFPE, FloatExceptionHandler);
        pqsignal(SIGUSR1, procsignal_sigusr1_handler);
-       pqsignal(SIGUSR2, SIG_IGN);
-       pqsignal(SIGPIPE, SIG_IGN);
-       pqsignal(SIGCHLD, SIG_DFL);
+       pqsignal(SIGUSR2, PG_SIG_IGN);
+       pqsignal(SIGPIPE, PG_SIG_IGN);
+       pqsignal(SIGCHLD, PG_SIG_DFL);
 
        check_and_set_sync_info(MyProcPid);
 
index 46a778f091797572cc542382c6c66b709fe0d3e7..73450fe437e22257f76418c04fae345a96a69f42 100644 (file)
@@ -300,22 +300,18 @@ SyncRepWaitForLSN(XLogRecPtr lsn, bool commit)
                 */
                if (ProcDiePending)
                {
-                       /*
-                        * ProcDieSenderPid/Uid are read directly from the globals here
-                        * rather than copied to locals first; a second SIGTERM could
-                        * change them between reads, but that is harmless because the
-                        * process is about to die anyway.  The signal sender detail is
-                        * inlined rather than using a separate errdetail() call because
-                        * it must be appended to the existing detail message.
-                        */
-                       ereport(WARNING,
-                                       (errcode(ERRCODE_ADMIN_SHUTDOWN),
-                                        errmsg("canceling the wait for synchronous replication and terminating connection due to administrator command"),
-                                        errdetail("The transaction has already committed locally, but might not have been replicated to the standby.%s",
-                                                          ProcDieSenderPid == 0 ? "" :
-                                                          psprintf("\nSignal sent by PID %d, UID %d.",
-                                                                               (int) ProcDieSenderPid,
-                                                                               (int) ProcDieSenderUid))));
+                       if (ProcDieSenderPid != 0)
+                               ereport(WARNING,
+                                               (errcode(ERRCODE_ADMIN_SHUTDOWN),
+                                                errmsg("canceling the wait for synchronous replication and terminating connection due to administrator command"),
+                                                errdetail("The transaction has already committed locally, but might not have been replicated to the standby.  Signal sent by PID %d, UID %d.",
+                                                                  (int) ProcDieSenderPid,
+                                                                  (int) ProcDieSenderUid)));
+                       else
+                               ereport(WARNING,
+                                               (errcode(ERRCODE_ADMIN_SHUTDOWN),
+                                                errmsg("canceling the wait for synchronous replication and terminating connection due to administrator command"),
+                                                errdetail("The transaction has already committed locally, but might not have been replicated to the standby.")));
                        whereToSendOutput = DestNone;
                        SyncRepCancelWait();
                        break;
index 09fde92bfd747fcdbc4fabc24cdca3e07f9447f5..6da5b86dbc5f311db608b809042235be661bf98e 100644 (file)
@@ -248,16 +248,16 @@ WalReceiverMain(const void *startup_data, size_t startup_data_len)
        /* Properly accept or ignore signals the postmaster might send us */
        pqsignal(SIGHUP, SignalHandlerForConfigReload); /* set flag to read config
                                                                                                         * file */
-       pqsignal(SIGINT, SIG_IGN);
+       pqsignal(SIGINT, PG_SIG_IGN);
        pqsignal(SIGTERM, die);         /* request shutdown */
        /* SIGQUIT handler was already set up by InitPostmasterChild */
-       pqsignal(SIGALRM, SIG_IGN);
-       pqsignal(SIGPIPE, SIG_IGN);
+       pqsignal(SIGALRM, PG_SIG_IGN);
+       pqsignal(SIGPIPE, PG_SIG_IGN);
        pqsignal(SIGUSR1, procsignal_sigusr1_handler);
-       pqsignal(SIGUSR2, SIG_IGN);
+       pqsignal(SIGUSR2, PG_SIG_IGN);
 
        /* Reset some signals that are accepted by postmaster but not here */
-       pqsignal(SIGCHLD, SIG_DFL);
+       pqsignal(SIGCHLD, PG_SIG_DFL);
 
        /* Load the libpq-specific functions */
        load_file("libpqwalreceiver", false);
index bad45adb004fb9575e09ce10be7b621ced78889f..3d4ab929f91651194d791304bfdb8c69878e756f 100644 (file)
@@ -3897,13 +3897,13 @@ WalSndSignals(void)
        pqsignal(SIGTERM, die);         /* request shutdown */
        /* SIGQUIT handler was already set up by InitPostmasterChild */
        InitializeTimeouts();           /* establishes SIGALRM handler */
-       pqsignal(SIGPIPE, SIG_IGN);
+       pqsignal(SIGPIPE, PG_SIG_IGN);
        pqsignal(SIGUSR1, procsignal_sigusr1_handler);
        pqsignal(SIGUSR2, WalSndLastCycleHandler);      /* request a last cycle and
                                                                                                 * shutdown */
 
        /* Reset some signals that are accepted by postmaster but not here */
-       pqsignal(SIGCHLD, SIG_DFL);
+       pqsignal(SIGCHLD, PG_SIG_DFL);
 }
 
 /* Register shared-memory space needed by walsender */
index a5ccd506d8c05bf6f9a1494326f11cb706726d02..061a93d90d475989c9c221d50c9a9d6976012c93 100644 (file)
@@ -684,10 +684,10 @@ IoWorkerMain(const void *startup_data, size_t startup_data_len)
         * Ignore SIGTERM, will get explicit shutdown via SIGUSR2 later in the
         * shutdown sequence, similar to checkpointer.
         */
-       pqsignal(SIGTERM, SIG_IGN);
+       pqsignal(SIGTERM, PG_SIG_IGN);
        /* SIGQUIT handler was already set up by InitPostmasterChild */
-       pqsignal(SIGALRM, SIG_IGN);
-       pqsignal(SIGPIPE, SIG_IGN);
+       pqsignal(SIGALRM, PG_SIG_IGN);
+       pqsignal(SIGPIPE, PG_SIG_IGN);
        pqsignal(SIGUSR1, procsignal_sigusr1_handler);
        pqsignal(SIGUSR2, SignalHandlerForShutdownRequest);
 
index 01f1bd6e687e87cd378058ab83ce4e9f6b960a7c..a8be066afe0d69dbd7114fb7d2ab728ad6c45ddf 100644 (file)
@@ -2748,11 +2748,11 @@ OpenPipeStream(const char *command, const char *mode)
 
 TryAgain:
        fflush(NULL);
-       pqsignal(SIGPIPE, SIG_DFL);
+       pqsignal(SIGPIPE, PG_SIG_DFL);
        errno = 0;
        file = popen(command, mode);
        save_errno = errno;
-       pqsignal(SIGPIPE, SIG_IGN);
+       pqsignal(SIGPIPE, PG_SIG_IGN);
        errno = save_errno;
        if (file != NULL)
        {
index 0f228e1e7b86a35f17403d8908d4ce9ec2d7d95b..627dba0a842dcee7e52e70c87fb9752e3d979423 100644 (file)
@@ -348,7 +348,7 @@ InitializeWaitEventSupport(void)
 
 #ifdef WAIT_USE_KQUEUE
        /* Ignore SIGURG, because we'll receive it via kqueue. */
-       pqsignal(SIGURG, SIG_IGN);
+       pqsignal(SIGURG, PG_SIG_IGN);
 #endif
 }
 
index aeaf1c6db8f9ecd05c77b552004910d7c71ef9c6..2c1f14b78891a777052441fe356423c29a2ab170 100644 (file)
@@ -3027,6 +3027,17 @@ die(SIGNAL_ARGS)
        {
                InterruptPending = true;
                ProcDiePending = true;
+
+               /*
+                * Record who sent the signal.  Will be 0 on platforms without
+                * SA_SIGINFO, which is fine -- ProcessInterrupts() checks for that.
+                * Only set on the first SIGTERM so we report the original sender.
+                */
+               if (ProcDieSenderPid == 0)
+               {
+                       ProcDieSenderPid = pg_siginfo->pid;
+                       ProcDieSenderUid = pg_siginfo->uid;
+               }
        }
 
        /* for the cumulative stats system */
@@ -4316,17 +4327,17 @@ PostgresMain(const char *dbname, const char *username)
                 * returns to outer loop.  This seems safer than forcing exit in the
                 * midst of output during who-knows-what operation...
                 */
-               pqsignal(SIGPIPE, SIG_IGN);
+               pqsignal(SIGPIPE, PG_SIG_IGN);
                pqsignal(SIGUSR1, procsignal_sigusr1_handler);
-               pqsignal(SIGUSR2, SIG_IGN);
+               pqsignal(SIGUSR2, PG_SIG_IGN);
                pqsignal(SIGFPE, FloatExceptionHandler);
 
                /*
                 * Reset some signals that are accepted by postmaster but not by
                 * backend
                 */
-               pqsignal(SIGCHLD, SIG_DFL); /* system() requires this on some
-                                                                        * platforms */
+               pqsignal(SIGCHLD, PG_SIG_DFL);  /* system() requires this on some
+                                                                                * platforms */
        }
 
        /* Early initialization */
index 2ee834f07656b85511ab9db3f0a0322ce94a467f..14cb79c26be04b694d855b3803359f537e62c99e 100644 (file)
@@ -2903,10 +2903,10 @@ setup_signals(void)
        pqsignal(SIGQUIT, trapsig);
 
        /* Ignore SIGPIPE when writing to backend, so we can clean up */
-       pqsignal(SIGPIPE, SIG_IGN);
+       pqsignal(SIGPIPE, PG_SIG_IGN);
 
        /* Prevent SIGSYS so we can probe for kernel calls that might not work */
-       pqsignal(SIGSYS, SIG_IGN);
+       pqsignal(SIGSYS, PG_SIG_IGN);
 #endif
 }
 
index 3cc61455dcb08464445e3e74a6e9be13bb86390c..5539eb8ebef61b93072abb1b331d5f7196d3ac2b 100644 (file)
@@ -868,7 +868,7 @@ trap_sigint_during_startup(SIGNAL_ARGS)
         * Clear the signal handler, and send the signal again, to terminate the
         * process as normal.
         */
-       pqsignal(postgres_signal_arg, SIG_DFL);
+       pqsignal(postgres_signal_arg, PG_SIG_DFL);
        raise(postgres_signal_arg);
 }
 
index a28561fbd84e919e41b90a7ecf1920a3a1628888..a7bed5ecccf3f3efdcb2a37660f7e392336cfaf6 100644 (file)
@@ -568,9 +568,9 @@ sigTermHandler(SIGNAL_ARGS)
         * signal handler.  That could muck up our attempt to send PQcancel, so
         * disable the signals that set_cancel_handler enabled.
         */
-       pqsignal(SIGINT, SIG_IGN);
-       pqsignal(SIGTERM, SIG_IGN);
-       pqsignal(SIGQUIT, SIG_IGN);
+       pqsignal(SIGINT, PG_SIG_IGN);
+       pqsignal(SIGTERM, PG_SIG_IGN);
+       pqsignal(SIGQUIT, PG_SIG_IGN);
 
        /*
         * If we're in the leader, forward signal to all workers.  (It seems best
@@ -1049,7 +1049,7 @@ ParallelBackupStart(ArchiveHandle *AH)
         * the workers to inherit this setting, though.
         */
 #ifndef WIN32
-       pqsignal(SIGPIPE, SIG_IGN);
+       pqsignal(SIGPIPE, PG_SIG_IGN);
 #endif
 
        /*
index 7c21204c1f2f8d800a25300cbed63bc239e4fc35..9d966c7bece61fec4bbcba8e252e2920b99a5b2e 100644 (file)
@@ -142,8 +142,11 @@ my ($ret, $out, $err) = $node->psql('postgres',
 is($ret, 2, 'server crash: psql exit code');
 like($out, qr/before/, 'server crash: output before crash');
 unlike($out, qr/AFTER/, 'server crash: no output after crash');
+my $detail_re = check_pg_config("#define HAVE_SA_SIGINFO 1")
+       ? qr/DETAIL:  Signal sent by PID \d+, UID \d+\.\n/
+       : qr//;
 like( $err, qr/psql:<stdin>:2: FATAL:  terminating connection due to administrator command
-(?:DETAIL:  Signal sent by PID \d+, UID \d+\.\n)?psql:<stdin>:2: server closed the connection unexpectedly
+${detail_re}psql:<stdin>:2: server closed the connection unexpectedly
        This probably means the server terminated abnormally
        before or while processing the request.
 psql:<stdin>:2: error: connection to server was lost/,
index 12d969e8666ca8d7e0fddff31560458c1a43b549..f2dd52003c184cc8a06f43ce3a9eb11972dba48e 100644 (file)
@@ -3024,7 +3024,7 @@ void
 disable_sigpipe_trap(void)
 {
 #ifndef WIN32
-       pqsignal(SIGPIPE, SIG_IGN);
+       pqsignal(SIGPIPE, PG_SIG_IGN);
 #endif
 }
 
@@ -3047,7 +3047,7 @@ void
 restore_sigpipe_trap(void)
 {
 #ifndef WIN32
-       pqsignal(SIGPIPE, always_ignore_sigpipe ? SIG_IGN : SIG_DFL);
+       pqsignal(SIGPIPE, always_ignore_sigpipe ? PG_SIG_IGN : PG_SIG_DFL);
 #endif
 }
 
index 88d13ec9993465b2a56a3fc6c1e5398fd3e3b131..97ed8c63f5ea89d89759b9d6692fc1cf293e24ca 100644 (file)
@@ -1441,17 +1441,28 @@ extern int      fdatasync(int fd);
 #endif
 
 /*
- * The following is used as the arg list for signal handlers.  Any ports
- * that take something other than an int argument should override this in
- * their pg_config_os.h file.  Note that variable names are required
- * because it is used in both the prototypes as well as the definitions.
- * Note also the long name.  We expect that this won't collide with
- * other names causing compiler warnings.
+ * Platform independent struct representing additional information about the
+ * received signal.  If the system does not support the extended information,
+ * or a field does not apply to the signal, the value is instead reset to the
+ * documented default value.
  */
 
-#ifndef SIGNAL_ARGS
-#define SIGNAL_ARGS  int postgres_signal_arg
-#endif
+typedef struct pg_signal_info
+{
+       uint32_t        pid;                    /* pid of sending process or 0 if unknown */
+       uint32_t        uid;                    /* uid of sending process; only meaningful
+                                                                * when pid is not 0 */
+} pg_signal_info;
+
+/*
+ * The following is used as the arg list for signal handlers. These days we
+ * use the same argument to all signal handlers and hide the difference
+ * between platforms in wrapper functions.
+ *
+ * SIGNAL_ARGS just exists separately from the pqsignal() definition for
+ * historical reasons.
+ */
+#define SIGNAL_ARGS  int postgres_signal_arg, const pg_signal_info *pg_siginfo
 
 /*
  * When there is no sigsetjmp, its functionality is provided by plain
index 51df9b80e7d56e10cb9eaf4431bfa9cd793b85ca..c029878c6beeb264f9377c9ae8115036ddca9cfc 100644 (file)
@@ -546,6 +546,9 @@ extern int  pg_mkdir_p(char *path, int omode);
 #else
 #define pqsignal pqsignal_be
 #endif
+
+#define PG_SIG_DFL (pqsigfunc) (pg_funcptr_t) SIG_DFL
+#define PG_SIG_IGN (pqsigfunc) (pg_funcptr_t) SIG_IGN
 typedef void (*pqsigfunc) (SIGNAL_ARGS);
 extern void pqsignal(int signo, pqsigfunc func);
 
index 1285b033e1b8722639ffb70b4aaaf8fa0d3d6ca8..0735e4ee0d5a6fcd0b68dea718b8579821929b00 100644 (file)
  * is to ensure that no in-tree code accidentally calls this version.)
  */
 #undef pqsignal
-extern pqsigfunc pqsignal(int signo, pqsigfunc func);
 
-pqsigfunc
-pqsignal(int signo, pqsigfunc func)
+typedef void (*pqsigfunc_legacy) (int postgres_signal_arg);
+extern pqsigfunc_legacy pqsignal(int signo, pqsigfunc_legacy func);
+
+pqsigfunc_legacy
+pqsignal(int signo, pqsigfunc_legacy func)
 {
 #ifndef WIN32
        struct sigaction act,
index 8841464b5cb0ac2b105cce2bfd0613298f732f0b..dd43f9eb2626899e8a026ad678b1a224b2f4804a 100644 (file)
 #define PG_NSIG (64)                   /* XXX: wild guess */
 #endif
 
+#if !(defined(WIN32) && defined(FRONTEND))
+#define USE_SIGACTION
+#endif
+
+#if defined(USE_SIGACTION) && defined(HAVE_SA_SIGINFO)
+#define USE_SIGINFO
+#endif
+
 /* Check a couple of common signals to make sure PG_NSIG is accurate. */
 StaticAssertDecl(SIGUSR2 < PG_NSIG, "SIGUSR2 >= PG_NSIG");
 StaticAssertDecl(SIGHUP < PG_NSIG, "SIGHUP >= PG_NSIG");
@@ -82,19 +90,16 @@ static volatile pqsigfunc pqsignal_handlers[PG_NSIG];
  *
  * This wrapper also handles restoring the value of errno.
  */
-#if !defined(FRONTEND) && defined(HAVE_SA_SIGINFO)
+#if defined(USE_SIGACTION) && defined(USE_SIGINFO)
 static void
-wrapper_handler(int signo, siginfo_t * info, void *context)
-#else
+wrapper_handler(int postgres_signal_arg, siginfo_t * info, void *context)
+#else                                                  /* no USE_SIGINFO */
 static void
-wrapper_handler(SIGNAL_ARGS)
+wrapper_handler(int postgres_signal_arg)
 #endif
 {
        int                     save_errno = errno;
-#if !defined(FRONTEND) && defined(HAVE_SA_SIGINFO)
-       /* SA_SIGINFO signature uses signo, not SIGNAL_ARGS macro */
-       int                     postgres_signal_arg = signo;
-#endif
+       pg_signal_info pg_info;
 
        Assert(postgres_signal_arg > 0);
        Assert(postgres_signal_arg < PG_NSIG);
@@ -110,21 +115,32 @@ wrapper_handler(SIGNAL_ARGS)
 
        if (unlikely(MyProcPid != (int) getpid()))
        {
-               pqsignal(postgres_signal_arg, SIG_DFL);
+               pqsignal(postgres_signal_arg, PG_SIG_DFL);
                raise(postgres_signal_arg);
                return;
        }
+#endif
 
 #ifdef HAVE_SA_SIGINFO
-       if (signo == SIGTERM && info)
-       {
-               ProcDieSenderPid = info->si_pid;
-               ProcDieSenderUid = info->si_uid;
-       }
-#endif
+
+       /*
+        * If supported by the system, forward interesting information from the
+        * system's extended signal information to our platform independent
+        * format.
+        */
+       pg_info.pid = info->si_pid;
+       pg_info.uid = info->si_uid;
+#else
+
+       /*
+        * Otherwise forward values indicating that we do not have the
+        * information.
+        */
+       pg_info.pid = 0;
+       pg_info.uid = 0;
 #endif
 
-       (*pqsignal_handlers[postgres_signal_arg]) (postgres_signal_arg);
+       (*pqsignal_handlers[postgres_signal_arg]) (postgres_signal_arg, &pg_info);
 
        errno = save_errno;
 }
@@ -139,33 +155,44 @@ wrapper_handler(SIGNAL_ARGS)
 void
 pqsignal(int signo, pqsigfunc func)
 {
-#if !(defined(WIN32) && defined(FRONTEND))
+#ifdef USE_SIGACTION
        struct sigaction act;
+#else
+       void            (*wrapper_func_ptr) (int);
 #endif
-       bool            use_wrapper = false;
+       bool            is_ign = func == PG_SIG_IGN;
+       bool            is_dfl = func == PG_SIG_DFL;
 
        Assert(signo > 0);
        Assert(signo < PG_NSIG);
 
-       if (func != SIG_IGN && func != SIG_DFL)
+       /* set up indirection handler */
+       if (!(is_ign || is_dfl))
        {
                pqsignal_handlers[signo] = func;        /* assumed atomic */
-               use_wrapper = true;
        }
 
-#if !(defined(WIN32) && defined(FRONTEND))
+       /*
+        * Configure system to either ignore/reset the signal handler, or to
+        * forward it to wrapper_handler.
+        */
+#ifdef USE_SIGACTION
        sigemptyset(&act.sa_mask);
        act.sa_flags = SA_RESTART;
-#if !defined(FRONTEND) && defined(HAVE_SA_SIGINFO)
-       if (use_wrapper)
+
+       if (is_ign)
+               act.sa_handler = SIG_IGN;
+       else if (is_dfl)
+               act.sa_handler = SIG_DFL;
+#ifdef USE_SIGINFO
+       else
        {
                act.sa_sigaction = wrapper_handler;
                act.sa_flags |= SA_SIGINFO;
        }
-       else
-               act.sa_handler = func;
 #else
-       act.sa_handler = use_wrapper ? wrapper_handler : func;
+       else
+               act.sa_handler = wrapper_handler;
 #endif
 
 #ifdef SA_NOCLDSTOP
@@ -174,9 +201,20 @@ pqsignal(int signo, pqsigfunc func)
 #endif
        if (sigaction(signo, &act, NULL) < 0)
                Assert(false);                  /* probably indicates coding error */
-#else
-       /* Forward to Windows native signal system. */
-       if (signal(signo, use_wrapper ? wrapper_handler : func) == SIG_ERR)
+#else                                                  /* no USE_SIGACTION */
+
+       /*
+        * Forward to Windows native signal system, we need to send this though
+        * wrapper handler as it it needs to take single argument only.
+        */
+       if (is_ign)
+               wrapper_func_ptr = SIG_IGN;
+       else if (is_dfl)
+               wrapper_func_ptr = SIG_DFL;
+       else
+               wrapper_func_ptr = wrapper_handler;
+
+       if (signal(signo, wrapper_func_ptr) == SIG_ERR)
                Assert(false);                  /* probably indicates coding error */
 #endif
 }
index 0c0620569829bd5b85b3b88a21ac078b18a65d22..c26efeba1ee3a77cd2577944af280c59b5ff4e2d 100644 (file)
@@ -492,7 +492,7 @@ signal_remove_temp(SIGNAL_ARGS)
 {
        remove_temp();
 
-       pqsignal(postgres_signal_arg, SIG_DFL);
+       pqsignal(postgres_signal_arg, PG_SIG_DFL);
        raise(postgres_signal_arg);
 }
 
index ea95e7984bcfbedd3fae5c7528b0361307397111..49dfb662abc40f8eb105e5466c55987d551eb254 100644 (file)
@@ -4039,6 +4039,7 @@ pg_sha224_ctx
 pg_sha256_ctx
 pg_sha384_ctx
 pg_sha512_ctx
+pg_signal_info
 pg_snapshot
 pg_special_case
 pg_stack_base_t