]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ethtool: rss: add missing errno on RSS context delete
authorJakub Kicinski <kuba@kernel.org>
Fri, 22 May 2026 23:06:43 +0000 (16:06 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 26 May 2026 15:17:56 +0000 (08:17 -0700)
Remember to set ret before jumping out if someone tries
to delete a context on a device which doesn't support
contexts.

Fixes: fbe09277fa63 ("ethtool: rss: support removing contexts via Netlink")
Link: https://patch.msgid.link/20260522230647.1705600-3-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/rss.c

index 8ffec9785efa82b240bfa33101a5dd039a3fc811..a16ee1e8e6400ac57fae7b8f7348263a15df1bf7 100644 (file)
@@ -1170,8 +1170,10 @@ int ethnl_rss_delete_doit(struct sk_buff *skb, struct genl_info *info)
        dev = req.dev;
        ops = dev->ethtool_ops;
 
-       if (!ops->create_rxfh_context)
+       if (!ops->create_rxfh_context) {
+               ret = -EOPNOTSUPP;
                goto exit_free_dev;
+       }
 
        rtnl_lock();
        netdev_lock_ops(dev);