Fix assignment vs comparison typo in tcp_connected()

In tcp_connected() a typo has turned a DbC check into an assignment
breaking the state machine and making the dns_dispatch_gettcp() try to
attach to dispatch in process of destruction.

diff --git a/lib/dns/dispatch.c b/lib/dns/dispatch.c
index cf426f32eb7b61ab1fb46685da8a8a4482b2a306..3fbdb7f1489951623cd9561bbd992dc0146b3956 100644 (file)
--- a/lib/dns/dispatch.c
+++ b/lib/dns/dispatch.c
@@ -1842,7 +1842,7 @@ tcp_connected(isc_nmhandle_t *handle, isc_result_t eresult, void *arg) {
        }
 
        LOCK(&disp->lock);
-       INSIST(disp->state = DNS_DISPATCHSTATE_CONNECTING);
+       INSIST(disp->state == DNS_DISPATCHSTATE_CONNECTING);
 
        if (eresult == ISC_R_SUCCESS) {
                disp->state = DNS_DISPATCHSTATE_CONNECTED;