]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Allowing changing Userspace-RCU variant only in developer mode
authorOndřej Surý <ondrej@isc.org>
Thu, 26 Oct 2023 07:14:10 +0000 (09:14 +0200)
committerOndřej Surý <ondrej@isc.org>
Thu, 26 Oct 2023 08:20:29 +0000 (10:20 +0200)
The Userspace-RCU variants other than membarrier is untested and at
least in QSBR case it's broken.  Allow changing the Userspace-RCU
variant only in the developer's mode.

configure.ac

index cce13b499fedd8051916547e33c1f3024b1123eb..4837cc549ba44705a9ad6a1750acc5affa4ed7db 100644 (file)
@@ -207,7 +207,7 @@ AS_IF([test -z "$PKG_CONFIG"],
 # [pairwise: --with-liburcu=membarrier, --with-liburcu=qsbr, --with-liburcu=mb, --with-liburcu=signal, --with-liburcu=bp]
 AC_ARG_WITH([liburcu],
            [AS_HELP_STRING([--with-liburcu=FLAVOR],
-                            [Build with Userspace-RCU variant (membarrier|qsbr|mb|signal|bp) [default=membarrier]]))],
+                            [Build with Userspace-RCU variant (developer-only option) (membarrier|qsbr|mb|signal|bp) [default=membarrier]]))],
            [], [with_liburcu=membarrier])
 
 AC_MSG_CHECKING([liburcu flavor])
@@ -229,6 +229,9 @@ AS_CASE([$with_liburcu],
         AC_DEFINE([RCU_BP], [1], [Build with bulletproof Userspace-RCU flavor])],
        [AC_MSG_ERROR([Invalid Userspace-RCU flavor picked])])
 
+AS_IF([test "$with_liburcu" != "membarrier" && test "$enable_developer" != "yes"],
+      [AC_MSG_ERROR([Changing Userspace-RCU variant is allowed only in developer mode])])
+
 AC_MSG_RESULT([$RCU_FLAVOR])
 
 #