]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-148663: Document that `calendar.IllegalMonthError` inherits from both `ValueError...
authorEoin Shaughnessy <45000144+EoinTrial@users.noreply.github.com>
Thu, 23 Apr 2026 14:50:23 +0000 (15:50 +0100)
committerGitHub <noreply@github.com>
Thu, 23 Apr 2026 14:50:23 +0000 (15:50 +0100)
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Stan Ulbrych <stan@python.org>
Doc/library/calendar.rst
Lib/test/test_calendar.py
Misc/NEWS.d/next/Documentation/2026-04-17-02-28-55.gh-issue-148663.MHIbRB.rst [new file with mode: 0644]

index 2ddef79eab0bfb36b9521ca8eecd2d82ef274aac..1c8f25e96dcd6c82be43dd90be23e7ffd3856d6c 100644 (file)
@@ -580,9 +580,14 @@ The :mod:`!calendar` module defines the following exceptions:
 
 .. exception:: IllegalMonthError(month)
 
-   A subclass of :exc:`ValueError`,
+   A subclass of :exc:`ValueError` and :exc:`IndexError`,
    raised when the given month number is outside of the range 1-12 (inclusive).
 
+   .. versionchanged:: 3.12
+      :exc:`IllegalMonthError` is now also a subclass of
+      :exc:`ValueError`. New code should avoid catching
+      :exc:`IndexError`.
+
    .. attribute:: month
 
       The invalid month number.
index fe9a59d335b6b0272d7de3b41c40424c75aadd53..79f0ebb78ffe9c7c2135c2ec369cf1226e305c77 100644 (file)
@@ -495,12 +495,17 @@ class OutputTestCase(unittest.TestCase):
             calendar.TextCalendar().formatmonth(0, 2),
             result_0_02_text
         )
+
     def test_formatmonth_with_invalid_month(self):
         with self.assertRaises(calendar.IllegalMonthError):
             calendar.TextCalendar().formatmonth(2017, 13)
         with self.assertRaises(calendar.IllegalMonthError):
             calendar.TextCalendar().formatmonth(2017, -1)
 
+    def test_illegal_month_error_bases(self):
+        self.assertIsSubclass(calendar.IllegalMonthError, ValueError)
+        self.assertIsSubclass(calendar.IllegalMonthError, IndexError)
+
     def test_formatmonthname_with_year(self):
         self.assertEqual(
             calendar.HTMLCalendar().formatmonthname(2004, 1, withyear=True),
diff --git a/Misc/NEWS.d/next/Documentation/2026-04-17-02-28-55.gh-issue-148663.MHIbRB.rst b/Misc/NEWS.d/next/Documentation/2026-04-17-02-28-55.gh-issue-148663.MHIbRB.rst
new file mode 100644 (file)
index 0000000..0fbe5a6
--- /dev/null
@@ -0,0 +1,2 @@
+Document that :class:`calendar.IllegalMonthError` is a subclass of both
+:exc:`ValueError` and :exc:`IndexError` since Python 3.12.