mm/damon/sysfs-schemes: delete tried region in regions_rmdirs()

DAMON sysfs maintains the DAMOS tried region directory objects via a
linked list.  When the user requests refresh of the directories, DAMON
sysfs removes all the region directories first, and then generate updated
regions directory on the empty space.  The removal function
(damon_sysfs_scheme_regions_rm_dirs()) only puts the kobj objects.
Deletion of the container region object from the linked list is done
inside the kobj release callback function.

If somehow the callback invocation is delayed, the list will contain
regions list that gonna be freed.  If the updated region directories
creation is started in this situation, the list can be corrupted and
use-after-free can happen.

Because the kobj objects are managed by only DAMON sysfs, the issue cannot
happen in normal situation.  But, such delays can be made on kernels that
built with CONFIG_DEBUG_KOBJECT_RELEASE.  On the kernel, the issue can
indeed be reproduced like below.

    # damo start --damos_action stat
    # cd /sys/kernel/mm/damon/admin/kdamonds/0/
    # for i in {1..10}; do echo update_schemes_tried_regions > state; done
    # dmesg | grep underflow
    [   89.296152] refcount_t: underflow; use-after-free.

Fix the issue by removing the region object from the list when
decrementing the reference count.

Also update damos_sysfs_populate_region_dir() to add the region object to
the list only after the kobject_init_and_add() is success, so that fail of
kobject_init_and_add() is not leaving the deallocated object on the list.

The issue was discovered [1] by Sashiko.

Link: https://lore.kernel.org/20260518152559.93038-1-sj@kernel.org
Link: https://lore.kernel.org/20260513011920.119183-1-sj@kernel.org
Fixes: 9277d0367ba1 ("mm/damon/sysfs-schemes: implement scheme region directory")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: <stable@vger.kernel.org> # 6.2.x
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c
index 04746cbb33272d33ca0b6cca9829bac401f4cc1e..a8014780edae98e4e94ce46d1f24cce7aff58326 100644 (file)
--- a/mm/damon/sysfs-schemes.c
+++ b/mm/damon/sysfs-schemes.c
@@ -88,7 +88,6 @@ static void damon_sysfs_scheme_region_release(struct kobject *kobj)
        struct damon_sysfs_scheme_region *region = container_of(kobj,
                        struct damon_sysfs_scheme_region, kobj);
 
-       list_del(&region->list);
        kfree(region);
 }
 
@@ -164,7 +163,7 @@ static void damon_sysfs_scheme_regions_rm_dirs(
        struct damon_sysfs_scheme_region *r, *next;
 
        list_for_each_entry_safe(r, next, &regions->regions_list, list) {
-               /* release function deletes it from the list */
+               list_del(&r->list);
                kobject_put(&r->kobj);
                regions->nr_regions--;
        }
@@ -2928,14 +2927,15 @@ void damos_sysfs_populate_region_dir(struct damon_sysfs_schemes *sysfs_schemes,
        if (!region)
                return;
        region->sz_filter_passed = sz_filter_passed;
-       list_add_tail(&region->list, &sysfs_regions->regions_list);
-       sysfs_regions->nr_regions++;
        if (kobject_init_and_add(&region->kobj,
                                &damon_sysfs_scheme_region_ktype,
                                &sysfs_regions->kobj, "%d",
                                sysfs_regions->nr_regions++)) {
                kobject_put(&region->kobj);
+               return;
        }
+       list_add_tail(&region->list, &sysfs_regions->regions_list);
+       sysfs_regions->nr_regions++;
 }
 
 int damon_sysfs_schemes_clear_regions(