realtek: mdio: add missing brackets to RTMDIO_PHY_POLL_MMD

With its current usage type RTMDIO_PHY_POLL_MMD() definition is ok.
But for the sake of consistency add brackets around the macro
parameters and use masks to avoid calculation inconsistencies.

Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de>
Link: https://github.com/openwrt/openwrt/pull/23204
Signed-off-by: Robert Marko <robimarko@gmail.com>

diff --git a/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c b/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c
index 30295cf694acbb573cea2b6e656c436c2e9ec4a3..a222c9281c289251e673e2155ab85a982998d130 100644 (file)
--- a/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c
+++ b/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c
@@ -38,7 +38,9 @@
 #define RTMDIO_PHY_MAC_1G                      3
 #define RTMDIO_PHY_MAC_2G_PLUS                 1
 
-#define RTMDIO_PHY_POLL_MMD(dev, reg, bit)     ((bit << 21) | (dev << 16) | (reg))
+#define RTMDIO_PHY_POLL_MMD(dev, reg, bit)     ((((bit) & GENMASK(3, 0)) << 21) | \
+                                                (((dev) & GENMASK(4, 0)) << 16) | \
+                                                ((reg) & GENMASK(15, 0)))
 
 /* MDIO bus registers/fields */
 #define RTMDIO_C45_DATA(devnum, regnum)                (((devnum) << 16) | ((regnum) & GENMASK(15, 0)))