daemon: guard NULL REMOTE_PORT in execute() logging

REMOTE_ADDR and REMOTE_PORT are both set by the same code path in
handle(), so neither should be NULL independently. However, the
existing code checks REMOTE_ADDR before the loginfo() call but not
REMOTE_PORT. If REMOTE_PORT were unset, NULL would be passed to
printf's %s, which is undefined behavior.

Add a fallback string for the NULL case, matching the existing
REMOTE_ADDR guard for consistency.

Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/daemon.c b/daemon.c
index 103c08d868d5de434dfe900a8294de5b8eaa8995..78cca8673fdb341d41a38af80511ea258ee97808 100644 (file)
--- a/daemon.c
+++ b/daemon.c
@@ -753,7 +753,7 @@ static int execute(void)
        struct strvec env = STRVEC_INIT;
 
        if (addr)
-               loginfo("Connection from %s:%s", addr, port);
+               loginfo("Connection from %s:%s", addr, port ? port : "?");
 
        set_keep_alive(0);
        alarm(init_timeout ? init_timeout : timeout);