]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
silence punned error messages
authorMark Andrews <marka@isc.org>
Thu, 15 Apr 2004 01:38:09 +0000 (01:38 +0000)
committerMark Andrews <marka@isc.org>
Thu, 15 Apr 2004 01:38:09 +0000 (01:38 +0000)
14 files changed:
bin/dnssec/dnssec-signzone.c
bin/named/query.c
bin/named/update.c
bin/named/xfrout.c
bin/tests/db/t_db.c
lib/dns/dbtable.c
lib/dns/dispatch.c
lib/dns/lookup.c
lib/dns/rbtdb.c
lib/dns/resolver.c
lib/dns/sdb.c
lib/dns/validator.c
lib/dns/zt.c
lib/isc/unix/socket.c

index dce9cd73887b8f415b6ee8760d1c3b92fbdb3fd2..c84ac6170f7f6f1a2500eb5082474e9f2131de12 100644 (file)
@@ -16,7 +16,7 @@
  * IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: dnssec-signzone.c,v 1.139.2.3 2004/03/09 06:09:16 marka Exp $ */
+/* $Id: dnssec-signzone.c,v 1.139.2.4 2004/04/15 01:38:04 marka Exp $ */
 
 #include <config.h>
 
@@ -1241,7 +1241,7 @@ assignwork(isc_task_t *task, isc_task_t *worker) {
        sevent->node = node;
        sevent->fname = fname;
        sevent->fnextname = fnextname;
-       isc_task_send(worker, (isc_event_t **)&sevent);
+       isc_task_send(worker, (isc_event_t **) (void *) &sevent);
        assigned++;
 }
 
@@ -1308,7 +1308,7 @@ sign(isc_task_t *task, isc_event_t *event) {
                fatal("failed to allocate event\n");
        wevent->node = node;
        wevent->fname = fname;
-       isc_task_send(master, (isc_event_t **)&wevent);
+       isc_task_send(master, (isc_event_t **) (void*) &wevent);
 }
 
 /*
index 40e59dbf0f16b21f7736ebf8561a32b1d64833d3..5bafe3efe82b139cacb64aeb2d75d07cb4bce680 100644 (file)
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: query.c,v 1.198.2.17 2004/03/09 06:09:19 marka Exp $ */
+/* $Id: query.c,v 1.198.2.18 2004/04/15 01:38:04 marka Exp $ */
 
 #include <config.h>
 
@@ -3237,7 +3237,7 @@ query_find(ns_client_t *client, dns_fetchevent_t *event, dns_rdatatype_t qtype)
                dns_db_detach(&zdb);
        }
        if (event != NULL)
-               isc_event_free((isc_event_t **)(&event));
+               isc_event_free((isc_event_t **) (void*)&event);
 
        /*
         * AA bit.
index c558f15fe7ea81bb737ef8bd10445d15913c33f7..c13d862c25f5c02f3f87159d7c283053d6a58088 100644 (file)
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: update.c,v 1.88.2.6 2004/03/09 06:09:20 marka Exp $ */
+/* $Id: update.c,v 1.88.2.7 2004/04/15 01:38:05 marka Exp $ */
 
 #include <config.h>
 
@@ -1892,11 +1892,11 @@ send_update_event(ns_client_t *client, dns_zone_t *zone) {
        event->ev_arg = evclient;
 
        dns_zone_gettask(zone, &zonetask);
-       isc_task_send(zonetask, (isc_event_t **)&event);
+       isc_task_send(zonetask, (isc_event_t **) (void *)&event);
 
  failure:
        if (event != NULL)
-               isc_event_free((isc_event_t **)&event);
+               isc_event_free((isc_event_t **) (void *)&event);
        return (result);
 }
 
@@ -2529,7 +2529,7 @@ forward_fail(isc_task_t *task, isc_event_t *event) {
 
        respond(client, DNS_R_SERVFAIL);
        ns_client_detach(&client);
-       isc_event_free((isc_event_t **)&event);
+       isc_event_free(&event);
 }
 
 
@@ -2547,7 +2547,7 @@ forward_callback(void *arg, isc_result_t result, dns_message_t *answer) {
                uev->ev_action = forward_done;
                uev->answer = answer;
        }
-       isc_task_send(client->task, (isc_event_t**)&uev);
+       isc_task_send(client->task, (isc_event_t **) (void *)&uev);
 }
 
 static void
@@ -2559,7 +2559,7 @@ forward_done(isc_task_t *task, isc_event_t *event) {
 
        ns_client_sendraw(client, uev->answer);
        dns_message_destroy(&uev->answer);
-       isc_event_free((isc_event_t **)&event);
+       isc_event_free(&event);
        ns_client_detach(&client);
 }
 
@@ -2601,10 +2601,10 @@ send_forward_event(ns_client_t *client, dns_zone_t *zone) {
        event->ev_arg = evclient;
 
        dns_zone_gettask(zone, &zonetask);
-       isc_task_send(zonetask, (isc_event_t **)&event);
+       isc_task_send(zonetask, (isc_event_t **) (void *)&event);
 
  failure:
        if (event != NULL)
-               isc_event_free((isc_event_t **)&event);
+               isc_event_free((isc_event_t **) (void *)&event);
        return (result);
 }
index 76a113ac2d41c85820fcd2eb8f1758527fe5f7db..8823a7a01ef08a980d41a204eb3b5b1b1a8db329 100644 (file)
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: xfrout.c,v 1.101.2.7 2004/04/06 00:27:29 marka Exp $ */
+/* $Id: xfrout.c,v 1.101.2.8 2004/04/15 01:38:05 marka Exp $ */
 
 #include <config.h>
 
@@ -412,7 +412,7 @@ ixfr_rrstream_create(isc_mem_t *mctx,
        return (ISC_R_SUCCESS);
 
  failure:
-       ixfr_rrstream_destroy((rrstream_t **) &s);
+       ixfr_rrstream_destroy((rrstream_t **) (void *)&s);
        return (result);
 }
 
@@ -499,7 +499,7 @@ axfr_rrstream_create(isc_mem_t *mctx, dns_db_t *db, dns_dbversion_t *ver,
        return (ISC_R_SUCCESS);
 
  failure:
-       axfr_rrstream_destroy((rrstream_t **) &s);
+       axfr_rrstream_destroy((rrstream_t **) (void *)&s);
        return (result);
 }
 
@@ -619,7 +619,7 @@ soa_rrstream_create(isc_mem_t *mctx, dns_db_t *db, dns_dbversion_t *ver,
        return (ISC_R_SUCCESS);
 
  failure:
-       soa_rrstream_destroy((rrstream_t **) &s);
+       soa_rrstream_destroy((rrstream_t **) (void *)&s);
        return (result);
 }
 
index 40eafe02dca81785ca4257a7d7e226c3e68ace56..3f3324ed4bbac2e2b877ce0685d2b9e551502b29 100644 (file)
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: t_db.c,v 1.29.2.1 2004/03/09 06:09:36 marka Exp $ */
+/* $Id: t_db.c,v 1.29.2.2 2004/04/15 01:38:06 marka Exp $ */
 
 #include <config.h>
 
@@ -44,7 +44,7 @@ t_create(const char *db_type, const char *origin, const char *class,
        int                     len;
        isc_result_t            dns_result;
        dns_dbtype_t            dbtype;
-       isc_constregion_t       region;
+       isc_textregion_t        region;
        isc_buffer_t            origin_buffer;
        dns_fixedname_t         dns_origin;
        dns_rdataclass_t        rdataclass;
@@ -66,10 +66,9 @@ t_create(const char *db_type, const char *origin, const char *class,
                return(dns_result);
        }
 
-       region.base = class;
+       DE_CONST(class, region.base);
        region.length = strlen(class);
-       dns_result = dns_rdataclass_fromtext(&rdataclass,
-                                            (isc_textregion_t *)&region);
+       dns_result = dns_rdataclass_fromtext(&rdataclass, &region);
        if (dns_result != ISC_R_SUCCESS) {
                t_info("dns_rdataclass_fromtext failed %s\n",
                       dns_result_totext(dns_result));
index 8112d8ba66da2b6d6731d96d8cb6cb070216f88d..e814722dc77268dbb711edd0b09d118294e8db3c 100644 (file)
@@ -16,7 +16,7 @@
  */
 
 /*
- * $Id: dbtable.c,v 1.25.2.1 2004/03/09 06:11:00 marka Exp $
+ * $Id: dbtable.c,v 1.25.2.2 2004/04/15 01:38:06 marka Exp $
  */
 
 /*
@@ -211,7 +211,7 @@ dns_dbtable_remove(dns_dbtable_t *dbtable, dns_db_t *db) {
        RWLOCK(&dbtable->tree_lock, isc_rwlocktype_write);
 
        result = dns_rbt_findname(dbtable->rbt, name, 0, NULL,
-                                 (void **)&stored_data);
+                                 (void **) (void *)&stored_data);
 
        if (result == ISC_R_SUCCESS) {
                INSIST(stored_data == db);
@@ -275,7 +275,7 @@ dns_dbtable_find(dns_dbtable_t *dbtable, dns_name_t *name,
        RWLOCK(&dbtable->tree_lock, isc_rwlocktype_read);
 
        result = dns_rbt_findname(dbtable->rbt, name, rbtoptions, NULL,
-                                 (void **)&stored_data);
+                                 (void **) (void *)&stored_data);
 
        if (result == ISC_R_SUCCESS || result == DNS_R_PARTIALMATCH)
                dns_db_attach(stored_data, dbp);
index 06361fe3f7442567c1886f8807bec471b715aaef..06a1e57d9d9aadfafc51d9df36ce9a4c53088ba4 100644 (file)
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: dispatch.c,v 1.101.2.8 2004/03/09 06:11:01 marka Exp $ */
+/* $Id: dispatch.c,v 1.101.2.9 2004/04/15 01:38:06 marka Exp $ */
 
 #include <config.h>
 
@@ -670,7 +670,7 @@ udp_recv(isc_task_t *task, isc_event_t *ev_in) {
                            rev, rev->buffer.base, rev->buffer.length,
                            resp->task);
                resp->item_out = ISC_TRUE;
-               isc_task_send(resp->task, (isc_event_t **)&rev);
+               isc_task_send(resp->task, (isc_event_t **) (void *)&rev);
        }
 
        /*
@@ -846,7 +846,7 @@ tcp_recv(isc_task_t *task, isc_event_t *ev_in) {
                            rev, rev->buffer.base, rev->buffer.length,
                            resp->task);
                resp->item_out = ISC_TRUE;
-               isc_task_send(resp->task, (isc_event_t **)&rev);
+               isc_task_send(resp->task, (isc_event_t **) (void *)&rev);
        }
 
        /*
@@ -1984,7 +1984,7 @@ do_cancel(dns_dispatch_t *disp, dns_dispentry_t *resp) {
                    "cancel: failsafe event %p -> task %p",
                    ev, resp->task);
        resp->item_out = ISC_TRUE;
-       isc_task_send(resp->task, (isc_event_t **)&ev);
+       isc_task_send(resp->task, (isc_event_t **) (void *)&ev);
 }
 
 isc_socket_t *
@@ -2080,7 +2080,7 @@ dns_dispatch_importrecv(dns_dispatch_t *disp, isc_event_t *event) {
 
        buf = allocate_udp_buffer(disp);
        if (buf == NULL) {
-               isc_event_free((isc_event_t **)&newsevent);
+               isc_event_free((isc_event_t **) (void *)&newsevent);
                return;
        }
        memcpy(buf, sevent->region.base, sevent->n);
@@ -2093,7 +2093,7 @@ dns_dispatch_importrecv(dns_dispatch_t *disp, isc_event_t *event) {
        newsevent->pktinfo = sevent->pktinfo;
        newsevent->attributes = sevent->attributes;
        
-       isc_task_send(disp->task, (isc_event_t **)&newsevent);
+       isc_task_send(disp->task, (isc_event_t **) (void*)&newsevent);
 }
 
 #if 0
index b6f43378711c64d2578922b36c4f942597134acb..173d6fbaafef1964a323bb2bbc157f49e4ea49f1 100644 (file)
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: lookup.c,v 1.9.2.1 2004/03/09 06:11:03 marka Exp $ */
+/* $Id: lookup.c,v 1.9.2.2 2004/04/15 01:38:07 marka Exp $ */
 
 #include <config.h>
 
@@ -321,7 +321,7 @@ lookup_find(dns_lookup_t *lookup, dns_fetchevent_t *event) {
                                dns_db_detachnode(event->db, &event->node);
                        if (event->db != NULL)
                                dns_db_detach(&event->db);
-                       isc_event_free((isc_event_t **)&event);
+                       isc_event_free((isc_event_t **) (void *)&event);
                }
 
                /*
index 74f6114600d232159df1facdd9322497d2e3b6e4..305e75ee2312335eb0e851aa4dd8c73009267422 100644 (file)
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: rbtdb.c,v 1.168.2.16 2004/03/09 06:11:04 marka Exp $ */
+/* $Id: rbtdb.c,v 1.168.2.17 2004/04/15 01:38:07 marka Exp $ */
 
 /*
  * Principal Author: Bob Halley
@@ -3325,7 +3325,7 @@ zone_findrdataset(dns_db_t *db, dns_dbnode_t *node, dns_dbversion_t *version,
        REQUIRE(type != dns_rdatatype_any);
 
        if (rbtversion == NULL) {
-               currentversion(db, (dns_dbversion_t **)(&rbtversion));
+               currentversion(db, (dns_dbversion_t **) (void *)(&rbtversion));
                close_version = ISC_TRUE;
        }
        serial = rbtversion->serial;
@@ -3383,7 +3383,8 @@ zone_findrdataset(dns_db_t *db, dns_dbnode_t *node, dns_dbversion_t *version,
        UNLOCK(&rbtdb->node_locks[rbtnode->locknum].lock);
 
        if (close_version)
-               closeversion(db, (dns_dbversion_t **)(&rbtversion), ISC_FALSE);
+               closeversion(db, (dns_dbversion_t **) (void *)(&rbtversion),
+                            ISC_FALSE);
 
        if (found == NULL)
                return (ISC_R_NOTFOUND);
@@ -3489,7 +3490,8 @@ allrdatasets(dns_db_t *db, dns_dbnode_t *node, dns_dbversion_t *version,
        if ((db->attributes & DNS_DBATTR_CACHE) == 0) {
                now = 0;
                if (rbtversion == NULL)
-                       currentversion(db, (dns_dbversion_t **)(&rbtversion));
+                       currentversion(db,
+                                (dns_dbversion_t **) (void *)(&rbtversion));
                else {
                        LOCK(&rbtdb->lock);
                        INSIST(rbtversion->references > 0);
index bc6d5b4384060691ff5e5fc4c447bf1165265307..b1fc4cdd7d9ae774e35f9163c97541fc5275ee28 100644 (file)
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: resolver.c,v 1.218.2.29 2004/03/09 06:11:07 marka Exp $ */
+/* $Id: resolver.c,v 1.218.2.30 2004/04/15 01:38:07 marka Exp $ */
 
 #include <config.h>
 
@@ -627,7 +627,7 @@ fctx_sendevents(fetchctx_t *fctx, isc_result_t result) {
                       fctx->type == dns_rdatatype_any ||
                       fctx->type == dns_rdatatype_sig);
 
-               isc_task_sendanddetach(&task, (isc_event_t **)&event);
+               isc_task_sendanddetach(&task, (isc_event_t **) (void *)&event);
        }
 }
 
@@ -5263,7 +5263,7 @@ dns_resolver_cancelfetch(dns_fetch_t *fetch) {
                etask = event->ev_sender;
                event->ev_sender = fctx;
                event->result = ISC_R_CANCELED;
-               isc_task_sendanddetach(&etask, (isc_event_t **)&event);
+               isc_task_sendanddetach(&etask, (isc_event_t **) (void *)&event);
        }
        /*
         * The fctx continues running even if no fetches remain;
index b2a4507e989d220c6db2bb76cbee3b024438537f..eb6d38aafd2e16997d9d9b1aaf979a5d90eb2da1 100644 (file)
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: sdb.c,v 1.35.2.4 2004/03/09 06:11:07 marka Exp $ */
+/* $Id: sdb.c,v 1.35.2.5 2004/04/15 01:38:08 marka Exp $ */
 
 #include <config.h>
 
@@ -283,7 +283,7 @@ dns_sdb_putrr(dns_sdblookup_t *lookup, const char *type, dns_ttl_t ttl,
        dns_rdatalist_t *rdatalist;
        dns_rdata_t *rdata;
        dns_rdatatype_t typeval;
-       isc_consttextregion_t r;
+       isc_textregion_t r;
        isc_buffer_t b;
        isc_buffer_t *rdatabuf;
        isc_lex_t *lex;
@@ -299,9 +299,9 @@ dns_sdb_putrr(dns_sdblookup_t *lookup, const char *type, dns_ttl_t ttl,
 
        mctx = lookup->sdb->common.mctx;
 
-       r.base = type;
+       DE_CONST(type, r.base);
        r.length = strlen(type);
-       result = dns_rdatatype_fromtext(&typeval, (isc_textregion_t *)&r);
+       result = dns_rdatatype_fromtext(&typeval, &r);
        if (result != ISC_R_SUCCESS)
                return (result);
 
@@ -661,7 +661,7 @@ destroynode(dns_sdbnode_t *node) {
        DESTROYLOCK(&node->lock);
        node->magic = 0;
        isc_mem_put(mctx, node, sizeof(dns_sdbnode_t));
-       detach((dns_db_t **)&sdb);
+       detach((dns_db_t **) (void *)&sdb);
 }
 
 static isc_result_t
@@ -999,7 +999,7 @@ createiterator(dns_db_t *db, isc_boolean_t relative_names,
        result = imp->methods->allnodes(sdb->zone, sdb->dbdata, sdbiter);
        MAYBE_UNLOCK(sdb);
        if (result != ISC_R_SUCCESS) {
-               dbiterator_destroy((dns_dbiterator_t **)&sdbiter);
+               dbiterator_destroy((dns_dbiterator_t **) (void *)&sdbiter);
                return (result);
        }
 
index 7f2d79f266740bcc28ebd678ca246452dc767bb4..35323337a1cfd05cbcaf831ca21dd765aebfa3a6 100644 (file)
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: validator.c,v 1.91.2.6 2004/03/09 06:11:10 marka Exp $ */
+/* $Id: validator.c,v 1.91.2.7 2004/04/15 01:38:08 marka Exp $ */
 
 #include <config.h>
 
@@ -1546,7 +1546,7 @@ dns_validator_create(dns_view_t *view, dns_name_t *name, dns_rdatatype_t type,
        ISC_LINK_INIT(val, link);
        val->magic = VALIDATOR_MAGIC;
 
-       isc_task_send(task, (isc_event_t **)&event);
+       isc_task_send(task, (isc_event_t **) (void *)&event);
 
        *validatorp = val;
 
index 22d457ed3be4b68b28bb4697a16c50d1e58703df..9efdee7caffd5a159cdbbcd850d7526644300d3c 100644 (file)
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: zt.c,v 1.33.2.2 2004/03/09 06:11:11 marka Exp $ */
+/* $Id: zt.c,v 1.33.2.3 2004/04/15 01:38:09 marka Exp $ */
 
 #include <config.h>
 
@@ -148,7 +148,7 @@ dns_zt_find(dns_zt_t *zt, dns_name_t *name, unsigned int options,
        RWLOCK(&zt->rwlock, isc_rwlocktype_read);
 
        result = dns_rbt_findname(zt->table, name, rbtoptions, foundname,
-                                 (void **)&dummy);
+                                 (void **) (void*)&dummy);
        if (result == ISC_R_SUCCESS || result == DNS_R_PARTIALMATCH)
                dns_zone_attach(dummy, zonep);
 
index 492714dc4d8c7446286bfd7e186ccbf8447cb305..eb7d9aafe1570cc94010723aab2b603d5c3ffb7c 100644 (file)
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: socket.c,v 1.207.2.24 2004/03/17 05:33:38 marka Exp $ */
+/* $Id: socket.c,v 1.207.2.25 2004/04/15 01:38:09 marka Exp $ */
 
 #include <config.h>
 
@@ -1958,7 +1958,7 @@ internal_accept(isc_task_t *me, isc_event_t *ev) {
        task = dev->ev_sender;
        dev->ev_sender = sock;
 
-       isc_task_sendanddetach(&task, (isc_event_t **)&dev);
+       isc_task_sendanddetach(&task, (isc_event_t **) (void *)&dev);
        return;
 
  soft_error:
@@ -2964,7 +2964,7 @@ isc_socket_accept(isc_socket_t *sock,
 
        ret = allocate_socket(manager, sock->type, &nsock);
        if (ret != ISC_R_SUCCESS) {
-               isc_event_free((isc_event_t **)&dev);
+               isc_event_free((isc_event_t **) (void *)&dev);
                UNLOCK(&sock->lock);
                return (ret);
        }
@@ -3064,12 +3064,12 @@ isc_socket_connect(isc_socket_t *sock, isc_sockaddr_t *addr,
                UNEXPECTED_ERROR(__FILE__, __LINE__, "%d/%s", errno, strbuf);
 
                UNLOCK(&sock->lock);
-               isc_event_free((isc_event_t **)&dev);
+               isc_event_free((isc_event_t **) (void *)&dev);
                return (ISC_R_UNEXPECTED);
 
        err_exit:
                sock->connected = 0;
-               isc_task_send(task, (isc_event_t **)&dev);
+               isc_task_send(task, (isc_event_t **) (void *)&dev);
 
                UNLOCK(&sock->lock);
                return (ISC_R_SUCCESS);
@@ -3082,7 +3082,7 @@ isc_socket_connect(isc_socket_t *sock, isc_sockaddr_t *addr,
                sock->connected = 1;
                sock->bound = 1;
                dev->result = ISC_R_SUCCESS;
-               isc_task_send(task, (isc_event_t **)&dev);
+               isc_task_send(task, (isc_event_t **) (void *)&dev);
 
                UNLOCK(&sock->lock);
                return (ISC_R_SUCCESS);
@@ -3220,7 +3220,7 @@ internal_connect(isc_task_t *me, isc_event_t *ev) {
 
        task = dev->ev_sender;
        dev->ev_sender = sock;
-       isc_task_sendanddetach(&task, (isc_event_t **)&dev);
+       isc_task_sendanddetach(&task, (isc_event_t **) (void *)&dev);
 }
 
 isc_result_t
@@ -3368,7 +3368,7 @@ isc_socket_cancel(isc_socket_t *sock, isc_task_t *task, unsigned int how) {
                                dev->result = ISC_R_CANCELED;
                                dev->ev_sender = sock;
                                isc_task_sendanddetach(&current_task,
-                                                      (isc_event_t **)&dev);
+                                               (isc_event_t **) (void *)&dev);
                        }
 
                        dev = next;
@@ -3395,7 +3395,7 @@ isc_socket_cancel(isc_socket_t *sock, isc_task_t *task, unsigned int how) {
                        dev->result = ISC_R_CANCELED;
                        dev->ev_sender = sock;
                        isc_task_sendanddetach(&current_task,
-                                              (isc_event_t **)&dev);
+                                              (isc_event_t **) (void *)&dev);
                }
        }