]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
serial: mxs-auart: replace hardcoded 1 with predefined macro GPIO_LINE_DIRECTION_IN
authorNikola Z. Ivanov <zlatistiv@gmail.com>
Sun, 26 Apr 2026 21:42:50 +0000 (00:42 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 11 May 2026 14:55:37 +0000 (16:55 +0200)
The GPIO_LINE_DIRECTION_* definitions have just recently been exposed to
gpio consumers.h by breaking them out in a separate defs.h file.

Use this to validate the gpio direction instead of the hard-coded literal.

Signed-off-by: Nikola Z. Ivanov <zlatistiv@gmail.com>
Link: https://patch.msgid.link/20260426214250.781151-1-zlatistiv@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/mxs-auart.c

index 693b491f1e755d19cb8c7a12f2bb78ab2b1d775f..697318dbb146bdd266c8401bd9544001d41be157 100644 (file)
@@ -1520,7 +1520,7 @@ static int mxs_auart_init_gpios(struct mxs_auart_port *s, struct device *dev)
 
        for (i = 0; i < UART_GPIO_MAX; i++) {
                gpiod = mctrl_gpio_to_gpiod(s->gpios, i);
-               if (gpiod && (gpiod_get_direction(gpiod) == 1))
+               if (gpiod && (gpiod_get_direction(gpiod) == GPIO_LINE_DIRECTION_IN))
                        s->gpio_irq[i] = gpiod_to_irq(gpiod);
                else
                        s->gpio_irq[i] = -EINVAL;