]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
tracing: Add NULL pointer check to trigger_data_free()
authorGuenter Roeck <linux@roeck-us.net>
Thu, 5 Mar 2026 19:33:39 +0000 (11:33 -0800)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Fri, 6 Mar 2026 18:04:30 +0000 (13:04 -0500)
If trigger_data_alloc() fails and returns NULL, event_hist_trigger_parse()
jumps to the out_free error path. While kfree() safely handles a NULL
pointer, trigger_data_free() does not. This causes a NULL pointer
dereference in trigger_data_free() when evaluating
data->cmd_ops->set_filter.

Fix the problem by adding a NULL pointer check to trigger_data_free().

The problem was found by an experimental code review agent based on
gemini-3.1-pro while reviewing backports into v6.18.y.

Cc: Miaoqian Lin <linmq006@gmail.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Steven Rostedt (Google) <rostedt@goodmis.org>
Link: https://patch.msgid.link/20260305193339.2810953-1-linux@roeck-us.net
Fixes: 0550069cc25f ("tracing: Properly process error handling in event_hist_trigger_parse()")
Assisted-by: Gemini:gemini-3.1-pro
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace_events_trigger.c

index fecbd679d4329f85a3f0c9489e34d689949553ef..d5230b759a2dc803ab09d249cd638c13dff6c538 100644 (file)
@@ -50,6 +50,9 @@ static int trigger_kthread_fn(void *ignore)
 
 void trigger_data_free(struct event_trigger_data *data)
 {
+       if (!data)
+               return;
+
        if (data->cmd_ops->set_filter)
                data->cmd_ops->set_filter(NULL, data, NULL);