]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Remove dead code
authorEvan Hunt <each@isc.org>
Wed, 13 Oct 2021 15:43:47 +0000 (08:43 -0700)
committerEvan Hunt <each@isc.org>
Wed, 13 Oct 2021 16:27:46 +0000 (09:27 -0700)
Remove code from dns_zone_setparentals() that cannot be reached
now that set_serverslist() returns void.

lib/dns/zone.c

index 163ccb3c25f6cfeff851ac253617b18ad8f227fa..c2e1dafd2b0d77a053cb0cc3ec094b4593964816 100644 (file)
@@ -6454,7 +6454,6 @@ void
 dns_zone_setparentals(dns_zone_t *zone, const isc_sockaddr_t *parentals,
                      dns_name_t **keynames, dns_name_t **tlsnames,
                      uint32_t count) {
-       isc_result_t result = ISC_R_SUCCESS;
        isc_sockaddr_t *newaddrs = NULL;
        isc_dscp_t *newdscps = NULL;
        dns_name_t **newkeynames = NULL;
@@ -6485,9 +6484,6 @@ dns_zone_setparentals(dns_zone_t *zone, const isc_sockaddr_t *parentals,
        set_serverslist(count, parentals, &newaddrs, NULL, &newdscps, keynames,
                        &newkeynames, tlsnames, &newtlsnames, zone->mctx);
        INSIST(newdscps == NULL);
-       if (result != ISC_R_SUCCESS) {
-               goto unlock;
-       }
 
        /*
         * Everything is ok so attach to the zone.