]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: hibmcge: disable Relaxed Ordering to fix RX packet corruption
authorJijie Shao <shaojijie@huawei.com>
Mon, 25 May 2026 14:45:24 +0000 (22:45 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 28 May 2026 10:59:36 +0000 (12:59 +0200)
When SMMU is disabled, the hibmcge driver may receive corrupted packets.
The hardware writes packet data and descriptors to the same page, but
with Relaxed Ordering enabled, PCI write transactions may not be
strictly ordered. This can cause the driver to observe a valid
descriptor before the corresponding packet data is fully written.

Fix this by clearing PCI_EXP_DEVCTL_RELAX_EN in the PCI bridge control
register to ensure strict write ordering between packet data and
descriptors.

Fixes: f72e25594061 ("net: hibmcge: Implement rx_poll function to receive packets")
Signed-off-by: Jijie Shao <shaojijie@huawei.com>
Link: https://patch.msgid.link/20260525144525.94884-2-shaojijie@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/hisilicon/hibmcge/hbg_main.c

index 068da2fd1fea839941c916d931ff9a60be3a066a..f721e98938049e1b361cbac5df9a008aaa49706b 100644 (file)
@@ -420,6 +420,9 @@ static int hbg_pci_init(struct pci_dev *pdev)
                return -ENOMEM;
 
        pci_set_master(pdev);
+       pcie_capability_clear_word(pdev, PCI_EXP_DEVCTL,
+                                  PCI_EXP_DEVCTL_RELAX_EN);
+       pci_save_state(pdev);
        return 0;
 }