gdb: change gdbarch_vbit_in_delta to bool

Remove the set_gdbarch_vbit_in_delta call in msp430-tdep.c, since the
value defaults to false.

Change-Id: I1fd2fa3c5d4049598325e826900c894a14e18ea1
Approved-By: Tom Tromey <tom@tromey.com>

diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index 35a70396034988b3ebcd47ebbd58e6b0b0bf4187..ce196b2201ec50eea99753b7007cadfc19d8c5f8 100644 (file)
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -4846,7 +4846,7 @@ aarch64_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
   set_gdbarch_print_insn (gdbarch, aarch64_gdb_print_insn);
 
   /* Virtual tables.  */
-  set_gdbarch_vbit_in_delta (gdbarch, 1);
+  set_gdbarch_vbit_in_delta (gdbarch, true);
 
   /* Hook in the ABI-specific overrides, if they have been registered.  */
   info.target_desc = tdesc;

diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
index cabba3d061af8a8229b153269e8a77bdfe3aaccb..4b77b223edcf095e68d538dcbc5d5fb9e6241d81 100644 (file)
--- a/gdb/arm-tdep.c
+++ b/gdb/arm-tdep.c
@@ -10769,7 +10769,7 @@ arm_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
                                         arm_adjust_breakpoint_address);
 
   /* Virtual tables.  */
-  set_gdbarch_vbit_in_delta (gdbarch, 1);
+  set_gdbarch_vbit_in_delta (gdbarch, true);
 
   /* Hook in the ABI-specific overrides, if they have been registered.  */
   gdbarch_init_osabi (info, gdbarch);

diff --git a/gdb/gdbarch-gen.c b/gdb/gdbarch-gen.c
index 8210d52e03d031d3efab19978d40063703deef01..73371537c0aa4ae276dcaa1df659278a521a0faa 100644 (file)
--- a/gdb/gdbarch-gen.c
+++ b/gdb/gdbarch-gen.c
@@ -183,7 +183,7 @@ struct gdbarch
   gdbarch_core_read_x86_xsave_layout_ftype *core_read_x86_xsave_layout = nullptr;
   const char * gcore_bfd_target = 0;
   bool vtable_function_descriptors = false;
-  int vbit_in_delta = 0;
+  bool vbit_in_delta = 0;
   ULONGEST max_insn_length = 0;
   gdbarch_displaced_step_copy_insn_ftype *displaced_step_copy_insn = nullptr;
   gdbarch_displaced_step_hw_singlestep_ftype *displaced_step_hw_singlestep = default_displaced_step_hw_singlestep;
@@ -3934,7 +3934,7 @@ set_gdbarch_vtable_function_descriptors (struct gdbarch *gdbarch,
   gdbarch->vtable_function_descriptors = vtable_function_descriptors;
 }
 
-int
+bool
 gdbarch_vbit_in_delta (struct gdbarch *gdbarch)
 {
   gdb_assert (gdbarch != NULL);
@@ -3946,7 +3946,7 @@ gdbarch_vbit_in_delta (struct gdbarch *gdbarch)
 
 void
 set_gdbarch_vbit_in_delta (struct gdbarch *gdbarch,
-                          int vbit_in_delta)
+                          bool vbit_in_delta)
 {
   gdbarch->vbit_in_delta = vbit_in_delta;
 }

diff --git a/gdb/gdbarch-gen.h b/gdb/gdbarch-gen.h
index 4146377566633191722f8e7bfc7be9e61ff862d1..4cbe73eefc60c5c052a06b1013709cafaa1bb499 100644 (file)
--- a/gdb/gdbarch-gen.h
+++ b/gdb/gdbarch-gen.h
@@ -1061,8 +1061,8 @@ extern void set_gdbarch_vtable_function_descriptors (struct gdbarch *gdbarch, bo
 /* Set if the least significant bit of the delta is used instead of the least
    significant bit of the pfn for pointers to virtual member functions. */
 
-extern int gdbarch_vbit_in_delta (struct gdbarch *gdbarch);
-extern void set_gdbarch_vbit_in_delta (struct gdbarch *gdbarch, int vbit_in_delta);
+extern bool gdbarch_vbit_in_delta (struct gdbarch *gdbarch);
+extern void set_gdbarch_vbit_in_delta (struct gdbarch *gdbarch, bool vbit_in_delta);
 
 /* The maximum length of an instruction on this architecture in bytes. */
 

diff --git a/gdb/gdbarch_components.py b/gdb/gdbarch_components.py
index da982fb8259bb8e5fdcdc74e363274fa27157a50..7525ce043210570c27ebd80bd46c7e64651ee771 100644 (file)
--- a/gdb/gdbarch_components.py
+++ b/gdb/gdbarch_components.py
@@ -1792,7 +1792,7 @@ Value(
 Set if the least significant bit of the delta is used instead of the least
 significant bit of the pfn for pointers to virtual member functions.
 """,
-    type="int",
+    type="bool",
     name="vbit_in_delta",
     invalid=False,
 )

diff --git a/gdb/m32c-tdep.c b/gdb/m32c-tdep.c
index ee4665fe1ce7e1ea02ff0095b3efc1b005fd7eb5..4c4aa19185f06baacff868910971eae65ca0a385 100644 (file)
--- a/gdb/m32c-tdep.c
+++ b/gdb/m32c-tdep.c
@@ -2647,7 +2647,7 @@ m32c_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
      In order to verify this, see the definition of
      TARGET_PTRMEMFUNC_VBIT_LOCATION in gcc/defaults.h along with the
      definition of FUNCTION_BOUNDARY in gcc/config/m32c/m32c.h.  */
-  set_gdbarch_vbit_in_delta (gdbarch, 1);
+  set_gdbarch_vbit_in_delta (gdbarch, true);
 
   return gdbarch;
 }

diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c
index f1cda0b0935461e1ee4e591b5372208337efec5e..4c017f51c265416dab30e5646bf0f3ac68ec994b 100644 (file)
--- a/gdb/mips-tdep.c
+++ b/gdb/mips-tdep.c
@@ -8740,7 +8740,7 @@ mips_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
                                         mips_single_step_through_delay);
 
   /* Virtual tables.  */
-  set_gdbarch_vbit_in_delta (gdbarch, 1);
+  set_gdbarch_vbit_in_delta (gdbarch, true);
 
   mips_register_g_packet_guesses (gdbarch);
 

diff --git a/gdb/msp430-tdep.c b/gdb/msp430-tdep.c
index 7b28bec290f43f5f0c82d0b00bc00c7d1ffd6be2..a1c885497c0d74bc97ebd1afec4cba894c51c510 100644 (file)
--- a/gdb/msp430-tdep.c
+++ b/gdb/msp430-tdep.c
@@ -988,9 +988,6 @@ msp430_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
   set_gdbarch_in_solib_return_trampoline (gdbarch, msp430_in_return_stub);
   set_gdbarch_skip_trampoline_code (gdbarch, msp430_skip_trampoline_code);
 
-  /* Virtual tables.  */
-  set_gdbarch_vbit_in_delta (gdbarch, 0);
-
   return gdbarch;
 }
 

diff --git a/gdb/rl78-tdep.c b/gdb/rl78-tdep.c
index ead2b8494c57cb9bb25dad2c0c4c0d1451273cf9..4c938333e06dbb7ce4cec455fbc8e8b99ecbd6f7 100644 (file)
--- a/gdb/rl78-tdep.c
+++ b/gdb/rl78-tdep.c
@@ -1481,7 +1481,7 @@ rl78_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
   set_gdbarch_return_value (gdbarch, rl78_return_value);
 
   /* Virtual tables.  */
-  set_gdbarch_vbit_in_delta (gdbarch, 1);
+  set_gdbarch_vbit_in_delta (gdbarch, true);
 
   return gdbarch;
 }

diff --git a/gdb/rx-tdep.c b/gdb/rx-tdep.c
index 2e91ae756ce3e89181902f2724424af84228fa88..96e2c5b1a75593e8e22d0a9ebbd0d246298c346f 100644 (file)
--- a/gdb/rx-tdep.c
+++ b/gdb/rx-tdep.c
@@ -1056,7 +1056,7 @@ rx_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
   set_gdbarch_return_value (gdbarch, rx_return_value);
 
   /* Virtual tables.  */
-  set_gdbarch_vbit_in_delta (gdbarch, 1);
+  set_gdbarch_vbit_in_delta (gdbarch, true);
 
   return gdbarch;
 }