warn about zones with both dnssec-policy and max-zone-ttl

max-zone-ttl in zone/view/options is a no-op if dnssec-policy
is in use, so generate a warning.

diff --git a/bin/tests/system/checkconf/tests.sh b/bin/tests/system/checkconf/tests.sh
index e1131dab514e7c71351ff137a154d9dcb9da9b20..e0ca6ecb428235d349b7fbad0209c19571341190 100644 (file)
--- a/bin/tests/system/checkconf/tests.sh
+++ b/bin/tests/system/checkconf/tests.sh
@@ -607,6 +607,14 @@ grep "not recommended" < checkconf.out$n > /dev/null || ret=1
 if [ $ret != 0 ]; then echo_i "failed"; ret=1; fi
 status=`expr $status + $ret`
 
+n=`expr $n + 1`
+echo_i "check that using both max-zone-ttl and dnssec-policy generates a warning ($n)"
+ret=0
+$CHECKCONF warn-kasp-max-zone-ttl.conf > checkconf.out$n 2>/dev/null || ret=1
+grep "option 'max-zone-ttl' is ignored when used together with 'dnssec-policy'" < checkconf.out$n > /dev/null || ret=1
+if [ $ret != 0 ]; then echo_i "failed"; ret=1; fi
+status=`expr $status + $ret`
+
 rmdir keys
 
 echo_i "exit status: $status"

diff --git a/bin/tests/system/checkconf/warn-kasp-max-zone-ttl.conf b/bin/tests/system/checkconf/warn-kasp-max-zone-ttl.conf
new file mode 100644 (file)
index 0000000..0b59394
--- /dev/null
+++ b/bin/tests/system/checkconf/warn-kasp-max-zone-ttl.conf
@@ -0,0 +1,26 @@
+/*
+ * Copyright (C) Internet Systems Consortium, Inc. ("ISC")
+ *
+ * SPDX-License-Identifier: MPL-2.0
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0.  If a copy of the MPL was not distributed with this
+ * file, you can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See the COPYRIGHT file distributed with this work for additional
+ * information regarding copyright ownership.
+ */
+
+/*
+ * The dnssec-policy is not defined. Should also be caught if it is inherited.
+ */
+
+options {
+       dnssec-policy default;
+};
+
+zone "example.net" {
+       type primary;
+       file "example.db";
+        max-zone-ttl 600;
+};

diff --git a/lib/bind9/check.c b/lib/bind9/check.c
index 9c98c528d9e0545cbd135207b93ee4e44dc50c5e..d88bf2883d76471ab87d1b42fc840e0295c57555 100644 (file)
--- a/lib/bind9/check.c
+++ b/lib/bind9/check.c
@@ -3144,6 +3144,27 @@ check_zoneconf(const cfg_obj_t *zconfig, const cfg_obj_t *voptions,
                }
        }
 
+       /*
+        * Warn about zones with both dnssec-policy and max-zone-ttl
+        */
+       if (has_dnssecpolicy) {
+               obj = NULL;
+               (void)cfg_map_get(zoptions, "max-zone-ttl", &obj);
+               if (obj == NULL && voptions != NULL) {
+                       (void)cfg_map_get(voptions, "max-zone-ttl", &obj);
+               }
+               if (obj == NULL && goptions != NULL) {
+                       (void)cfg_map_get(goptions, "max-zone-ttl", &obj);
+               }
+               if (obj != NULL) {
+                       cfg_obj_log(obj, logctx, ISC_LOG_WARNING,
+                                   "zone '%s': option 'max-zone-ttl' "
+                                   "is ignored when used together with "
+                                   "'dnssec-policy'",
+                                   znamestr);
+               }
+       }
+
        /*
         * Check validity of the zone options.
         */