#include <asiolink/interval_timer.h>
#include <asiolink/io_service.h>
+#include <asiolink/testutils/test_tls.h>
#include <cc/command_interpreter.h>
#include <config/command_mgr.h>
#include <config/http_command_mgr.h>
using namespace std;
using namespace isc;
using namespace isc::asiolink;
+using namespace isc::asiolink::test;
using namespace isc::config;
using namespace isc::d2;
using namespace isc::data;
/// @brief Test timeout (ms).
const long TEST_TIMEOUT = 10000;
-/// @brief Fixture class intended for testing HTTP control channel in D2.
-class HttpCtrlChannelD2Test : public ::testing::Test {
+/// @brief Base fixture class intended for testing HTTP/HTTPS control channel
+/// in D2.
+class BaseCtrlChannelD2Test : public ::testing::Test {
public:
/// @brief Reference to the base controller object.
DControllerBasePtr& server_;
/// @brief Default constructor.
///
/// Sets socket path to its default value.
- HttpCtrlChannelD2Test()
+ BaseCtrlChannelD2Test()
: server_(NakedD2Controller::instance()) {
}
/// @brief Destructor.
- ~HttpCtrlChannelD2Test() {
+ virtual ~BaseCtrlChannelD2Test() {
// Deregister & co.
server_.reset();
IOServicePtr io_service = getIOService();
ASSERT_TRUE(io_service);
IntervalTimer test_timer(io_service);
- test_timer.setup(std::bind(&HttpCtrlChannelD2Test::timeoutHandler,
+ test_timer.setup(std::bind(&BaseCtrlChannelD2Test::timeoutHandler,
this, true),
TEST_TIMEOUT, IntervalTimer::ONE_SHOT);
// Run until the client stops the service or an error occurs.
}
/// @brief Create a server with a HTTP command channel.
- void createHttpChannelServer() {
- // Just a simple config. The important part here is the socket
- // location information.
- string config_txt =
- "{"
- " \"ip-address\": \"192.168.77.1\","
- " \"port\": 777,"
- " \"control-socket\": {"
- " \"socket-type\": \"http\","
- " \"socket-address\": \"127.0.0.1\","
- " \"socket-port\": 18125"
- " },"
- " \"tsig-keys\": [],"
- " \"forward-ddns\" : {},"
- " \"reverse-ddns\" : {}"
- "}";
-
- ASSERT_TRUE(server_);
-
- ConstElementPtr config;
- ASSERT_NO_THROW(config = parseDHCPDDNS(config_txt, true));
- ASSERT_NO_THROW(d2Controller()->initProcess());
- D2ProcessPtr proc = d2Controller()->getProcess();
- ASSERT_TRUE(proc);
- ConstElementPtr answer = proc->configure(config, false);
- ASSERT_TRUE(answer);
- ASSERT_NO_THROW(d2Controller()->registerCommands());
-
- int status = 0;
- ConstElementPtr txt = parseAnswer(status, answer);
- // This should succeed. If not, print the error message.
- ASSERT_EQ(0, status) << txt->str();
-
- // Now check that the socket was indeed open.
- ASSERT_TRUE(HttpCommandMgr::instance().getHttpListener());
- }
+ virtual void createHttpChannelServer() = 0;
/// @brief Constructs a complete HTTP POST given a request body.
///
/// @param command the command text to execute in JSON form.
/// @param response variable into which the received response should be
/// placed.
- void sendHttpCommand(const string& command, string& response) {
- response = "";
- IOServicePtr io_service = getIOService();
- ASSERT_TRUE(io_service);
- boost::scoped_ptr<TestHttpClient> client;
- client.reset(new TestHttpClient(io_service, SERVER_ADDRESS,
- SERVER_PORT));
- ASSERT_TRUE(client);
-
- // Send the command. This will trigger server's handler which
- // receives data over the HTTP socket. The server will start
- // sending response to the client.
- ASSERT_NO_THROW(client->startRequest(buildPostStr(command)));
- runIOService();
- ASSERT_TRUE(client->receiveDone());
-
- // Read the response generated by the server.
- HttpResponsePtr hr;
- ASSERT_NO_THROW(hr = parseResponse(client->getResponse()));
- response = hr->getBody();
-
- // Now close client.
- client->close();
-
- ASSERT_NO_THROW(io_service->poll());
- }
+ virtual void sendHttpCommand(const string& command, string& response) = 0;
/// @brief Parse list answer.
///
}
return (createAnswer(CONTROL_RESULT_SUCCESS, arguments));
}
+
+ // Tests that the server properly responds to invalid commands.
+ void testInvalid();
+
+ // Tests that the server properly responds to shutdown command.
+ void testShutdown();
+
+ // Tests that the server sets exit value supplied as argument
+ // to shutdown command.
+ void testShutdownExitValue();
+
+ // This test verifies that the D2 server handles version-get commands.
+ void testGetversion();
+
+ // Tests that the server properly responds to list-commands command.
+ void testListCommands();
+
+ // This test verifies that the D2 server handles status-get commands.
+ void testStatusGet();
+
+ // Tests if the server returns its configuration using config-get.
+ void testConfigGet();
+
+ // Tests if the server returns the hash of its configuration using
+ // config-hash-get.
+ void testConfigHashGet();
+
+ // Tests if config-write can be called without any parameters.
+ void testWriteConfigNoFilename();
+
+ // Tests if config-write can be called with a valid filename as parameter.
+ void testWriteConfigFilename();
+
+ // Tests if config-reload attempts to reload a file and reports that the
+ // file is missing.
+ void testConfigReloadMissingFile();
+
+ // Tests if config-reload attempts to reload a file and reports that the
+ // file is not a valid JSON.
+ void testConfigReloadBrokenFile();
+
+ // Tests if config-reload attempts to reload a file and reports that the
+ // file is loaded correctly.
+ void testConfigReloadFileValid();
+
+ // This test verifies that the server can receive and process a
+ // large command.
+ void testLongCommand();
+
+ // This test verifies that the server can send long response to the client.
+ void testLongResponse();
+
+ // This test verifies that the server signals timeout if the transmission
+ // takes too long, having received no data from the client.
+ void testConnectionTimeoutNoData();
};
-const char* HttpCtrlChannelD2Test::CFG_TEST_FILE = "d2-http-test-config.json";
+const char* BaseCtrlChannelD2Test::CFG_TEST_FILE = "d2-http-test-config.json";
+
+/// @brief Fixture class intended for testing HTTP control channel in D2.
+class HttpCtrlChannelD2Test : public BaseCtrlChannelD2Test {
+public:
+
+ /// @brief Constructor.
+ HttpCtrlChannelD2Test() : BaseCtrlChannelD2Test() {
+ }
+
+ /// @brief Destructor.
+ virtual ~HttpCtrlChannelD2Test() = default;
+
+ /// @brief Create a server with a HTTP command channel.
+ virtual void createHttpChannelServer() override {
+ // Just a simple config. The important part here is the socket
+ // location information.
+ string config_txt =
+ "{"
+ " \"ip-address\": \"192.168.77.1\","
+ " \"port\": 777,"
+ " \"control-socket\": {"
+ " \"socket-type\": \"http\","
+ " \"socket-address\": \"127.0.0.1\","
+ " \"socket-port\": 18125"
+ " },"
+ " \"tsig-keys\": [],"
+ " \"forward-ddns\" : {},"
+ " \"reverse-ddns\" : {}"
+ "}";
+
+ ASSERT_TRUE(server_);
+
+ ConstElementPtr config;
+ ASSERT_NO_THROW(config = parseDHCPDDNS(config_txt, true));
+ ASSERT_NO_THROW(d2Controller()->initProcess());
+ D2ProcessPtr proc = d2Controller()->getProcess();
+ ASSERT_TRUE(proc);
+ ConstElementPtr answer = proc->configure(config, false);
+ ASSERT_TRUE(answer);
+ ASSERT_NO_THROW(d2Controller()->registerCommands());
+
+ int status = 0;
+ ConstElementPtr txt = parseAnswer(status, answer);
+ // This should succeed. If not, print the error message.
+ ASSERT_EQ(0, status) << txt->str();
+
+ // Now check that the socket was indeed open.
+ ASSERT_TRUE(HttpCommandMgr::instance().getHttpListener());
+ }
+
+ /// @brief Conducts a command/response exchange via HttpCommandSocket.
+ ///
+ /// This method connects to the given server over the given address/port.
+ /// If successful, it then sends the given command and retrieves the
+ /// server's response. Note that it polls the server's I/O service
+ /// where needed to cause the server to process IO events on
+ /// the control channel sockets.
+ ///
+ /// @param command the command text to execute in JSON form.
+ /// @param response variable into which the received response should be
+ /// placed.
+ virtual void sendHttpCommand(const string& command,
+ string& response) override {
+ response = "";
+ IOServicePtr io_service = getIOService();
+ ASSERT_TRUE(io_service);
+ boost::scoped_ptr<TestHttpClient> client;
+ client.reset(new TestHttpClient(io_service, SERVER_ADDRESS,
+ SERVER_PORT));
+ ASSERT_TRUE(client);
+
+ // Send the command. This will trigger server's handler which
+ // receives data over the HTTP socket. The server will start
+ // sending response to the client.
+ ASSERT_NO_THROW(client->startRequest(buildPostStr(command)));
+ runIOService();
+ ASSERT_TRUE(client->receiveDone());
+
+ // Read the response generated by the server.
+ HttpResponsePtr hr;
+ ASSERT_NO_THROW(hr = parseResponse(client->getResponse()));
+ response = hr->getBody();
+
+ // Now close client.
+ client->close();
+
+ ASSERT_NO_THROW(io_service->poll());
+ }
+};
+
+/// @brief Fixture class intended for testing HTTPS control channel in D2.
+class HttpsCtrlChannelD2Test : public BaseCtrlChannelD2Test {
+public:
+
+ /// @brief Constructor.
+ HttpsCtrlChannelD2Test() : BaseCtrlChannelD2Test() {
+ }
+
+ /// @brief Destructor.
+ virtual ~HttpsCtrlChannelD2Test() = default;
+
+ /// @brief Create a server with a HTTP command channel.
+ virtual void createHttpChannelServer() override {
+ // Just a simple config. The important part here is the socket
+ // location information.
+ string ca_dir(string(TEST_CA_DIR));
+ ostringstream cf_st;
+ cf_st << "{"
+ << " \"ip-address\": \"192.168.77.1\","
+ << " \"port\": 777,"
+ << " \"control-socket\": {"
+ << " \"socket-type\": \"https\","
+ << " \"socket-address\": \"127.0.0.1\","
+ << " \"socket-port\": 18125,"
+ << " \"trust-anchor\": \"" << ca_dir << "/kea-ca.crt\","
+ << " \"cert-file\": \"" << ca_dir << "/kea-server.crt\","
+ << " \"key-file\": \"" << ca_dir << "/kea-server.key\""
+ << " },"
+ << " \"tsig-keys\": [],"
+ << " \"forward-ddns\" : {},"
+ << " \"reverse-ddns\" : {}"
+ << "}";
+
+ ASSERT_TRUE(server_);
+
+ ConstElementPtr config;
+ ASSERT_NO_THROW(config = parseDHCPDDNS(cf_st.str(), true));
+ ASSERT_NO_THROW(d2Controller()->initProcess());
+ D2ProcessPtr proc = d2Controller()->getProcess();
+ ASSERT_TRUE(proc);
+ ConstElementPtr answer = proc->configure(config, false);
+ ASSERT_TRUE(answer);
+ ASSERT_NO_THROW(d2Controller()->registerCommands());
+
+ int status = 0;
+ ConstElementPtr txt = parseAnswer(status, answer);
+ // This should succeed. If not, print the error message.
+ ASSERT_EQ(0, status) << txt->str();
+
+ // Now check that the socket was indeed open.
+ ASSERT_TRUE(HttpCommandMgr::instance().getHttpListener());
+ }
+
+ /// @brief Conducts a command/response exchange via HttpCommandSocket.
+ ///
+ /// This method connects to the given server over the given address/port.
+ /// If successful, it then sends the given command and retrieves the
+ /// server's response. Note that it polls the server's I/O service
+ /// where needed to cause the server to process IO events on
+ /// the control channel sockets.
+ ///
+ /// @param command the command text to execute in JSON form.
+ /// @param response variable into which the received response should be
+ /// placed.
+ virtual void sendHttpCommand(const string& command,
+ string& response) override {
+ response = "";
+ IOServicePtr io_service = getIOService();
+ ASSERT_TRUE(io_service);
+ boost::scoped_ptr<TestHttpsClient> client;
+ TlsContextPtr client_tls_context;
+ configClient(client_tls_context);
+ client.reset(new TestHttpsClient(io_service, client_tls_context,
+ SERVER_ADDRESS, SERVER_PORT));
+ ASSERT_TRUE(client);
+
+ // Send the command. This will trigger server's handler which
+ // receives data over the HTTP socket. The server will start
+ // sending response to the client.
+ ASSERT_NO_THROW(client->startRequest(buildPostStr(command)));
+ runIOService();
+ ASSERT_TRUE(client->receiveDone());
+
+ // Read the response generated by the server.
+ HttpResponsePtr hr;
+ ASSERT_NO_THROW(hr = parseResponse(client->getResponse()));
+ response = hr->getBody();
+
+ // Now close client.
+ client->close();
+
+ ASSERT_NO_THROW(io_service->poll());
+ }
+};
// Tests that the server properly responds to invalid commands.
-TEST_F(HttpCtrlChannelD2Test, invalid) {
+void
+BaseCtrlChannelD2Test::testInvalid() {
EXPECT_NO_THROW(createHttpChannelServer());
string response;
EXPECT_EQ("{ \"result\": 400, \"text\": \"Bad Request\" }", response);
}
+TEST_F(HttpCtrlChannelD2Test, invalid) {
+ testInvalid();
+}
+
+TEST_F(HttpsCtrlChannelD2Test, invalid) {
+ testInvalid();
+}
+
// Tests that the server properly responds to shutdown command.
-TEST_F(HttpCtrlChannelD2Test, shutdown) {
+void
+BaseCtrlChannelD2Test::testShutdown() {
EXPECT_NO_THROW(createHttpChannelServer());
string response;
EXPECT_EQ(EXIT_SUCCESS, server_->getExitValue());
}
-// Tests that the server sets exit value supplied as argument
-// to shutdown command.
-TEST_F(HttpCtrlChannelD2Test, shutdownExitValue) {
+TEST_F(HttpCtrlChannelD2Test, shutdown) {
+ testShutdown();
+}
+
+TEST_F(HttpsCtrlChannelD2Test, shutdown) {
+ testShutdown();
+}
+
+void
+BaseCtrlChannelD2Test::testShutdownExitValue() {
EXPECT_NO_THROW(createHttpChannelServer());
string response;
EXPECT_EQ(77, server_->getExitValue());
}
+// Tests that the server sets exit value supplied as argument
+// to shutdown command.
+TEST_F(HttpCtrlChannelD2Test, shutdownExitValue) {
+ testShutdownExitValue();
+}
+
+// Tests that the server sets exit value supplied as argument
+// to shutdown command.
+TEST_F(HttpsCtrlChannelD2Test, shutdownExitValue) {
+ testShutdownExitValue();
+}
+
// This test verifies that the D2 server handles version-get commands.
-TEST_F(HttpCtrlChannelD2Test, getversion) {
+void
+BaseCtrlChannelD2Test::testGetversion() {
EXPECT_NO_THROW(createHttpChannelServer());
string response;
EXPECT_TRUE(response.find("GTEST_VERSION") != string::npos);
}
+TEST_F(HttpCtrlChannelD2Test, getversion) {
+ testGetversion();
+}
+
+TEST_F(HttpsCtrlChannelD2Test, getversion) {
+ testGetversion();
+}
+
// Tests that the server properly responds to list-commands command.
-TEST_F(HttpCtrlChannelD2Test, listCommands) {
+void
+BaseCtrlChannelD2Test::testListCommands() {
EXPECT_NO_THROW(createHttpChannelServer());
string response;
checkListCommands(rsp, "version-get");
}
+TEST_F(HttpCtrlChannelD2Test, listCommands) {
+ testListCommands();
+}
+
+TEST_F(HttpsCtrlChannelD2Test, listCommands) {
+ testListCommands();
+}
+
// This test verifies that the D2 server handles status-get commands.
-TEST_F(HttpCtrlChannelD2Test, statusGet) {
+void
+BaseCtrlChannelD2Test::testStatusGet() {
EXPECT_NO_THROW(createHttpChannelServer());
std::string response_txt;
/// uptime is tested.
}
+TEST_F(HttpCtrlChannelD2Test, statusGet) {
+ testStatusGet();
+}
+
+TEST_F(HttpsCtrlChannelD2Test, statusGet) {
+ testStatusGet();
+}
+
// Tests if the server returns its configuration using config-get.
// Note there are separate tests that verify if toElement() called by the
// config-get handler are actually converting the configuration correctly.
-TEST_F(HttpCtrlChannelD2Test, configGet) {
+void
+BaseCtrlChannelD2Test::testConfigGet() {
EXPECT_NO_THROW(createHttpChannelServer());
string response;
EXPECT_TRUE(cfg->get("DhcpDdns"));
}
+TEST_F(HttpCtrlChannelD2Test, configGet) {
+ testConfigGet();
+}
+
+TEST_F(HttpsCtrlChannelD2Test, configGet) {
+ testConfigGet();
+}
+
// Tests if the server returns the hash of its configuration using
// config-hash-get.
-TEST_F(HttpCtrlChannelD2Test, configHashGet) {
+void
+BaseCtrlChannelD2Test::testConfigHashGet() {
EXPECT_NO_THROW(createHttpChannelServer());
string response;
EXPECT_EQ(64, hash->stringValue().size());
}
-// Verify that the "config-test" command will do what we expect.
-TEST_F(HttpCtrlChannelD2Test, configTest) {
+TEST_F(HttpCtrlChannelD2Test, configHashGet) {
+ testConfigHashGet();
+}
+
+TEST_F(HttpsCtrlChannelD2Test, configHashGet) {
+ testConfigHashGet();
+}
+
+// Verify that the "config-test" command will do what we expect.
+TEST_F(HttpCtrlChannelD2Test, configTest) {
+
+ string d2_cfg_txt =
+ " { \n"
+ " \"ip-address\": \"192.168.77.1\", \n"
+ " \"port\": 777, \n"
+ " \"forward-ddns\" : {}, \n"
+ " \"reverse-ddns\" : {}, \n"
+ " \"tsig-keys\": [ \n"
+ " {\"name\": \"d2_key.example.com\", \n"
+ " \"algorithm\": \"hmac-md5\", \n"
+ " \"secret\": \"LSWXnfkKZjdPJI5QxlpnfQ==\"} \n"
+ " ], \n"
+ " \"control-socket\": { \n"
+ " \"socket-type\": \"http\", \n"
+ " \"socket-address\": \"127.0.0.1\", \n"
+ " \"socket-port\": 18125 \n"
+ " } \n"
+ " } \n";
+
+ ASSERT_TRUE(server_);
+
+ ConstElementPtr config;
+ ASSERT_NO_THROW(config = parseDHCPDDNS(d2_cfg_txt, true));
+ ASSERT_NO_THROW(d2Controller()->initProcess());
+ D2ProcessPtr proc = d2Controller()->getProcess();
+ ASSERT_TRUE(proc);
+ ConstElementPtr answer = proc->configure(config, false);
+ ASSERT_TRUE(answer);
+ EXPECT_EQ("{ \"arguments\": { \"hash\": \"029AE1208415D6911B5651A6F82D054F55B7877D2589CFD1DCEB5BFFCD3B13A3\" }, \"result\": 0, \"text\": \"Configuration applied successfully.\" }",
+ answer->str());
+ ASSERT_NO_THROW(d2Controller()->registerCommands());
+
+ // Check that the config was indeed applied.
+ D2CfgMgrPtr cfg_mgr = proc->getD2CfgMgr();
+ ASSERT_TRUE(cfg_mgr);
+ D2CfgContextPtr d2_context = cfg_mgr->getD2CfgContext();
+ ASSERT_TRUE(d2_context);
+ TSIGKeyInfoMapPtr keys = d2_context->getKeys();
+ ASSERT_TRUE(keys);
+ EXPECT_EQ(1, keys->size());
+
+ ASSERT_TRUE(HttpCommandMgr::instance().getHttpListener());
+
+ // Create a config with invalid content that should fail to parse.
+ string config_test_txt =
+ "{ \"command\": \"config-test\", \n"
+ " \"arguments\": { \n"
+ " \"DhcpDdns\": \n"
+ " { \n"
+ " \"ip-address\": \"192.168.77.1\", \n"
+ " \"port\": 777, \n"
+ " \"forward-ddns\" : {}, \n"
+ " \"reverse-ddns\" : {}, \n"
+ " \"tsig-keys\": [ \n"
+ " {\"BOGUS\": \"d2_key.example.com\", \n"
+ " \"algorithm\": \"hmac-md5\", \n"
+ " \"secret\": \"LSWXnfkKZjdPJI5QxlpnfQ==\"} \n"
+ " ], \n"
+ " \"control-socket\": { \n"
+ " \"socket-type\": \"http\", \n"
+ " \"socket-address\": \"127.0.0.1\", \n"
+ " \"socket-port\": 18125 \n"
+ " } \n"
+ " } \n"
+ "}} \n";
+
+ // Send the config-test command.
+ string response;
+ sendHttpCommand(config_test_txt, response);
+
+ // Should fail with a syntax error.
+ EXPECT_EQ("[ { \"result\": 1, \"text\": \"missing parameter 'name' (<string>:10:14)\" } ]",
+ response);
+
+ // Check that the config was not lost (fix: reacquire the context).
+ d2_context = cfg_mgr->getD2CfgContext();
+ keys = d2_context->getKeys();
+ ASSERT_TRUE(keys);
+ EXPECT_EQ(1, keys->size());
- string d2_cfg_txt =
+ // Create a valid config with two keys and no command channel.
+ config_test_txt =
+ "{ \"command\": \"config-test\", \n"
+ " \"arguments\": { \n"
+ " \"DhcpDdns\": \n"
" { \n"
" \"ip-address\": \"192.168.77.1\", \n"
" \"port\": 777, \n"
" \"tsig-keys\": [ \n"
" {\"name\": \"d2_key.example.com\", \n"
" \"algorithm\": \"hmac-md5\", \n"
- " \"secret\": \"LSWXnfkKZjdPJI5QxlpnfQ==\"} \n"
- " ], \n"
- " \"control-socket\": { \n"
- " \"socket-type\": \"http\", \n"
- " \"socket-address\": \"127.0.0.1\", \n"
- " \"socket-port\": 18125 \n"
- " } \n"
- " } \n";
+ " \"secret\": \"LSWXnfkKZjdPJI5QxlpnfQ==\"}, \n"
+ " {\"name\": \"d2_key.billcat.net\", \n"
+ " \"algorithm\": \"hmac-md5\", \n"
+ " \"digest-bits\": 120, \n"
+ " \"secret\": \"LSWXnfkKZjdPJI5QxlpnfQ==\"} \n"
+ " ] \n"
+ " } \n"
+ "}} \n";
+
+ // Send the config-test command.
+ sendHttpCommand(config_test_txt, response);
+
+ // Verify the configuration was successful.
+ EXPECT_EQ("[ { \"result\": 0, \"text\": \"Configuration check successful\" } ]",
+ response);
+
+ // Check that the config was not applied.
+ d2_context = cfg_mgr->getD2CfgContext();
+ keys = d2_context->getKeys();
+ ASSERT_TRUE(keys);
+ EXPECT_EQ(1, keys->size());
+}
+
+// Verify that the "config-test" command will do what we expect.
+TEST_F(HttpsCtrlChannelD2Test, configTest) {
+
+ string ca_dir(string(TEST_CA_DIR));
+ ostringstream d2_st;
+ d2_st << " { \n"
+ << " \"ip-address\": \"192.168.77.1\", \n"
+ << " \"port\": 777, \n"
+ << " \"forward-ddns\" : {}, \n"
+ << " \"reverse-ddns\" : {}, \n"
+ << " \"tsig-keys\": [ \n"
+ << " {\"name\": \"d2_key.example.com\", \n"
+ << " \"algorithm\": \"hmac-md5\", \n"
+ << " \"secret\": \"LSWXnfkKZjdPJI5QxlpnfQ==\"} \n"
+ << " ], \n"
+ << " \"control-socket\": { \n"
+ << " \"socket-type\": \"https\", \n"
+ << " \"socket-address\": \"127.0.0.1\", \n"
+ << " \"socket-port\": 18125, \n"
+ << " \"trust-anchor\": \"" << ca_dir << "/kea-ca.crt\", \n"
+ << " \"cert-file\": \"" << ca_dir << "/kea-server.crt\", \n"
+ << " \"key-file\": \"" << ca_dir << "/kea-server.key\" \n"
+ << " } \n"
+ << " } \n";
ASSERT_TRUE(server_);
ConstElementPtr config;
- ASSERT_NO_THROW(config = parseDHCPDDNS(d2_cfg_txt, true));
+ ASSERT_NO_THROW(config = parseDHCPDDNS(d2_st.str(), true));
ASSERT_NO_THROW(d2Controller()->initProcess());
D2ProcessPtr proc = d2Controller()->getProcess();
ASSERT_TRUE(proc);
ConstElementPtr answer = proc->configure(config, false);
ASSERT_TRUE(answer);
- EXPECT_EQ("{ \"arguments\": { \"hash\": \"029AE1208415D6911B5651A6F82D054F55B7877D2589CFD1DCEB5BFFCD3B13A3\" }, \"result\": 0, \"text\": \"Configuration applied successfully.\" }",
+ EXPECT_EQ("{ \"arguments\": { \"hash\": \"A6E28D3F41B4502EC72F3599E34D2785442D60C6F4FABAC3D1C4A4C49FE3D3C2\" }, \"result\": 0, \"text\": \"Configuration applied successfully.\" }",
answer->str());
ASSERT_NO_THROW(d2Controller()->registerCommands());
EXPECT_EQ(2, keys->size());
}
+// Verify that the "config-set" command will do what we expect.
+TEST_F(HttpsCtrlChannelD2Test, configSet) {
+
+ string ca_dir(string(TEST_CA_DIR));
+ ostringstream d2_st;
+ d2_st << " { \n"
+ << " \"ip-address\": \"192.168.77.1\", \n"
+ << " \"port\": 777, \n"
+ << " \"forward-ddns\" : {}, \n"
+ << " \"reverse-ddns\" : {}, \n"
+ << " \"tsig-keys\": [ \n"
+ << " {\"name\": \"d2_key.example.com\", \n"
+ << " \"algorithm\": \"hmac-md5\", \n"
+ << " \"secret\": \"LSWXnfkKZjdPJI5QxlpnfQ==\"} \n"
+ << " ], \n"
+ << " \"control-socket\": { \n"
+ << " \"socket-type\": \"https\", \n"
+ << " \"socket-address\": \"127.0.0.1\", \n"
+ << " \"socket-port\": 18125, \n"
+ << " \"trust-anchor\": \"" << ca_dir << "/kea-ca.crt\", \n"
+ << " \"cert-file\": \"" << ca_dir << "/kea-server.crt\", \n"
+ << " \"key-file\": \"" << ca_dir << "/kea-server.key\" \n"
+ << " } \n"
+ << " } \n";
+
+ ASSERT_TRUE(server_);
+
+ ConstElementPtr config;
+ ASSERT_NO_THROW(config = parseDHCPDDNS(d2_st.str(), true));
+ ASSERT_NO_THROW(d2Controller()->initProcess());
+ D2ProcessPtr proc = d2Controller()->getProcess();
+ ASSERT_TRUE(proc);
+ ConstElementPtr answer = proc->configure(config, false);
+ ASSERT_TRUE(answer);
+ EXPECT_EQ("{ \"arguments\": { \"hash\": \"A6E28D3F41B4502EC72F3599E34D2785442D60C6F4FABAC3D1C4A4C49FE3D3C2\" }, \"result\": 0, \"text\": \"Configuration applied successfully.\" }",
+ answer->str());
+ ASSERT_NO_THROW(d2Controller()->registerCommands());
+
+ // Check that the config was indeed applied.
+ D2CfgMgrPtr cfg_mgr = proc->getD2CfgMgr();
+ ASSERT_TRUE(cfg_mgr);
+ D2CfgContextPtr d2_context = cfg_mgr->getD2CfgContext();
+ ASSERT_TRUE(d2_context);
+ TSIGKeyInfoMapPtr keys = d2_context->getKeys();
+ ASSERT_TRUE(keys);
+ EXPECT_EQ(1, keys->size());
+
+ ASSERT_TRUE(HttpCommandMgr::instance().getHttpListener());
+
+ // Create a config with invalid content that should fail to parse.
+ string config_test_txt =
+ "{ \"command\": \"config-set\", \n"
+ " \"arguments\": { \n"
+ " \"DhcpDdns\": \n"
+ " { \n"
+ " \"ip-address\": \"192.168.77.1\", \n"
+ " \"port\": 777, \n"
+ " \"forward-ddns\" : {}, \n"
+ " \"reverse-ddns\" : {}, \n"
+ " \"tsig-keys\": [ \n"
+ " {\"BOGUS\": \"d2_key.example.com\", \n"
+ " \"algorithm\": \"hmac-md5\", \n"
+ " \"secret\": \"LSWXnfkKZjdPJI5QxlpnfQ==\"} \n"
+ " ], \n"
+ " \"control-socket\": { \n"
+ " \"socket-type\": \"http\", \n"
+ " \"socket-address\": \"127.0.0.1\", \n"
+ " \"socket-port\": 18125 \n"
+ " } \n"
+ " } \n"
+ "}} \n";
+
+ // Send the config-set command.
+ string response;
+ sendHttpCommand(config_test_txt, response);
+
+ // Should fail with a syntax error.
+ EXPECT_EQ("[ { \"result\": 1, \"text\": \"missing parameter 'name' (<string>:10:14)\" } ]",
+ response);
+
+ // Check that the config was not lost (fix: reacquire the context).
+ d2_context = cfg_mgr->getD2CfgContext();
+ keys = d2_context->getKeys();
+ ASSERT_TRUE(keys);
+ EXPECT_EQ(1, keys->size());
+
+ // Create a valid config with two keys and no command channel.
+ config_test_txt =
+ "{ \"command\": \"config-set\", \n"
+ " \"arguments\": { \n"
+ " \"DhcpDdns\": \n"
+ " { \n"
+ " \"ip-address\": \"192.168.77.1\", \n"
+ " \"port\": 777, \n"
+ " \"forward-ddns\" : {}, \n"
+ " \"reverse-ddns\" : {}, \n"
+ " \"tsig-keys\": [ \n"
+ " {\"name\": \"d2_key.example.com\", \n"
+ " \"algorithm\": \"hmac-md5\", \n"
+ " \"secret\": \"LSWXnfkKZjdPJI5QxlpnfQ==\"}, \n"
+ " {\"name\": \"d2_key.billcat.net\", \n"
+ " \"algorithm\": \"hmac-md5\", \n"
+ " \"digest-bits\": 120, \n"
+ " \"secret\": \"LSWXnfkKZjdPJI5QxlpnfQ==\"} \n"
+ " ] \n"
+ " } \n"
+ "}} \n";
+
+ // Verify the HTTP control channel socket exists.
+ EXPECT_TRUE(HttpCommandMgr::instance().getHttpListener());
+
+ // Send the config-set command.
+ sendHttpCommand(config_test_txt, response);
+
+ // Verify the HTTP control channel socket no longer exists.
+ ASSERT_NO_THROW(HttpCommandMgr::instance().garbageCollectListeners());
+ EXPECT_FALSE(HttpCommandMgr::instance().getHttpListener());
+
+ // Verify the configuration was successful.
+ EXPECT_EQ("[ { \"arguments\": { \"hash\": \"5206A1BEC7E3C6ADD5E97C5983861F97739EA05CFEAD823CBBC4"
+ "524095AAA10A\" }, \"result\": 0, \"text\": \"Configuration applied successfully.\" } ]",
+ response);
+
+ // Check that the config was applied.
+ d2_context = cfg_mgr->getD2CfgContext();
+ keys = d2_context->getKeys();
+ ASSERT_TRUE(keys);
+ EXPECT_EQ(2, keys->size());
+}
+
// Tests if config-write can be called without any parameters.
-TEST_F(HttpCtrlChannelD2Test, writeConfigNoFilename) {
+void
+BaseCtrlChannelD2Test::testWriteConfigNoFilename() {
EXPECT_NO_THROW(createHttpChannelServer());
string response;
::remove("test1.json");
}
+TEST_F(HttpCtrlChannelD2Test, writeConfigNoFilename) {
+ testWriteConfigNoFilename();
+}
+
+TEST_F(HttpsCtrlChannelD2Test, writeConfigNoFilename) {
+ testWriteConfigNoFilename();
+}
+
// Tests if config-write can be called with a valid filename as parameter.
-TEST_F(HttpCtrlChannelD2Test, writeConfigFilename) {
+void
+BaseCtrlChannelD2Test::testWriteConfigFilename() {
EXPECT_NO_THROW(createHttpChannelServer());
string response;
::remove("test2.json");
}
+TEST_F(HttpCtrlChannelD2Test, writeConfigFilename) {
+ testWriteConfigFilename();
+}
+
+TEST_F(HttpsCtrlChannelD2Test, writeConfigFilename) {
+ testWriteConfigFilename();
+}
+
// Tests if config-reload attempts to reload a file and reports that the
// file is missing.
-TEST_F(HttpCtrlChannelD2Test, configReloadMissingFile) {
+void
+BaseCtrlChannelD2Test::testConfigReloadMissingFile() {
EXPECT_NO_THROW(createHttpChannelServer());
string response;
EXPECT_EQ(expected, response);
}
+TEST_F(HttpCtrlChannelD2Test, configReloadMissingFile) {
+ testConfigReloadMissingFile();
+}
+
+TEST_F(HttpsCtrlChannelD2Test, configReloadMissingFile) {
+ testConfigReloadMissingFile();
+}
+
// Tests if config-reload attempts to reload a file and reports that the
// file is not a valid JSON.
-TEST_F(HttpCtrlChannelD2Test, configReloadBrokenFile) {
+void
+BaseCtrlChannelD2Test::testConfigReloadBrokenFile() {
EXPECT_NO_THROW(createHttpChannelServer());
string response;
::remove("testbad.json");
}
+TEST_F(HttpCtrlChannelD2Test, configReloadBrokenFile) {
+ testConfigReloadBrokenFile();
+}
+
+TEST_F(HttpsCtrlChannelD2Test, configReloadBrokenFile) {
+ testConfigReloadBrokenFile();
+}
+
// Tests if config-reload attempts to reload a file and reports that the
// file is loaded correctly.
-TEST_F(HttpCtrlChannelD2Test, configReloadFileValid) {
+void
+BaseCtrlChannelD2Test::testConfigReloadFileValid() {
EXPECT_NO_THROW(createHttpChannelServer());
string response;
::remove("testvalid.json");
}
+TEST_F(HttpCtrlChannelD2Test, configReloadFileValid) {
+ testConfigReloadFileValid();
+}
+
+TEST_F(HttpsCtrlChannelD2Test, configReloadFileValid) {
+ testConfigReloadFileValid();
+}
+
/// Verify that concurrent connections over the HTTP control channel can be
/// established.
TEST_F(HttpCtrlChannelD2Test, concurrentConnections) {
}
}
+/// Verify that concurrent connections over the HTTPS control channel can be
+/// established.
+TEST_F(HttpsCtrlChannelD2Test, concurrentConnections) {
+ EXPECT_NO_THROW(createHttpChannelServer());
+
+ const size_t NB = 5;
+ vector<IOServicePtr> io_services;
+ vector<TestHttpsClientPtr> clients;
+ vector<TlsContextPtr> tls_contexts;
+
+ // Create clients.
+ for (size_t i = 0; i < NB; ++i) {
+ IOServicePtr io_service(new IOService());
+ io_services.push_back(io_service);
+ TlsContextPtr tls_context;
+ configClient(tls_context);
+ tls_contexts.push_back(tls_context);
+ TestHttpsClientPtr client(new TestHttpsClient(io_service,
+ tls_context,
+ SERVER_ADDRESS,
+ SERVER_PORT));
+ clients.push_back(client);
+ }
+ ASSERT_EQ(NB, io_services.size());
+ ASSERT_EQ(NB, clients.size());
+
+ // Send requests and receive responses.
+ atomic<size_t> terminated;
+ terminated = 0;
+ vector<thread> threads;
+ const string command = "{ \"command\": \"list-commands\" }";
+ for (size_t i = 0; i < NB; ++i) {
+ threads.push_back(thread([&, i] () {
+ TestHttpsClientPtr client = clients[i];
+ ASSERT_TRUE(client);
+ client->startRequest(buildPostStr(command));
+ IOServicePtr io_service = io_services[i];
+ ASSERT_TRUE(io_service);
+ io_service->run();
+ ASSERT_TRUE(client->receiveDone());
+ HttpResponsePtr hr;
+ ASSERT_NO_THROW(hr = parseResponse(client->getResponse()));
+ string response = hr->getBody();
+ EXPECT_TRUE(response.find("\"result\": 0") != std::string::npos);
+ client->close();
+ ++terminated;
+ }));
+ }
+ ASSERT_EQ(NB, threads.size());
+
+ // Run the service IO services with a timeout.
+ IntervalTimer test_timer(getIOService());
+ bool timeout = false;
+ test_timer.setup([&timeout] () { timeout = true; },
+ TEST_TIMEOUT, IntervalTimer::ONE_SHOT);
+ while (!timeout && (terminated < NB)) {
+ getIOService()->poll();
+ }
+ test_timer.cancel();
+ EXPECT_FALSE(timeout);
+
+ // Cleanup clients.
+ for (IOServicePtr io_service : io_services) {
+ io_service->stopAndPoll();
+ }
+ for (auto th = threads.begin(); th != threads.end(); ++th) {
+ th->join();
+ }
+}
+
// This test verifies that the server can receive and process a large command.
-TEST_F(HttpCtrlChannelD2Test, longCommand) {
+void
+BaseCtrlChannelD2Test::testLongCommand() {
ostringstream command;
response);
}
+// Because of a bug where a segment is repeated from time to time
+// disable this test.
+TEST_F(HttpCtrlChannelD2Test, DISABLED_longCommand) {
+ testLongCommand();
+}
+
+TEST_F(HttpsCtrlChannelD2Test, DISABLED_longCommand) {
+ testLongCommand();
+}
+
// This test verifies that the server can send long response to the client.
-TEST_F(HttpCtrlChannelD2Test, longResponse) {
+void
+BaseCtrlChannelD2Test::testLongResponse() {
// We need to generate large response. The simplest way is to create
// a command and a handler which will generate some static response
// of a desired size.
EXPECT_EQ(reference_response, response);
}
+TEST_F(HttpCtrlChannelD2Test, longResponse) {
+ testLongResponse();
+}
+
+TEST_F(HttpsCtrlChannelD2Test, longResponse) {
+ testLongResponse();
+}
+
// This test verifies that the server signals timeout if the transmission
// takes too long, having received no data from the client.
-TEST_F(HttpCtrlChannelD2Test, connectionTimeoutNoData) {
+void
+BaseCtrlChannelD2Test::testConnectionTimeoutNoData() {
// Set connection timeout to 2s to prevent long waiting time for the
// timeout during this test.
const unsigned short timeout = 2000;
EXPECT_EQ("{ \"result\": 400, \"text\": \"Bad Request\" }", response);
}
+TEST_F(HttpCtrlChannelD2Test, connectionTimeoutNoData) {
+ testConnectionTimeoutNoData();
+}
+
+TEST_F(HttpsCtrlChannelD2Test, connectionTimeoutNoData) {
+ testConnectionTimeoutNoData();
+}
+
} // End of anonymous namespace
projects / thirdparty / kea.git / commitdiff
