]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
scsi: xen: scsiback: Fix potential memory leak in scsiback_remove()
authorAbdun Nihaal <nihaal@cse.iitm.ac.in>
Mon, 26 Jan 2026 15:51:19 +0000 (10:51 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Feb 2026 15:44:18 +0000 (16:44 +0100)
[ Upstream commit 901a5f309daba412e2a30364d7ec1492fa11c32c ]

Memory allocated for struct vscsiblk_info in scsiback_probe() is not
freed in scsiback_remove() leading to potential memory leaks on remove,
as well as in the scsiback_probe() error paths. Fix that by freeing it
in scsiback_remove().

Cc: stable@vger.kernel.org
Fixes: d9d660f6e562 ("xen-scsiback: Add Xen PV SCSI backend driver")
Signed-off-by: Abdun Nihaal <nihaal@cse.iitm.ac.in>
Reviewed-by: Juergen Gross <jgross@suse.com>
Link: https://patch.msgid.link/20251223063012.119035-1-nihaal@cse.iitm.ac.in
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/xen/xen-scsiback.c

index 954188b0b858a26e1cdf2195cddaecff6e8bbe5f..dcc9d15504df02bc03b6cb09e7adbb023f9b0720 100644 (file)
@@ -1261,6 +1261,7 @@ static void scsiback_remove(struct xenbus_device *dev)
        gnttab_page_cache_shrink(&info->free_pages, 0);
 
        dev_set_drvdata(&dev->dev, NULL);
+       kfree(info);
 }
 
 static int scsiback_probe(struct xenbus_device *dev,