]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
only execute additional tests if create call succeeds
authorMark Andrews <marka@isc.org>
Tue, 18 Nov 2014 01:19:37 +0000 (12:19 +1100)
committerMark Andrews <marka@isc.org>
Tue, 18 Nov 2014 01:19:37 +0000 (12:19 +1100)
lib/isc/tests/file_test.c

index b252b50580ed47b0ab09b7d7bd89689033a20ea6..5caed66b2abe95d179a68d997d0ee271e2b22604 100644 (file)
@@ -59,17 +59,21 @@ ATF_TC_BODY(isc_file_sanitize, tc) {
 
        fd = creat(F(TRUNC_SHA), 0644);
        ATF_CHECK(fd != -1);
-       result = isc_file_sanitize("testdata/file", NAME, "test", buf, 1024);
-       ATF_CHECK_EQ(result, ISC_R_SUCCESS);
-       ATF_CHECK(strcmp(buf, F(TRUNC_SHA)) == 0);
-       close(fd);
+       if (fd != -1) {
+               result = isc_file_sanitize("testdata/file", NAME, "test", buf, 1024);
+               ATF_CHECK_EQ(result, ISC_R_SUCCESS);
+               ATF_CHECK(strcmp(buf, F(TRUNC_SHA)) == 0);
+               close(fd);
+       }
 
        fd = creat(F(SHA), 0644);
        ATF_CHECK(fd != -1);
-       result = isc_file_sanitize("testdata/file", NAME, "test", buf, 1024);
-       ATF_CHECK_EQ(result, ISC_R_SUCCESS);
-       ATF_CHECK(strcmp(buf, F(SHA)) == 0);
-       close(fd);
+       if (fd != -1) {
+               result = isc_file_sanitize("testdata/file", NAME, "test", buf, 1024);
+               ATF_CHECK_EQ(result, ISC_R_SUCCESS);
+               ATF_CHECK(strcmp(buf, F(SHA)) == 0);
+               close(fd);
+       }
 
        result = isc_file_sanitize("testdata/file", BAD1, "test", buf, 1024);
        ATF_CHECK_EQ(result, ISC_R_SUCCESS);