]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Change the ISC_R_SUCCESS to DNS_RRL_RESULT_OK in dns_rrl()
authorOndřej Surý <ondrej@sury.org>
Mon, 4 Oct 2021 15:14:53 +0000 (17:14 +0200)
committerOndřej Surý <ondrej@sury.org>
Tue, 5 Oct 2021 20:13:29 +0000 (22:13 +0200)
There's value mismatch between the return type of dns_rrl() that's
dns_rrl_result_t and ISC_R_SUCCESS which belongs to isc_result_t.  This
works incidentally, because DNS_RRL_RESULT_OK == ISC_R_SUCCESS.

This would break when we change isc_result_t to be static enum in
consecutive commit.  Change the value to match the type.

lib/dns/rrl.c

index 9c009b2fdc276a90afbdd05fb276afd7b302fe81..758bb1ed8d7306e8592cab21d0377740d1eb6a6a 100644 (file)
@@ -1113,7 +1113,7 @@ dns_rrl(dns_view_t *view, const isc_sockaddr_t *client_addr, bool is_tcp,
                        }
                }
                UNLOCK(&rrl->lock);
-               return (ISC_R_SUCCESS);
+               return (DNS_RRL_RESULT_OK);
        }
 
        /*