Fix copy-paste error in test_ginpostinglist

The check for a mismatch on the second decoded item pointer
was an exact copy of the first item pointer check, comparing
orig_itemptrs[0] with decoded_itemptrs[0] instead of orig_itemptrs[1]
with decoded_itemptrs[1].  The error message also reported (0, 1) as
the expected value instead of (blk, off).  As a result, any decoding
error in the second item pointer (where the varbyte delta encoding
is exercised) would go undetected.

This has been wrong since commit bde7493d1, so backpatch to all
supported versions.

Author: Jianghua Yang <yjhjstz@gmail.com>
Discussion: https://postgr.es/m/CAAZLFmSOD8R7tZjRLZsmpKtJLoqjgawAaM-Pne1j8B_Q2aQK8w@mail.gmail.com
Backpatch-through: 14

diff --git a/src/test/modules/test_ginpostinglist/test_ginpostinglist.c b/src/test/modules/test_ginpostinglist/test_ginpostinglist.c
index 7ce515fcb70e8e972d9042f937925479ac830ef6..7c18ee52a4dac348e06911933787c80672c96fbf 100644 (file)
--- a/src/test/modules/test_ginpostinglist/test_ginpostinglist.c
+++ b/src/test/modules/test_ginpostinglist/test_ginpostinglist.c
@@ -72,12 +72,12 @@ test_itemptr_pair(BlockNumber blk, OffsetNumber off, int maxsize)
                         ItemPointerGetOffsetNumber(&decoded_itemptrs[0]));
 
        if (ndecoded == 2 &&
-               !ItemPointerEquals(&orig_itemptrs[0], &decoded_itemptrs[0]))
+               !ItemPointerEquals(&orig_itemptrs[1], &decoded_itemptrs[1]))
        {
                elog(ERROR, "mismatch on second itemptr: (%u, %d) vs (%u, %d)",
-                        0, 1,
-                        ItemPointerGetBlockNumber(&decoded_itemptrs[0]),
-                        ItemPointerGetOffsetNumber(&decoded_itemptrs[0]));
+                        blk, off,
+                        ItemPointerGetBlockNumber(&decoded_itemptrs[1]),
+                        ItemPointerGetOffsetNumber(&decoded_itemptrs[1]));
        }
 }