]> git.ipfire.org Git - thirdparty/openwrt.git/commitdiff
apm821xx: fix buttons and LEDs
authorRosen Penev <rosenp@gmail.com>
Thu, 21 May 2026 23:31:19 +0000 (16:31 -0700)
committerJonas Jelonek <jelonek.jonas@gmail.com>
Mon, 25 May 2026 08:16:49 +0000 (10:16 +0200)
Upstream transisitioned from an OF GPIO API to a generic one.
Unfortunately they forgot to set parent.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Link: https://github.com/openwrt/openwrt/pull/23382
Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
target/linux/apm821xx/patches-6.18/100-powerpc-44x-Set-GPIO-chip-firmware-node.patch [new file with mode: 0644]

diff --git a/target/linux/apm821xx/patches-6.18/100-powerpc-44x-Set-GPIO-chip-firmware-node.patch b/target/linux/apm821xx/patches-6.18/100-powerpc-44x-Set-GPIO-chip-firmware-node.patch
new file mode 100644 (file)
index 0000000..07682d8
--- /dev/null
@@ -0,0 +1,30 @@
+From 0f18b7fdec817f94ad9ebeb6076ad914e0334299 Mon Sep 17 00:00:00 2001
+From: Rosen Penev <rosenp@gmail.com>
+Date: Fri, 15 May 2026 15:54:59 -0700
+Subject: [PATCH] powerpc/44x: Set GPIO chip firmware node
+
+The PPC4xx GPIO driver stopped assigning an explicit firmware node
+to the gpio_chip when it moved away from of_mm_gpiochip_add_data().
+
+Restore that association from the platform device so OF GPIO lookup
+can match phandles to the registered gpiochip.
+
+Tested on: Cisco MX60W. No more probe deferral.
+
+Assisted-by: Codex:GPT-5.5
+Fixes: 1044dbaf2a77 ("powerpc/44x: Change GPIO driver to a proper platform driver")
+Signed-off-by: Rosen Penev <rosenp@gmail.com>
+---
+ arch/powerpc/platforms/44x/gpio.c | 2 ++
+ 1 file changed, 2 insertions(+)
+
+--- a/arch/powerpc/platforms/44x/gpio.c
++++ b/arch/powerpc/platforms/44x/gpio.c
+@@ -169,6 +169,7 @@ static int ppc4xx_gpio_probe(struct plat
+       gc = &chip->gc;
++      gc->parent = dev;
+       gc->base = -1;
+       gc->ngpio = 32;
+       gc->direction_input = ppc4xx_gpio_dir_in;