MEDIUM: ot: emitted deprecation warning at filter init

The opentracing filter was deprecated in haproxy 3.3 and will be removed
in 3.5.  A warning is now issued during filter initialization, unless the
global 'expose-deprecated-directives' directive is set.  The notice is
emitted only once regardless of the number of filter instances.

diff --git a/addons/ot/src/filter.c b/addons/ot/src/filter.c
index 0ae542eb4771c65a3e4a9c8235f4791a2545261e..ad8a64c1b145e9e8bc2ecbb37243214cdfc74197 100644 (file)
--- a/addons/ot/src/filter.c
+++ b/addons/ot/src/filter.c
@@ -155,12 +155,18 @@ static void flt_ot_return_void(const struct filter *f, char **err)
  */
 static int flt_ot_init(struct proxy *p, struct flt_conf *fconf)
 {
+       static int          warnings_emitted = 0;
        struct flt_ot_conf *conf = FLT_OT_DEREF(fconf, conf, NULL);
        char               *err = NULL;
        int                 retval = FLT_OT_RET_ERROR;
 
        FLT_OT_FUNC("%p, %p", p, fconf);
 
+       if (!warnings_emitted && !deprecated_directives_allowed) {
+               warnings_emitted++;
+               ha_warning("The opentracing filter was deprecated in haproxy 3.3 and will be removed in 3.5.\n");
+       }
+
        if (conf == NULL)
                FLT_OT_RETURN_INT(retval);