]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
auth/ntlmssp: don't send domain and workstation in the NEGOTIATE_MESSAGE
authorStefan Metzmacher <metze@samba.org>
Fri, 20 Nov 2015 09:52:29 +0000 (10:52 +0100)
committerStefan Metzmacher <metze@samba.org>
Thu, 10 Mar 2016 05:52:28 +0000 (06:52 +0100)
We don't set NTLMSSP_NEGOTIATE_OEM_{DOMAIN,WORKSTATION}_SUPPLIED anyway.

This matches modern Windows clients.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
auth/ntlmssp/ntlmssp_client.c

index afd5a002d193ac5f9651d77f44652e60a149ecec..61ca886aab642e4602b54c14d0d63ee691343395 100644 (file)
@@ -58,28 +58,16 @@ NTSTATUS ntlmssp_client_initial(struct gensec_security *gensec_security,
                talloc_get_type_abort(gensec_security->private_data,
                                      struct gensec_ntlmssp_context);
        struct ntlmssp_state *ntlmssp_state = gensec_ntlmssp->ntlmssp_state;
-       const char *domain = ntlmssp_state->client.netbios_domain;
-       const char *workstation = ntlmssp_state->client.netbios_name;
        NTSTATUS status;
 
-       /* These don't really matter in the initial packet, so don't panic if they are not set */
-       if (!domain) {
-               domain = "";
-       }
-
-       if (!workstation) {
-               workstation = "";
-       }
-
        /* generate the ntlmssp negotiate packet */
        status = msrpc_gen(out_mem_ctx,
                  out, "CddAA",
                  "NTLMSSP",
                  NTLMSSP_NEGOTIATE,
                  ntlmssp_state->neg_flags,
-                 domain,
-                 workstation);
-
+                 "",  /* domain */
+                 ""); /* workstation */
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(0, ("ntlmssp_client_initial: failed to generate "
                          "ntlmssp negotiate packet\n"));