spi: mtk-snfi: fix memory leak in probe

ms->buf is allocated in mtk_snand_setup_pagefmt() but was not freed on
the following error paths.

Fixes: 2b1e19811a8e ("spi: mtk-snfi: Change default page format to setup default setting")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Link: https://patch.msgid.link/20260416-mtk-snfi-v2-1-3f487689dacb@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/drivers/spi/spi-mtk-snfi.c b/drivers/spi/spi-mtk-snfi.c
index 73fa84475f0e445c217fce29ff481671392649a6..e616e6800e92fe11e0df40969044b58d30d34b40 100644 (file)
--- a/drivers/spi/spi-mtk-snfi.c
+++ b/drivers/spi/spi-mtk-snfi.c
@@ -1447,14 +1447,14 @@ static int mtk_snand_probe(struct platform_device *pdev)
        ret = nand_ecc_register_on_host_hw_engine(&ms->ecc_eng);
        if (ret) {
                dev_err(&pdev->dev, "failed to register ecc engine.\n");
-               goto release_ecc;
+               goto free_buf;
        }
 
        ret = devm_add_action_or_reset(&pdev->dev, mtk_unregister_ecc_engine,
                                       &ms->ecc_eng);
        if (ret) {
                dev_err_probe(&pdev->dev, ret, "failed to add ECC unregister action\n");
-               goto release_ecc;
+               goto free_buf;
        }
 
        ctlr->num_chipselect = 1;
@@ -1465,10 +1465,12 @@ static int mtk_snand_probe(struct platform_device *pdev)
        ret = spi_register_controller(ctlr);
        if (ret) {
                dev_err(&pdev->dev, "spi_register_controller failed.\n");
-               goto release_ecc;
+               goto free_buf;
        }
 
        return 0;
+free_buf:
+       kfree(ms->buf);
 release_ecc:
        mtk_ecc_release(ms->ecc);
        return ret;